fix: handle the cases of resolving destination for http backend (#177)

* fix: using path for setting destination for http backend

* fix: address spotless and corrected test

* fixes formatting

Author: kotharironak

hypertrace-trace-enricher/hypertrace-trace-enricher-impl/src/main/java/org/hypertrace/traceenricher/enrichment/enrichers/resolver/backend/HttpBackendResolver.java

@@ -66,11 +66,10 @@ public Optional<BackendInfo> resolve(Event event, StructuredTraceGraph structure
       if (httpOperation != null) {
         enrichedAttributes.put(BACKEND_OPERATION_ATTR, AttributeValueCreator.create(httpOperation));
       }
-      Optional<String> httpDestination = HttpSemanticConventionUtils.getHttpTarget(event);
-      httpDestination.ifPresent(
-          destination ->
-              enrichedAttributes.put(
-                  BACKEND_DESTINATION_ATTR, AttributeValueCreator.create(destination)));
+
+      if (StringUtils.isNotEmpty(path)) {
+        enrichedAttributes.put(BACKEND_DESTINATION_ATTR, AttributeValueCreator.create(path));
+      }
       return Optional.of(new BackendInfo(entityBuilder.build(), enrichedAttributes));
     }
     return Optional.empty();

hypertrace-trace-enricher/hypertrace-trace-enricher-impl/src/test/java/org/hypertrace/traceenricher/enrichment/enrichers/resolver/backend/BackendResolverTest.java

@@ -166,7 +166,9 @@ public void checkBackendEntityGeneratedFromHttpEventType1() {
 
     Map<String, AttributeValue> attributes = backendInfo.getAttributes();
     assertEquals(
-        Map.of("BACKEND_DESTINATION", AttributeValueCreator.create("/path/12314/?q=ddds#123")),
+        Map.of(
+            "BACKEND_DESTINATION",
+            AttributeValueCreator.create("/product/5d644175551847d7408760b1")),
         attributes);
   }
 

semantic-convention-utils/src/main/java/org/hypertrace/semantic/convention/utils/http/HttpSemanticConventionUtils.java

@@ -14,8 +14,6 @@
 import java.util.Map;
 import java.util.Optional;
 import org.hypertrace.core.datamodel.AttributeValue;
-import org.hypertrace.core.datamodel.Event;
-import org.hypertrace.core.datamodel.shared.SpanAttributeUtils;
 import org.hypertrace.core.semantic.convention.constants.http.OTelHttpSemanticConventions;
 import org.hypertrace.core.semantic.convention.constants.span.OTelSpanSemanticConventions;
 import org.hypertrace.core.span.constants.RawSpanConstants;
@@ -56,12 +54,6 @@ public static List<String> getAttributeKeysForHttpTarget() {
     return Lists.newArrayList(Sets.newHashSet(OTEL_HTTP_TARGET));
   }
 
-  public static Optional<String> getHttpTarget(Event event) {
-    return Optional.ofNullable(
-        SpanAttributeUtils.getFirstAvailableStringAttribute(
-            event, getAttributeKeysForHttpTarget()));
-  }
-
   /**
    * OTel mandates one of the following set to be present for http server span - http.scheme,
    * http.host, http.target - http.scheme, http.server_name, net.host.port, http.target -