aws s3 bucket channel (#156)

* aws s3 bucket channel

* repeated

* pr comments

* nit

* validationg

* nit

---------

Co-authored-by: Apoorv Jain <apoorvjain@Apoorvs-MacBook-Pro.local>

Author: Apoorv Jain

notification-channel-config-service-api/src/main/proto/org/hypertrace/notification/config/service/v1/notification_channel.proto

@@ -13,8 +13,22 @@ message NotificationChannelMutableData {
   string channel_name = 1;
   repeated EmailChannelConfig email_channel_config = 2;
   repeated WebhookChannelConfig webhook_channel_config = 3;
+  repeated AwsS3BucketChannelConfig s3_bucket_channel_config = 4;
 }
 
+message AwsS3BucketChannelConfig {
+  oneof authentication_credential {
+    WebIdentityAuthenticationCredential web_identity_auth_credential = 1;
+  }
+  string bucket_name = 2;
+  string region = 3;
+
+  message WebIdentityAuthenticationCredential {
+    string role_arn = 1;
+  }
+}
+
+
 enum WebhookFormat {
   WEBHOOK_FORMAT_UNSPECIFIED = 0;
   WEBHOOK_FORMAT_SLACK = 1;

notification-channel-config-service-impl/src/main/java/org/hypertrace/notification/config/service/NotificationChannelConfigServiceRequestValidator.java

@@ -5,12 +5,17 @@
 
 import io.grpc.Status;
 import org.hypertrace.core.grpcutils.context.RequestContext;
+import org.hypertrace.notification.config.service.v1.AwsS3BucketChannelConfig;
+import org.hypertrace.notification.config.service.v1.AwsS3BucketChannelConfig.WebIdentityAuthenticationCredential;
 import org.hypertrace.notification.config.service.v1.CreateNotificationChannelRequest;
 import org.hypertrace.notification.config.service.v1.DeleteNotificationChannelRequest;
+import org.hypertrace.notification.config.service.v1.EmailChannelConfig;
 import org.hypertrace.notification.config.service.v1.GetAllNotificationChannelsRequest;
 import org.hypertrace.notification.config.service.v1.GetNotificationChannelRequest;
 import org.hypertrace.notification.config.service.v1.NotificationChannelMutableData;
 import org.hypertrace.notification.config.service.v1.UpdateNotificationChannelRequest;
+import org.hypertrace.notification.config.service.v1.WebhookChannelConfig;
+import org.hypertrace.notification.config.service.v1.WebhookHeader;
 
 public class NotificationChannelConfigServiceRequestValidator {
 
@@ -30,11 +35,14 @@ public void validateUpdateNotificationChannelRequest(
   private void validateNotificationChannelMutableData(NotificationChannelMutableData data) {
     validateNonDefaultPresenceOrThrow(
         data, NotificationChannelMutableData.CHANNEL_NAME_FIELD_NUMBER);
-    if (data.getEmailChannelConfigCount() == 0 && data.getWebhookChannelConfigCount() == 0) {
-      throw Status.INVALID_ARGUMENT
-          .withDescription("Either email or webhook config should be present")
-          .asRuntimeException();
+    if (data.getEmailChannelConfigCount() == 0
+        && data.getWebhookChannelConfigCount() == 0
+        && data.getS3BucketChannelConfigCount() == 0) {
+      throw Status.INVALID_ARGUMENT.withDescription("No config present").asRuntimeException();
     }
+    data.getEmailChannelConfigList().forEach(this::validateEmailChannelConfig);
+    data.getWebhookChannelConfigList().forEach(this::validateWebhookChannelConfig);
+    data.getS3BucketChannelConfigList().forEach(this::validateS3BucketConfig);
   }
 
   public void validateGetAllNotificationChannelsRequest(
@@ -55,4 +63,37 @@ public void validateGetNotificationChannelRequest(
     validateNonDefaultPresenceOrThrow(
         request, GetNotificationChannelRequest.NOTIFICATION_CHANNEL_ID_FIELD_NUMBER);
   }
+
+  private void validateEmailChannelConfig(EmailChannelConfig emailChannelConfig) {
+    validateNonDefaultPresenceOrThrow(emailChannelConfig, EmailChannelConfig.ADDRESS_FIELD_NUMBER);
+  }
+
+  private void validateWebhookChannelConfig(WebhookChannelConfig webhookChannelConfig) {
+    validateNonDefaultPresenceOrThrow(webhookChannelConfig, WebhookChannelConfig.URL_FIELD_NUMBER);
+    validateNonDefaultPresenceOrThrow(
+        webhookChannelConfig, WebhookChannelConfig.FORMAT_FIELD_NUMBER);
+    webhookChannelConfig.getHeadersList().forEach(this::validateWebhookHeader);
+  }
+
+  private void validateS3BucketConfig(AwsS3BucketChannelConfig awsS3BucketChannelConfig) {
+    validateNonDefaultPresenceOrThrow(
+        awsS3BucketChannelConfig, AwsS3BucketChannelConfig.BUCKET_NAME_FIELD_NUMBER);
+    validateNonDefaultPresenceOrThrow(
+        awsS3BucketChannelConfig, AwsS3BucketChannelConfig.REGION_FIELD_NUMBER);
+    switch (awsS3BucketChannelConfig.getAuthenticationCredentialCase()) {
+      case WEB_IDENTITY_AUTH_CREDENTIAL:
+        validateNonDefaultPresenceOrThrow(
+            awsS3BucketChannelConfig.getWebIdentityAuthCredential(),
+            WebIdentityAuthenticationCredential.ROLE_ARN_FIELD_NUMBER);
+        break;
+      default:
+        throw Status.INVALID_ARGUMENT
+            .withDescription("No credentials present in AWS S3 bucket config")
+            .asRuntimeException();
+    }
+  }
+
+  private void validateWebhookHeader(WebhookHeader webhookHeader) {
+    validateNonDefaultPresenceOrThrow(webhookHeader, WebhookHeader.NAME_FIELD_NUMBER);
+  }
 }