chore: fix delete application rule error case (#279)

saxenakshitiz · saxenakshitiz · web-flow · commit 8354e93df3af · 2025-03-04T13:37:22.000-05:00
Co-authored-by: saxenakshitiz &lt;kshitiz@traceable.ai&gt;
diff --git a/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java b/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java
@@ -164,8 +164,9 @@ public void deleteLabelApplicationRule(
       if (customRuleDeleted || systemLabelApplicationRule.isPresent()) {
         responseObserver.onNext(DeleteLabelApplicationRuleResponse.getDefaultInstance());
         responseObserver.onCompleted();
+      } else {
+        throw Status.NOT_FOUND.asRuntimeException();
       }
-      throw Status.NOT_FOUND.asRuntimeException();
     } catch (Exception e) {
       responseObserver.onError(e);
     }

Original file line number	Diff line number	Diff line change
`@@ -164,8 +164,9 @@ public void deleteLabelApplicationRule(`
`164`	`164`	`if (customRuleDeleted \|\| systemLabelApplicationRule.isPresent()) {`
`165`	`165`	`responseObserver.onNext(DeleteLabelApplicationRuleResponse.getDefaultInstance());`
`166`	`166`	`responseObserver.onCompleted();`
	`167`	`+ } else {`
	`168`	`+ throw Status.NOT_FOUND.asRuntimeException();`
`167`	`169`	`}`
`168`		`- throw Status.NOT_FOUND.asRuntimeException();`
`169`	`170`	`} catch (Exception e) {`
`170`	`171`	`responseObserver.onError(e);`
`171`	`172`	`}`