Improved exception handling

Author: hu-zza

build.gradle

@@ -27,7 +27,7 @@ plugins {
 }
 
 group = 'hu.zza'
-project.version = '0.3.0'
+project.version = '0.3.1'
 sourceCompatibility = '11'
 
 repositories {

src/main/java/hu/zza/clim/ClimException.java

@@ -0,0 +1,43 @@
+/*
+ *
+ * clim  //  Command Line Interface Menu
+ *       //  https://git.zza.hu/clim
+ *
+ * Copyright (C) 2020-2021 Szabó László András // hu-zza
+ *
+ * This file is part of clim.
+ *
+ * clim is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * clim is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+package hu.zza.clim;
+
+public class ClimException extends RuntimeException {
+
+  public ClimException() {
+    super();
+  }
+
+  public ClimException(String message) {
+    super(message);
+  }
+
+  public ClimException(String message, Throwable cause) {
+    super(message, cause);
+  }
+
+  public ClimException(Throwable cause) {
+    super(cause);
+  }
+}

src/main/java/hu/zza/clim/Menu.java

@@ -155,7 +155,7 @@ private void tryToChooseAnOption(String input) {
           inputProcessorService.processInputRelatedToOptions(input, options));
     } catch (Exception e) {
       positionHistory.pollFirst();
-      warnAboutInput(input, e);
+      throw new ClimException(PROCESSING_FAILED.getMessage(input), e);
     }
   }
 
@@ -164,14 +164,6 @@ private void chooseOptionByProcessedInput(ProcessedInput processedInput) {
     position = menuStructure.get(selected).select(processedInput);
   }
 
-  private static void warnAboutInput(String input, Exception e) {
-    if (e.getMessage() != null) {
-      System.err.print(PROCESSING_FAILED.getMessage(input, e.getMessage()));
-    } else {
-      System.err.print(PROCESSING_FAILED.getMessage(input, ""));
-      e.printStackTrace();
-    }
-  }
 
   private Position returnValidatedPositionOrThrow(Position position) {
     refreshOptions();

src/main/java/hu/zza/clim/MenuStructureBuilder.java

@@ -23,6 +23,8 @@
 
 package hu.zza.clim;
 
+import static hu.zza.clim.menu.Message.INITIALIZATION_FAILED;
+
 import com.google.gson.JsonArray;
 import com.google.gson.JsonElement;
 import com.google.gson.JsonObject;
@@ -100,6 +102,14 @@ private void clearBuilt() {
   }
 
   public MenuStructure build() {
+    try {
+      return buildMenuStructure();
+    } catch (Exception e) {
+      throw new IllegalArgumentException(INITIALIZATION_FAILED.getMessage(e.getMessage()), e);
+    }
+  }
+
+  private MenuStructure buildMenuStructure() {
     clearBuilt();
     findAllNodesAndLeaves();
     checkBeforeBuild();

src/main/resources/MessageTemplate.properties

@@ -28,7 +28,7 @@ MENU_OPTION_DECORATOR=%s
 MENU_ORDINAL_OPTION_DECORATOR=%d. %s
 MENU_HISTORY_SEPARATOR=>
 
-PROCESSING_FAILED=The menu can not process the given input: '%s'%nCause: %s%n
+PROCESSING_FAILED=The menu can not process the given input: '%s'%n
 INITIALIZATION_FAILED=Object initialization fails because of parameter invalidity:%n%s%n
 
 STOP_BECAUSE_NULL=Execution stopped because of the value of the '%s': It cannot be null.

src/test/java/MenuBuilderTestInteractive.java

@@ -21,6 +21,7 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
+import hu.zza.clim.ClimException;
 import hu.zza.clim.HeaderStyle;
 import hu.zza.clim.Menu;
 import hu.zza.clim.MenuBuilder;
@@ -115,7 +116,11 @@ public static void main(String[] args) throws Exception {
       while (waitingForUserInput) {
         menu.listOptions();
         if (scanner.hasNext()) {
-          menu.chooseOption(scanner.nextLine());
+          try {
+            menu.chooseOption(scanner.nextLine());
+          } catch (ClimException e) {
+            System.err.println(e.getMessage());
+          }
         } else {
           waitingForUserInput = false;
         }