Adjust ESLint, TypeScript configs and tests

Update ESLint rules and ignores, add test-specific overrides, and tighten TypeScript compiler options across packages. ESLint: reorder and extend rules (add no-useless-assignment), change ignored paths (add test/out/**), add overrides to expose Mocha globals for test/**/*.ts and disable no-console for test/runTest.ts. TypeScript: align and enable options such as allowSyntheticDefaultImports, esModuleInterop, noEmitOnError, strict flags, sourceMap, outDir and target (ES2022) in htmlhint-server, htmlhint and test tsconfig files. Tests: simplify .htmlhintrc existence checks in htmlhint.test.ts by failing directly in catch blocks instead of tracking a boolean and redundant assertions.

Author: coliff

eslint.config.js

@@ -14,11 +14,11 @@ const strictRules = {
 module.exports = [
   {
     ignores: [
-      "test/**",
       "**/*.d.ts",
       "out/**",
       "htmlhint/out/**",
       "htmlhint-server/out/**",
+      "test/out/**",
       ".vscode-test/**",
       "node_modules/**",
       "htmlhint/node_modules/**",
@@ -45,14 +45,15 @@ module.exports = [
       "@typescript-eslint": tseslint,
     },
     rules: {
-      ...tseslint.configs.recommended.rules,
       ...strictRules,
-      "no-console": "error",
-      "no-empty": "off",
+      ...tseslint.configs.recommended.rules,
       "@typescript-eslint/explicit-module-boundary-types": "off",
       "@typescript-eslint/no-empty-interface": "off",
       "@typescript-eslint/no-explicit-any": "off",
       "@typescript-eslint/no-non-null-assertion": "off",
+      "no-console": "error",
+      "no-empty": "off",
+      "no-useless-assignment": "error",
       // Disable base no-unused-vars rule for TypeScript files to prevent conflicts
       "no-unused-vars": "off",
       "@typescript-eslint/no-unused-vars": [
@@ -66,6 +67,20 @@ module.exports = [
       "@typescript-eslint/no-var-requires": "off",
     },
   },
+  {
+    files: ["test/**/*.ts"],
+    languageOptions: {
+      globals: {
+        ...globals.mocha,
+      },
+    },
+  },
+  {
+    files: ["test/runTest.ts"],
+    rules: {
+      "no-console": "off",
+    },
+  },
   {
     files: ["**/*.js"],
     languageOptions: {
@@ -80,6 +95,7 @@ module.exports = [
       ...strictRules,
       "no-console": "error",
       "no-empty": "off",
+      "no-useless-assignment": "error",
       "no-unused-vars": [
         "error",
         {

htmlhint-server/src/tsconfig.json

@@ -1,35 +1,36 @@
 {
   "compilerOptions": {
+    "allowSyntheticDefaultImports": true,
+    "alwaysStrict": true,
+    "declaration": true,
+    "declarationMap": true,
+    "esModuleInterop": true,
+    "exactOptionalPropertyTypes": false,
+    "forceConsistentCasingInFileNames": true,
     "module": "commonjs",
-    "target": "ES2022",
     "lib": ["ES2022"],
     "moduleResolution": "node",
-    "outDir": "../../htmlhint/server",
-    "sourceMap": true,
-    "declaration": true,
-    "declarationMap": true,
-    "strict": true,
+    "noEmitOnError": true,
+    "noFallthroughCasesInSwitch": true,
     "noImplicitAny": false,
-    "noImplicitReturns": true,
     "noImplicitThis": true,
     "noImplicitOverride": true,
-    "strictNullChecks": false,
-    "strictFunctionTypes": true,
-    "strictBindCallApply": true,
-    "strictPropertyInitialization": false,
-    "alwaysStrict": true,
+    "noImplicitReturns": true,
+    "noPropertyAccessFromIndexSignature": false,
+    "noUncheckedIndexedAccess": false,
     "noUnusedLocals": false,
     "noUnusedParameters": false,
-    "exactOptionalPropertyTypes": false,
-    "noFallthroughCasesInSwitch": true,
-    "noUncheckedIndexedAccess": false,
-    "noPropertyAccessFromIndexSignature": false,
-    "esModuleInterop": true,
-    "allowSyntheticDefaultImports": true,
+    "outDir": "../../htmlhint/server",
     "resolveJsonModule": true,
-    "forceConsistentCasingInFileNames": true,
     "skipLibCheck": true,
     "incremental": true,
+    "sourceMap": true,
+    "strict": true,
+    "strictBindCallApply": true,
+    "strictFunctionTypes": true,
+    "strictNullChecks": false,
+    "strictPropertyInitialization": false,
+    "target": "ES2022",
     "tsBuildInfoFile": ".tsbuildinfo"
   },
   "include": ["**/*.ts"],

htmlhint/tsconfig.json

@@ -1,35 +1,36 @@
 {
   "compilerOptions": {
+    "allowSyntheticDefaultImports": true,
+    "alwaysStrict": true,
+    "declaration": true,
+    "declarationMap": true,
+    "esModuleInterop": true,
+    "exactOptionalPropertyTypes": true,
+    "forceConsistentCasingInFileNames": true,
     "module": "commonjs",
-    "target": "ES2022",
     "lib": ["ES2022", "DOM"],
     "moduleResolution": "node",
-    "outDir": "out",
-    "sourceMap": true,
-    "declaration": true,
-    "declarationMap": true,
-    "strict": true,
+    "noEmitOnError": true,
+    "noFallthroughCasesInSwitch": true,
     "noImplicitAny": true,
-    "noImplicitReturns": true,
     "noImplicitThis": true,
     "noImplicitOverride": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
-    "strictBindCallApply": true,
-    "strictPropertyInitialization": true,
-    "alwaysStrict": true,
+    "noImplicitReturns": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noUncheckedIndexedAccess": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
-    "exactOptionalPropertyTypes": true,
-    "noFallthroughCasesInSwitch": true,
-    "noUncheckedIndexedAccess": true,
-    "noPropertyAccessFromIndexSignature": false,
-    "esModuleInterop": true,
-    "allowSyntheticDefaultImports": true,
+    "outDir": "out",
     "resolveJsonModule": true,
-    "forceConsistentCasingInFileNames": true,
     "skipLibCheck": true,
     "incremental": true,
+    "sourceMap": true,
+    "strict": true,
+    "strictBindCallApply": true,
+    "strictFunctionTypes": true,
+    "strictNullChecks": true,
+    "strictPropertyInitialization": true,
+    "target": "ES2022",
     "tsBuildInfoFile": ".tsbuildinfo"
   },
   "include": ["extension.ts", "**/*.ts"],

test/suite/htmlhint.test.ts

@@ -31,30 +31,19 @@ suite("HTMLHint Test Suite", () => {
         __dirname,
         "../../../test/testConfigFile/.htmlhintrc",
       );
-      let configExists = false;
       try {
         await vscode.workspace.fs.stat(vscode.Uri.file(testConfigPath));
-        configExists = true;
       } catch {
-        configExists = false;
+        assert.fail(".htmlhintrc should exist in test config directory");
       }
-      assert.strictEqual(
-        configExists,
-        true,
-        ".htmlhintrc should exist in test config directory",
-      );
       return;
     }
 
     const configPath = path.join(workspaceFolder.uri.fsPath, ".htmlhintrc");
-    let configExists = false;
     try {
       await vscode.workspace.fs.stat(vscode.Uri.file(configPath));
-      configExists = true;
     } catch {
-      configExists = false;
+      assert.fail(".htmlhintrc should exist");
     }
-
-    assert.strictEqual(configExists, true, ".htmlhintrc should exist");
   });
 });

test/tsconfig.json

@@ -1,29 +1,33 @@
 {
   "compilerOptions": {
+    "allowSyntheticDefaultImports": true,
+    "alwaysStrict": true,
+    "esModuleInterop": true,
+    "exactOptionalPropertyTypes": true,
+    "forceConsistentCasingInFileNames": true,
     "module": "commonjs",
-    "target": "ES2022",
     "lib": ["ES2022", "DOM"],
     "moduleResolution": "node",
-    "outDir": "out",
-    "sourceMap": true,
-    "strict": true,
+    "noEmitOnError": true,
+    "noFallthroughCasesInSwitch": true,
     "noImplicitAny": true,
-    "noImplicitReturns": true,
     "noImplicitThis": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
-    "strictBindCallApply": true,
-    "alwaysStrict": true,
-    "noUnusedLocals": false,
-    "noUnusedParameters": false,
-    "noFallthroughCasesInSwitch": true,
-    "noUncheckedIndexedAccess": false,
-    "esModuleInterop": true,
-    "allowSyntheticDefaultImports": true,
+    "noImplicitOverride": true,
+    "noImplicitReturns": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noUncheckedIndexedAccess": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "outDir": "out",
     "resolveJsonModule": true,
-    "forceConsistentCasingInFileNames": true,
+    "sourceMap": true,
     "types": ["node", "mocha"],
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "strict": true,
+    "strictBindCallApply": true,
+    "strictFunctionTypes": true,
+    "strictNullChecks": true,
+    "target": "ES2022"
   },
   "include": ["suite/**/*.ts", "runTest.ts"],
   "exclude": ["node_modules"]