Revert "tls: Defer profile manager initialization until informer sync"

This reverts commit 97a5bd2.

Author: hongkailiu

pkg/cvo/cvo.go

@@ -138,9 +138,7 @@ type Operator struct {
 	apiServerLister       configlistersv1.APIServerLister
 	cacheSynced           []cache.InformerSynced
 
-	apiServerInformer configinformersv1.APIServerInformer
-	tlsOverrides      *cvotls.Settings
-	profileMgr        *cvotls.ProfileManager
+	profileMgr *cvotls.ProfileManager
 
 	// queue tracks applying updates to a cluster.
 	queue workqueue.TypedRateLimitingInterface[any]
@@ -322,10 +320,6 @@ func New(
 	optr.apiServerLister = apiServerInformer.Lister()
 	optr.cacheSynced = append(optr.cacheSynced, apiServerInformer.Informer().HasSynced)
 
-	// Store for deferred TLS profile manager initialization (after informer sync)
-	optr.apiServerInformer = apiServerInformer
-	optr.tlsOverrides = overrides
-
 	// make sure this is initialized after all the listers are initialized
 	riskSourceCallback := func() { optr.availableUpdatesQueue.Add(optr.queueKey()) }
 
@@ -379,18 +373,13 @@ func New(
 		},
 	)
 
-	return optr, nil
-}
-
-// InitializeProfileManager initializes the TLS profile manager.
-// Must be called after informers are started and synced.
-func (optr *Operator) InitializeProfileManager() error {
-	profileMgr, err := cvotls.NewProfileManager(optr.apiServerInformer, optr.tlsOverrides)
+	profileMgr, err := cvotls.NewProfileManager(apiServerInformer, overrides)
 	if err != nil {
-		return fmt.Errorf("failed to initialize TLS profile manager: %w", err)
+		return nil, fmt.Errorf("failed to initialize TLS profile manager: %w", err)
 	}
 	optr.profileMgr = profileMgr
-	return nil
+
+	return optr, nil
 }
 
 // LoadInitialPayload waits until a ClusterVersion object exists. It then retrieves the payload contents, verifies the

pkg/start/start.go

@@ -364,11 +364,6 @@ func (o *Options) run(ctx context.Context, controllerCtx *Context, lock resource
 		}
 	}
 
-	// Initialize TLS profile manager after informers are synced
-	if err := controllerCtx.CVO.InitializeProfileManager(); err != nil {
-		klog.Fatalf("Failed to initialize TLS profile manager: %v", err)
-	}
-
 	resultChannelCount++
 	go func() {
 		defer utilruntime.HandleCrash()