Fixes some clippy- and docs-warnings

Author: hoijui

src/license.rs

@@ -139,8 +139,7 @@ impl Detector {
                     && entry
                         .file_name()
                         .map(OsStr::to_string_lossy)
-                        .map(is_license_file)
-                        .unwrap_or_default()
+                        .is_some_and(is_license_file)
             })
             .filter_map(|entry| {
                 let contents = fs::read_to_string(entry.as_path()).unwrap_or_default(); // TODO Not too clean; we should possibly fail the function instead of silently skipping the file on error

src/settings.rs

@@ -6,7 +6,7 @@ use clap::ValueEnum;
 use lazy_static::lazy_static;
 use std::{collections::HashSet, path::PathBuf};
 use strum::IntoEnumIterator;
-use strum_macros::{EnumIter, EnumString, EnumVariantNames, IntoStaticStr};
+use strum_macros::{EnumIter, EnumString, IntoStaticStr, VariantNames};
 use url::Url;
 
 use crate::{
@@ -19,7 +19,7 @@ use crate::{
     Debug,
     ValueEnum,
     EnumString,
-    EnumVariantNames,
+    VariantNames,
     EnumIter,
     IntoStaticStr,
     PartialEq,
@@ -79,7 +79,7 @@ impl From<bool> for Verbosity {
     }
 }
 
-#[derive(Debug, ValueEnum, EnumString, EnumVariantNames, IntoStaticStr, Clone, Copy)]
+#[derive(Debug, ValueEnum, EnumString, VariantNames, IntoStaticStr, Clone, Copy)]
 pub enum Overwrite {
     All,
     None,

src/tools/git.rs

@@ -57,7 +57,7 @@ pub enum TransferProtocol {
     /// Example:
     /// `"https://gitlab.com/hoijui/kicad-text-injector.git"`
     Https,
-    /// SSH - Secure SHell
+    /// SSH - **S**ecure **Sh**ell
     /// Documentation:
     /// <https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#_the_ssh_protocol>
     /// Example:

src/tools/git_hosting_provs.rs

@@ -7,30 +7,30 @@ use clap::ValueEnum;
 /// both the actual hosters (github.com, gitlab.com, bitbucket.org, ...),
 /// as well as the software (gitlab, gitea, ...).
 use std::str;
-use strum_macros::{EnumString, EnumVariantNames, IntoStaticStr};
+use strum_macros::{EnumString, IntoStaticStr, VariantNames};
 use url::Host;
 
 use crate::constants;
 
 use super::git::TransferProtocol;
 
-#[derive(Debug, EnumString, EnumVariantNames, IntoStaticStr, PartialEq, Eq, Clone, Copy)]
+#[derive(Debug, EnumString, VariantNames, IntoStaticStr, PartialEq, Eq, Clone, Copy)]
 pub enum PublicSite {
     /// <https://github.com> - commercial, free OS hosting, software is proprietary
     GitHubCom,
     /// <https://gitlab.com> - commercial, free OS hosting, software is OSS
     GitLabCom,
     /// <https://bitbucket.org> - commercial, free OS hosting, software is proprietary
     BitBucketOrg,
-    /// <https://git.sr.ht> - free OS hosting, software is OSS: SourceHut
+    /// <https://git.sr.ht> - free OS hosting, software is OSS: `SourceHut`
     SourceHut,
-    /// <https://codeberg.org> - hosts only OS, software is OSS: Gitea
+    /// <https://codeberg.org> - hosts only OS, software is OSS: `Gitea`
     CodeBergOrg,
-    /// <https://repo.or.cz> - hosts only OS, software is OSS: Girocco
+    /// <https://repo.or.cz> - hosts only OS, software is OSS: `Girocco`
     RepoOrCz,
-    /// <https://sourceforge.net> - hosts only OS, software is OSS: Allura
+    /// <https://sourceforge.net> - hosts only OS, software is OSS: `Allura`
     RocketGitCom,
-    /// <https://rocketgit.com> - hosts only OS, software is OSS: RocketGit
+    /// <https://rocketgit.com> - hosts only OS, software is OSS: `RocketGit`
     SourceForgeNet,
     /// NOTE: The rust masters said, this is better then `Option<None>`!
     Unknown,
@@ -100,17 +100,15 @@ impl From<Option<Host<&str>>> for PublicSite {
     }
 }
 
-#[derive(
-    Debug, ValueEnum, EnumString, EnumVariantNames, IntoStaticStr, PartialEq, Eq, Clone, Copy,
-)]
+#[derive(Debug, ValueEnum, EnumString, VariantNames, IntoStaticStr, PartialEq, Eq, Clone, Copy)]
 pub enum HostingType {
     /// <https://github.com> - proprietary
     GitHub,
     /// <https://about.gitlab.com> - OSS
     GitLab,
     /// <https://bitbucket.org> - proprietary
     BitBucket,
-    /// <https://sr.ht/~sircmpwn/sourcehut> - OSS - LowTech (no JS) hacker tool, (almost) suckless style
+    /// <https://sr.ht/~sircmpwn/sourcehut> - OSS - Low-tech (no JS) hacker tool, (almost) suckless style
     SourceHut,
     /// <https://gitea.io> - OSS
     Gitea,