Skip to content

Commit 233e8eb

Browse files
committed
fix: suggestions from code review
1 parent 977715e commit 233e8eb

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

  • libs/@local/hashql/eval/src/postgres/filter

libs/@local/hashql/eval/src/postgres/filter/tests.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ use crate::{
4848
/// and returns everything needed for compilation.
4949
struct Fixture<'heap> {
5050
env: Environment<'heap>,
51+
interner: crate::intern::Interner<'heap>,
5152
bodies: DefIdVec<Body<'heap>, &'heap Heap>,
5253
execution: DefIdVec<Option<ExecutionAnalysisResidual<&'heap Heap>>, &'heap Heap>,
5354
}
@@ -89,6 +90,7 @@ impl<'heap> Fixture<'heap> {
8990

9091
Self {
9192
env,
93+
interner: interner.into(),
9294
bodies,
9395
execution,
9496
}
@@ -151,11 +153,10 @@ fn format_body<'heap>(fixture: &Fixture<'heap>, heap: &'heap Heap) -> String {
151153
fn compile_filter_islands<'heap>(fixture: &Fixture<'heap>, heap: &'heap Heap) -> FilterReport {
152154
let mut scratch = Scratch::new();
153155
let def = fixture.def();
154-
let interner = crate::intern::Interner::testing(heap);
155156

156157
let context = CodeGenerationContext::new_in(
157158
&fixture.env,
158-
&interner,
159+
&fixture.interner,
159160
&fixture.bodies,
160161
&fixture.execution,
161162
heap,
@@ -278,11 +279,10 @@ fn compile_full_query_with_mask<'heap>(
278279
) -> QueryReport {
279280
let mut scratch = Scratch::new();
280281
let def = fixture.def();
281-
let interner = crate::intern::Interner::testing(heap);
282282

283283
let mut context = CodeGenerationContext::new_in(
284284
&fixture.env,
285-
&interner,
285+
&fixture.interner,
286286
&fixture.bodies,
287287
&fixture.execution,
288288
heap,

0 commit comments

Comments
 (0)