Simplify notification configuration iterator and remove page_number option

Author: TanyaSingh369-svg

src/pytfe/models/notification_configuration.py

@@ -188,26 +188,21 @@ class NotificationConfigurationListOptions:
     """Represents the options for listing notification configurations."""
 
     # Type annotations for instance attributes
-    page_number: int | None
     page_size: int | None
     subscribable_choice: NotificationConfigurationSubscribableChoice | None
 
     def __init__(
         self,
-        page_number: int | None = None,
         page_size: int | None = None,
         subscribable_choice: NotificationConfigurationSubscribableChoice | None = None,
     ):
-        self.page_number = page_number
         self.page_size = page_size
         self.subscribable_choice = subscribable_choice
 
     def to_dict(self) -> dict[str, Any]:
         """Convert to dictionary for API requests."""
         params = {}
 
-        if self.page_number is not None:
-            params["page[number]"] = self.page_number
         if self.page_size is not None:
             params["page[size]"] = self.page_size
 

src/pytfe/resources/notification_configuration.py

@@ -42,16 +42,9 @@ def list(
             path = f"/api/v2/workspaces/{subscribable_id}/notification-configurations"
 
         params = options.to_dict() if options else None
-        if params:
-            params.pop("page[number]", None)
-            params.pop("page[size]", None)
-            params.pop("page_number", None)
 
-        def _gen() -> Iterator[NotificationConfiguration]:
-            for d in self._list(path, params=params):
-                yield self._parse_notification_configuration(d)
-
-        return _gen()
+        for d in self._list(path, params=params):
+            yield self._parse_notification_configuration(d)
 
     def create(
         self, subscribable_id: str, options: NotificationConfigurationCreateOptions

tests/units/test_notification_configuration.py

@@ -145,12 +145,12 @@ def test_list_with_pagination(self):
 
         # Test with pagination
         workspace_id = "ws-123456789"
-        options = NotificationConfigurationListOptions(page_number=2, page_size=50)
+        options = NotificationConfigurationListOptions(page_size=50)
 
         result_iter = self.notifications.list(workspace_id, options)
         _ = list(result_iter)
 
-        # Verify API call with default pagination keys
+        # page_size from options is respected by _list(); page[number] is controlled by _list()
         self.mock_transport.request.assert_called_once()
         call_args = self.mock_transport.request.call_args
         assert call_args[0][0] == "GET"
@@ -162,12 +162,12 @@ def test_list_with_pagination(self):
         assert isinstance(params, dict)
         assert "page[number]" in params and "page[size]" in params
         assert params["page[number]"] == 1
-        assert params["page[size]"] == 100
+        assert params["page[size]"] == 50
 
     def test_list_invalid_id(self):
         """Test list with invalid subscribable ID."""
         with pytest.raises(InvalidOrgError):
-            self.notifications.list("")
+            list(self.notifications.list(""))
 
     def test_create_workspace_notification(self):
         """Test creating a notification configuration for a workspace."""
@@ -642,10 +642,10 @@ def test_notification_configuration_list(self):
 
     def test_list_options_to_dict(self):
         """Test list options conversion to dictionary."""
-        options = NotificationConfigurationListOptions(page_number=2, page_size=50)
+        options = NotificationConfigurationListOptions(page_size=50)
         result = options.to_dict()
 
-        assert result == {"page[number]": 2, "page[size]": 50}
+        assert result == {"page[size]": 50}
 
     def test_create_options_to_dict(self):
         """Test create options conversion to dictionary."""