fix for other resources

Author: iam404

CHANGELOG.md

@@ -2,8 +2,8 @@
 
 ## Bug Fixes
 
-### Variables
-* Fixed `variables.list()` / `variables.list_all()` infinite-looping on workspaces with 100 or more variables, so they are now fetched with a single request. The generic list helper also treats any response without `meta.pagination` as a single complete page, preventing the same loop on other non-paginated endpoints. [#181](https://github.com/hashicorp/python-tfe/issues/181)
+### Pagination
+* Fixed `list_*` infinite-looping for API call which are non paginated, so they are now fetched with a single request. The generic list helper also treats any response without `meta.pagination` as a single complete page, preventing the same loop on other non-paginated endpoints. [#181](https://github.com/hashicorp/python-tfe/issues/181)
 
 
 # Released

src/pytfe/resources/no_code_module.py

@@ -255,11 +255,12 @@ def read_variables(
         if not valid_string(version):
             raise InvalidVersionError()
 
+        # module-variables is not paginated; fetch the full set in one request.
         path = (
             f"/api/v2/no-code-modules/{no_code_module_id}"
             f"/versions/{version}/module-variables"
         )
-        for item in self._list(path):
+        for item in self._list(path, paginated=False):
             attrs = item.get("attributes") or {}
             yield RegistryModuleVariable.model_validate(
                 {

src/pytfe/resources/projects.py

@@ -320,8 +320,9 @@ def list_effective_tag_bindings(
         if not valid_string_id(project_id):
             raise ValueError("Project ID is required and must be valid")
 
+        # effective-tag-bindings is not paginated.
         path = f"/api/v2/projects/{project_id}/effective-tag-bindings"
-        for item in self._list(path):
+        for item in self._list(path, paginated=False):
             attr = item.get("attributes", {}) or {}
             links = item.get("links", {}) or {}
             yield EffectiveTagBinding(

src/pytfe/resources/run_event.py

@@ -26,8 +26,9 @@ def list(
         params: dict[str, Any] = {}
         if options and options.include:
             params["include"] = ",".join(options.include)
+        # The run-events endpoint is not paginated; fetch the full set in one request.
         path = f"/api/v2/runs/{run_id}/run-events"
-        for item in self._list(path, params=params):
+        for item in self._list(path, params=params, paginated=False):
             attrs = item.get("attributes", {})
             attrs["id"] = item.get("id")
             yield RunEvent.model_validate(attrs)

src/pytfe/resources/workspaces.py

@@ -744,8 +744,9 @@ def list_tag_bindings(self, workspace_id: str) -> Iterator[TagBinding]:
         if not valid_string_id(workspace_id):
             raise InvalidWorkspaceIDError()
 
+        # tag-bindings is not paginated.
         path = f"/api/v2/workspaces/{workspace_id}/tag-bindings"
-        for item in self._list(path):
+        for item in self._list(path, paginated=False):
             attr = item.get("attributes", {}) or {}
             yield TagBinding(
                 id=item.get("id"),
@@ -759,8 +760,9 @@ def list_effective_tag_bindings(
         if not valid_string_id(workspace_id):
             raise InvalidWorkspaceIDError()
 
+        # effective-tag-bindings is not paginated.
         path = f"/api/v2/workspaces/{workspace_id}/effective-tag-bindings"
-        for item in self._list(path):
+        for item in self._list(path, paginated=False):
             attr = item.get("attributes", {}) or {}
             yield EffectiveTagBinding(
                 id=item.get("id", ""),

tests/units/test_run_events.py

@@ -72,6 +72,7 @@ def test_list_run_events_success(self, run_events_service):
             mock_list.assert_called_once_with(
                 "/api/v2/runs/run-123/run-events",
                 params={"include": "actor"},
+                paginated=False,
             )
 
             # Verify results
@@ -113,6 +114,7 @@ def test_list_run_events_with_multiple_includes(self, run_events_service):
             mock_list.assert_called_once_with(
                 "/api/v2/runs/run-456/run-events",
                 params={"include": "actor,comment"},
+                paginated=False,
             )
 
             assert len(results) == 1
@@ -140,6 +142,7 @@ def test_list_run_events_no_options(self, run_events_service):
             mock_list.assert_called_once_with(
                 "/api/v2/runs/run-789/run-events",
                 params={},
+                paginated=False,
             )
 
             assert len(results) == 1

tests/units/test_workspaces.py

@@ -1040,10 +1040,11 @@ def test_list_tag_bindings_basic(self, workspaces_service, mock_transport):
         tag_bindings = list(workspaces_service.list_tag_bindings("ws-123"))
 
         # Verify API call
+        # tag-bindings is non-paginated: a single request with no page params.
         mock_transport.request.assert_called_once_with(
             "GET",
             "/api/v2/workspaces/ws-123/tag-bindings",
-            params={"page[number]": 1, "page[size]": 100},
+            params={},
         )
 
         # Verify returned data
@@ -1096,10 +1097,11 @@ def test_list_effective_tag_bindings_basic(
         )
 
         # Verify API call
+        # effective-tag-bindings is non-paginated: one request, no page params.
         mock_transport.request.assert_called_once_with(
             "GET",
             "/api/v2/workspaces/ws-123/effective-tag-bindings",
-            params={"page[number]": 1, "page[size]": 100},
+            params={},
         )
 
         # Verify returned data