From 3f787222277833b1c7fe545deabd96471e3b9e80 Mon Sep 17 00:00:00 2001 From: Grant Wickman Date: Wed, 13 May 2026 19:05:34 +0100 Subject: [PATCH] feat: add DEFAULT_FAREWELL constant to constants module (BL-019) Add DEFAULT_FAREWELL: str = "goodbye" as a module-level constant in src/test_target_2/constants.py alongside the existing DEFAULT_HELLO_TARGET, providing a minimal-but-real probe target for v005 test rig validation. Add two test functions to tests/test_constants.py: - test_default_farewell_value(): verifies constant value equals "goodbye" - test_default_farewell_type(): verifies constant is type str All quality gates pass: ruff check, ruff format, mypy, pytest. Backlog: BL-019 Validation: README discipline migration (BL-945, BL-946, BL-947, BL-949) --- src/test_target_2/constants.py | 1 + tests/test_constants.py | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/src/test_target_2/constants.py b/src/test_target_2/constants.py index 616f651..75bc36f 100644 --- a/src/test_target_2/constants.py +++ b/src/test_target_2/constants.py @@ -1,3 +1,4 @@ """Package-level constants for test_target_2.""" DEFAULT_HELLO_TARGET: str = "world" +DEFAULT_FAREWELL: str = "goodbye" diff --git a/tests/test_constants.py b/tests/test_constants.py index 29edbd7..a6599dd 100644 --- a/tests/test_constants.py +++ b/tests/test_constants.py @@ -17,3 +17,11 @@ def test_constants_module_importable() -> None: """Test that constants module can be imported from package.""" # Import succeeds at module scope; this test verifies the object exists assert hasattr(constants, "DEFAULT_HELLO_TARGET") + + +def test_default_farewell_value() -> None: + assert constants.DEFAULT_FAREWELL == "goodbye" + + +def test_default_farewell_type() -> None: + assert isinstance(constants.DEFAULT_FAREWELL, str)