mirror of
https://github.com/nesquena/hermes-webui.git
synced 2026-05-25 19:20:16 +00:00
nesquena-hermes
d3c8a7c6a5
The file-tree row tooltip says 'Double-click to rename' on every entry, but folders don't actually rename on double-click — they navigate via loadDir(). The tooltip is therefore misleading on directory rows. Reported by @Deor in the WebUI Discord testers thread (May 5 2026): 'Ah that works yeah. May want to change the popup text as it also says double click at the moment.' Fix: gate the tooltip on item.type !== 'dir' so it only attaches to file rows, where double-click does what the hint advertises. Folder rename still reachable via the right-click context menu (unchanged). Companion to #1698/#1702/#1707 — completes the rename-affordance triage: - #1698 fixed: dblclick rename was unreachable on files (preview hijacked) - #1707 fixed: single-click on filename did nothing (over-aggressive guard) - #1710 (this PR): tooltip claimed dblclick-rename on folders too Closes #1710 Tests: 4 source-level regression tests in tests/test_1710_folder_tooltip.py guard the gate, the unchanged dir-dblclick navigate behaviour, the i18n key, and that files still receive the tooltip. All 13 file-tree handler tests (4 new + 9 from #1707) pass.
