mirror of
https://github.com/nesquena/hermes-webui.git
synced 2026-07-18 21:50:55 +00:00
allenliang2022
fbb21964a9
Commit 7536f6f1 routed the deferred post-render dispatches through
_postProcessWithAnchorSuppression() (holds overflow-anchor suppression across
the async media/layout settle frame, then calls postProcessRenderedMessages).
Six pre-existing tests string-matched the old
'requestAnimationFrame(()=>postProcessRenderedMessages(inner))' literal and
failed on the rename — behavior is preserved (the wrapper still invokes
postProcessRenderedMessages), so this is a test-fix not a code-fix.
Per the gate-cert recommendation, the tests now assert the BEHAVIOR chain
(post-render is scheduled via _postProcessWithAnchorSuppression, and that
wrapper calls postProcessRenderedMessages) rather than the exact rAF literal, so
a future wrapper rename can't re-orphan them.
Files: test_csv_table_rendering, test_excalidraw_inline_embed,
test_issue483_inline_diff_viewer, test_issue484_json_tree_viewer, test_issue347,
test_pdf_html_preview. Verified: the 6 updated assertions pass locally (the only
local failures are the pre-existing Windows-only WinError 206 command-line-too-long
in Node-harness tests, unrelated, green on Linux CI).
110 lines
4.8 KiB
Python
110 lines
4.8 KiB
Python
"""Tests for issue #483 — inline diff/patch viewer."""
|
|
import pytest
|
|
|
|
|
|
class TestFencedDiffRenderer:
|
|
"""Fenced ```diff blocks should render with colored line spans."""
|
|
|
|
def test_diff_block_has_diff_block_class(self):
|
|
"""diff blocks should get a 'diff-block' class on <pre>."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
assert "diff-block" in content, "Missing diff-block class"
|
|
# Should be in the fenced block renderer
|
|
assert "pre class=\"diff-block\"" in content
|
|
|
|
def test_diff_lines_get_span_classes(self):
|
|
"""Each diff line should be wrapped in a span with appropriate class."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
assert "diff-line diff-plus" in content
|
|
assert "diff-line diff-minus" in content
|
|
assert "diff-line diff-hunk" in content
|
|
|
|
def test_diff_lang_detection(self):
|
|
"""Both 'diff' and 'patch' language hints should trigger diff rendering."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
assert "lang==='diff'||lang==='patch'" in content
|
|
|
|
def test_diff_line_escape(self):
|
|
"""Diff lines must be HTML-escaped (using esc() function)."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
# In the fenced diff block renderer, lines should be escaped
|
|
# Check the pattern: esc(code...).split('\\n').map
|
|
assert "esc(code.replace" in content
|
|
|
|
|
|
class TestMediaDiffInline:
|
|
"""MEDIA: .patch/.diff files should render inline instead of download."""
|
|
|
|
def test_patch_extension_detected(self):
|
|
""".patch and .diff extensions should trigger inline rendering."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
assert "\\.(patch|diff)$" in content
|
|
|
|
def test_diff_inline_load_placeholder(self):
|
|
"""Should emit a placeholder div while loading."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
assert "diff-inline-load" in content
|
|
assert "data-path" in content
|
|
|
|
def test_loadDiffInline_function_exists(self):
|
|
"""loadDiffInline() function should be defined."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
assert "function loadDiffInline" in content
|
|
|
|
def test_loadDiffInline_called_in_post_render(self):
|
|
"""loadDiffInline() should be called by the consolidated post-render pass."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
# Behavior assertion (#5338): post-render scheduled via
|
|
# _postProcessWithAnchorSuppression, which still calls postProcessRenderedMessages.
|
|
assert "requestAnimationFrame(()=>_postProcessWithAnchorSuppression(" in content
|
|
_wrap = content.find('function _postProcessWithAnchorSuppression')
|
|
assert _wrap != -1, "post-render should be wrapped by _postProcessWithAnchorSuppression"
|
|
assert 'postProcessRenderedMessages(container)' in content[_wrap:_wrap + 500], \
|
|
"the wrapper must still invoke postProcessRenderedMessages"
|
|
start = content.find("function postProcessRenderedMessages")
|
|
body = content[start:start + 500]
|
|
assert "addCopyButtons(container)" in body
|
|
assert "loadDiffInline(container)" in body
|
|
|
|
def test_diff_inline_error_class(self):
|
|
"""Should have error state class."""
|
|
with open("static/ui.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
assert "diff-inline-error" in content
|
|
|
|
|
|
class TestDiffCSS:
|
|
"""CSS classes for diff coloring."""
|
|
|
|
def test_diff_css_classes_exist(self):
|
|
with open("static/style.css", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
for cls in (".diff-block", ".diff-line", ".diff-plus", ".diff-minus",
|
|
".diff-hunk", ".diff-inline-load", ".diff-inline", ".diff-inline-error"):
|
|
assert cls in content, f"Missing CSS class: {cls}"
|
|
|
|
def test_diff_colors_are_present(self):
|
|
"""Green for plus, red for minus should use rgba colors."""
|
|
with open("static/style.css", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
assert "rgba(34,197,94" in content or "#22c55e" in content, "Missing green color for diff-plus"
|
|
assert "rgba(239,68,68" in content or "#ef4444" in content, "Missing red color for diff-minus"
|
|
|
|
|
|
class TestDiffI18n:
|
|
"""i18n keys for diff viewer."""
|
|
|
|
def test_diff_loading_key_in_all_locales(self):
|
|
with open("static/i18n.js", "r", encoding="utf-8") as f:
|
|
content = f.read()
|
|
count = content.count("diff_loading")
|
|
assert count >= 8, f"diff_loading found {count} times, expected >= 8 (one per locale)"
|