mirror of
https://github.com/nesquena/hermes-webui.git
synced 2026-07-14 03:30:51 +00:00
nesquena-hermes
53adcfc33f
Render symlinks in the workspace file tree with a distinct chain-link
icon (vs regular file/folder icons), and show "Symlink → {target}" on
hover with long targets middle-elided. Directory and file symlinks are
both handled; regular entries keep their normal icons.
Rebased onto master (v0.51.466) and code-diff verified byte-identical to
the contributor's PR head before staging.
Co-authored-by: Rod Boev <rod.boev@gmail.com>
85 lines
3.8 KiB
Python
85 lines
3.8 KiB
Python
"""Tests for #1710 — file-tree tooltip says "Double-click to rename" on folders too,
|
|
but folders don't rename on double-click; they navigate via loadDir(). The tooltip
|
|
is therefore misleading on directory rows.
|
|
|
|
Fix: gate the tooltip on `item.type !== 'dir'` so it appears only on files.
|
|
Folder rename is still reachable via the right-click context menu.
|
|
"""
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[1]
|
|
UI_JS_PATH = REPO_ROOT / "static" / "ui.js"
|
|
|
|
|
|
def _read_ui_js() -> str:
|
|
with open(UI_JS_PATH, encoding="utf-8") as f:
|
|
return f.read()
|
|
|
|
|
|
def _name_block() -> str:
|
|
"""Source slice covering the file-tree row's name span construction."""
|
|
src = _read_ui_js()
|
|
start = src.find("// Name\n const nameEl=document.createElement('span');")
|
|
assert start >= 0, "name span construction marker not found in static/ui.js"
|
|
end = src.find("el.appendChild(nameEl);", start)
|
|
assert end >= 0, "el.appendChild(nameEl) not found after name span"
|
|
return src[start:end]
|
|
|
|
|
|
class TestFolderTooltipGated:
|
|
"""The 'Double-click to rename' tooltip must only attach to files, not dirs."""
|
|
|
|
def test_tooltip_assignment_is_guarded_by_item_type(self):
|
|
block = _name_block()
|
|
# The tooltip must NOT appear on directories. The original guard was
|
|
# ``if(item.type!=='dir')``. After the symlink PR the guard became
|
|
# ``else if(!isDirLike)`` (preceded by a symlink tooltip branch).
|
|
# Accept either form.
|
|
gated_legacy = "if(item.type!=='dir')nameEl.title=t('double_click_rename')"
|
|
gated_symlink = "if(!isDirLike)"
|
|
unguarded = " nameEl.className='file-name';nameEl.textContent=item.name;nameEl.title=t('double_click_rename');"
|
|
assert gated_legacy in block or gated_symlink in block, (
|
|
"tooltip assignment must be guarded so directories "
|
|
"do not show the misleading 'Double-click to rename' hint (#1701)"
|
|
)
|
|
assert unguarded not in block, (
|
|
"the pre-fix unguarded tooltip assignment is still present — folders will "
|
|
"still show the misleading hint"
|
|
)
|
|
|
|
def test_dir_dblclick_still_navigates_not_renames(self):
|
|
"""Sanity: directory dblclick path is unchanged — must still call loadDir().
|
|
|
|
After the symlink PR, ``item.type==='dir'`` was replaced by the
|
|
``isDirLike`` helper (covers real dirs and directory-symlinks).
|
|
"""
|
|
block = _name_block()
|
|
legacy = "if(item.type==='dir'){loadDir(item.path);return;}"
|
|
symlink_aware = "if(isDirLike){loadDir(item.path);return;}"
|
|
assert legacy in block or symlink_aware in block, (
|
|
"directory dblclick must still navigate (call loadDir); the rename-only "
|
|
"tooltip gating depends on this contract being unchanged"
|
|
)
|
|
|
|
def test_files_still_get_tooltip(self):
|
|
"""Sanity: the tooltip text is still defined for files via the i18n key."""
|
|
block = _name_block()
|
|
assert "t('double_click_rename')" in block, (
|
|
"tooltip i18n key must still be referenced — the gate hides it for dirs, "
|
|
"not for files"
|
|
)
|
|
|
|
def test_i18n_key_still_defined_in_all_locales(self):
|
|
"""The i18n key must remain defined in every locale block in static/i18n.js."""
|
|
i18n = (REPO_ROOT / "static" / "i18n.js").read_text(encoding="utf-8")
|
|
# i18n.js has 9 locale blocks with the same key. Lock that the key still exists
|
|
# at least 5 times (en, plus a quorum of locales) — exact count is i18n maintenance.
|
|
count = i18n.count("double_click_rename:")
|
|
assert count >= 5, (
|
|
f"i18n key 'double_click_rename' should be defined in multiple locales; "
|
|
f"found {count} occurrences — did this PR accidentally drop translations?"
|
|
)
|