hermes-webui/tests/test_csv_table_rendering.py

"""Test: CSV table rendering (#485)"""
import re
from pathlib import Path

WORKSPACE_JS = Path("static/workspace.js").read_text(encoding="utf-8")


def test_csv_extension_regex():
    """Verify _CSV_EXTS regex is defined."""
    with open('static/ui.js') as f:
        src = f.read()
    assert '_CSV_EXTS' in src, "Missing _CSV_EXTS regex"
    assert '.csv' in src, "CSV regex should match .csv extension"


def test_csv_fence_block_handler():
    """Verify fenced ```csv blocks are handled."""
    with open('static/ui.js') as f:
        src = f.read()
    assert "lang==='csv'" in src, "Missing csv language detection in fence handler"
    assert 'csv-table' in src, "Missing csv-table class for fenced CSV rendering"
    assert 'csv-table-wrap' in src, "Missing csv-table-wrap class"


def test_csv_fence_renders_table_structure():
    """Verify fenced CSV blocks produce proper table HTML."""
    with open('static/ui.js') as f:
        src = f.read()
    # Should have thead, tbody, th, td
    assert '<thead>' in src, "CSV table should have <thead>"
    assert '<tbody>' in src, "CSV table should have <tbody>"
    # In the fence handler section
    fence_section = src[src.find("lang==='csv'"):src.find("lang==='csv'") + 800]
    assert '<th>' in fence_section, "CSV headers should use <th>"
    assert '<td>' in fence_section, "CSV body should use <td>"


def test_csv_fence_fallback_for_insufficient_rows():
    """Verify CSV with < 2 rows falls back to code block."""
    with open('static/ui.js') as f:
        src = f.read()
    fence_section = src[src.find("lang==='csv'"):src.find("lang==='csv'") + 800]
    assert 'rows.length>=2' in fence_section, "Should check for at least 2 rows"
    assert '<pre><code' in fence_section, "Fallback should render as <pre><code>"


def test_csv_media_file_handler():
    """Verify MEDIA: CSV files trigger inline loading."""
    with open('static/ui.js') as f:
        src = f.read()
    assert 'csv-inline-load' in src, "Missing csv-inline-load class for MEDIA: CSV"
    assert 'csv_loading' in src, "Missing csv_loading i18n key usage"
    open_file = WORKSPACE_JS[WORKSPACE_JS.index("async function openFile(path, opts={}){"):WORKSPACE_JS.index("\nfunction downloadFile")]
    csv_pos = open_file.find("} else if(ext==='.csv'){")
    generic_pos = open_file.find("} else {\n    // Plain code / text -- but fall back to download if server signals binary")
    assert csv_pos != -1, "openFile() should handle .csv before the generic code branch"
    assert generic_pos != -1, "generic code branch missing from openFile()"
    assert csv_pos < generic_pos


def test_loadCsvInline_function():
    """Verify loadCsvInline lazy-load function exists."""
    with open('static/ui.js') as f:
        src = f.read()
    assert 'function loadCsvInline' in src, "Missing loadCsvInline function"
    assert 'function buildCsvTablePreview(path, text)' in src, "Missing shared CSV preview helper"


def test_csv_inline_max_size():
    """Verify CSV inline rendering has a size cap."""
    with open('static/ui.js') as f:
        src = f.read()
    assert 'const CSV_MAX_SIZE=256*1024' in src, "Should have CSV_MAX_SIZE constant"
    helper_section = src[src.find('function buildCsvTablePreview'):src.find('function buildCsvTablePreview') + 2000]
    assert 'csv_too_large' in helper_section, "Should use csv_too_large i18n for oversized files"


def test_csv_auto_detect_separator():
    """Verify CSV handler auto-detects separator."""
    with open('static/ui.js') as f:
        src = f.read()
    csv_section = src[src.find('function buildCsvTablePreview'):src.find('function buildCsvTablePreview') + 2000]
    assert 'separators' in csv_section, "Should have separator detection"
    assert ';' in csv_section, "Should detect semicolon separator"
    assert 'tab' in csv_section.lower() or '\\t' in csv_section, "Should detect tab separator"


def test_csv_quote_stripping():
    """Verify CSV handler strips surrounding quotes from fields."""
    with open('static/ui.js') as f:
        src = f.read()
    assert "replace(/^[\"']|[\"']$/g,'')" in src, "Should strip quotes from CSV fields"


def test_csv_error_handling():
    """Verify CSV error and empty data handling."""
    with open('static/ui.js') as f:
        src = f.read()
    csv_section = src[src.find('function buildCsvTablePreview'):src.find('function loadCsvInline') + 1000]
    assert 'csv_error' in csv_section, "Should use csv_error i18n on fetch failure"
    assert 'csv_no_data' in csv_section, "Should use csv_no_data i18n for insufficient data"
    helper_start = WORKSPACE_JS.index("function renderCsvPreviewContent(path, content){")
    helper_end = WORKSPACE_JS.index("\nfunction forceRenderMarkdownPreview", helper_start)
    helper_body = WORKSPACE_JS[helper_start:helper_end]
    assert "if(preview.errorKey&&typeof _csvPreviewErrorHtml==='function'){" in helper_body
    assert "$('previewMd').innerHTML=_csvPreviewErrorHtml(path, preview.errorKey);" in helper_body


def test_csv_loadCsvInline_called_after_render():
    """Verify loadCsvInline is called by the consolidated post-render pass."""
    with open('static/ui.js') as f:
        src = f.read()
    assert 'requestAnimationFrame(()=>postProcessRenderedMessages(inner))' in src
    idx = src.find('function postProcessRenderedMessages')
    body = src[idx:idx + 500]
    assert 'loadCsvInline(container)' in body, "post-process should call loadCsvInline once per render"
    load_section = src[src.find('function loadCsvInline'):src.find('function loadCsvInline') + 1200]
    assert 'buildCsvTablePreview(path, text)' in load_section, "Inline loader should reuse the shared helper"
    open_file = WORKSPACE_JS[WORKSPACE_JS.index("async function openFile(path, opts={}){"):WORKSPACE_JS.index("\nfunction downloadFile")]
    csv_pos = open_file.find("} else if(ext==='.csv'){")
    generic_pos = open_file.find("} else {\n    // Plain code / text -- but fall back to download if server signals binary")
    branch = open_file[csv_pos:generic_pos]
    assert "if(renderCsvPreviewContent(path, data.content)) return;" in branch
    assert "renderCodePreviewContent(path, data.content);" in branch
    assert "showPreview('csv');" in WORKSPACE_JS
    assert "$('previewMd').innerHTML=preview.html;" in WORKSPACE_JS
    assert "(mode==='md'||mode==='csv')" in WORKSPACE_JS
    assert "mode==='csv'?'csv'" in WORKSPACE_JS
    # csv files keep the workspace Edit affordance (regression #4025: previously
    # csv fell through to the code preview which exposed the Edit button).
    assert "_previewCurrentMode==='md'||_previewCurrentMode==='csv'" in WORKSPACE_JS


def test_csv_line_ending_normalization():
    """Verify CSV handler normalizes line endings."""
    with open('static/ui.js') as f:
        src = f.read()
    csv_section = src[src.find('function buildCsvTablePreview'):src.find('function buildCsvTablePreview') + 2000]
    assert '\\r\\n' in csv_section, "Should handle \\r\\n line endings"
    assert '\\r' in csv_section, "Should handle \\r line endings"


def test_csv_i18n_keys():
    """Verify CSV i18n keys exist in all 7 locales."""
    with open('static/i18n.js') as f:
        src = f.read()
    required_keys = ['csv_loading', 'csv_too_large', 'csv_no_data', 'csv_error']
    for key in required_keys:
        count = src.count(f"{key}:")
        assert count >= 8, f"Key '{key}' found {count} times, expected >= 8 (one per locale)"


def test_csv_css_classes():
    """Verify CSV table CSS classes are defined."""
    with open('static/style.css') as f:
        src = f.read()
    required_classes = ['csv-table-wrap', 'csv-table', 'csv-table th', 'csv-table td']
    for cls in required_classes:
        assert cls in src, f"Missing CSS: {cls}"
    # Check for hover effect
    assert 'csv-table tbody tr:hover' in src, "Missing hover effect for CSV rows"


def test_csv_not_matched_by_image_exts():
    """Verify .csv is NOT in _IMAGE_EXTS."""
    with open('static/ui.js') as f:
        src = f.read()
    match = re.search(r"const _IMAGE_EXTS=/([^/]+)/i", src)
    assert match
    exts = match.group(1)
    assert 'csv' not in exts.lower(), ".csv should NOT be in _IMAGE_EXTS"


def test_csv_preview_preserves_edit_flow():
    """Regression (#4025 review): the CSV table preview must not strip the
    workspace Edit affordance that .csv had when it fell through to the code
    preview. csv mode must be editable, the preview must cache raw content for
    the textarea, and a save must re-render the table (not markdown)."""
    with open('static/workspace.js') as f:
        src = f.read()
    # csv mode is editable
    assert "_previewCurrentMode==='csv'" in src, "csv mode should be editable / handled in workspace edit flow"
    edit_btn = src[src.find('function updateEditBtn'):src.find('function updateEditBtn') + 400]
    assert "==='csv'" in edit_btn, "updateEditBtn must allow editing csv mode"
    # renderCsvPreviewContent caches the raw text for the edit textarea
    csv_render = src[src.find('function renderCsvPreviewContent'):src.find('function renderCsvPreviewContent') + 700]
    assert '_previewRawContent = content' in csv_render or '_previewRawContent=content' in csv_render, \
        "renderCsvPreviewContent must cache raw CSV content for the edit flow"
    # save path re-renders the CSV table for csv mode
    save_section = src[src.find('async function toggleEditMode'):src.find('async function toggleEditMode') + 1200]
    assert "renderCsvPreviewContent(_previewCurrentPath, content)" in save_section, \
        "saving an edited CSV must re-render the table, not markdown"