@@ -729,18 +800,20 @@ async function saveCronForm(){
const schEl=$('cronFormSchedule');
const promptEl=$('cronFormPrompt');
const delivEl=$('cronFormDeliver');
+ const profileEl=$('cronFormProfile');
const errEl=$('cronFormError');
if(!schEl||!promptEl||!errEl) return;
const name=(nameEl?nameEl.value:'').trim();
const schedule=schEl.value.trim();
const prompt=promptEl.value.trim();
const deliver=delivEl?delivEl.value:'local';
+ const profile=profileEl?profileEl.value:'';
errEl.style.display='none';
if(!schedule){errEl.textContent=t('cron_schedule_required_example');errEl.style.display='';return;}
if(!prompt){errEl.textContent=t('cron_prompt_required');errEl.style.display='';return;}
try{
if (_editingCronId) {
- const updates = {job_id: _editingCronId, schedule, prompt};
+ const updates = {job_id: _editingCronId, schedule, prompt, profile: profile};
if (name) updates.name = name;
await api('/api/crons/update', {method:'POST', body: JSON.stringify(updates)});
const editedId = _editingCronId;
@@ -752,7 +825,7 @@ async function saveCronForm(){
if (job) openCronDetail(editedId);
return;
}
- const body={schedule,prompt,deliver};
+ const body={schedule,prompt,deliver,profile: profile};
if(_cronIsDuplicate) body.enabled=false;
if(name)body.name=name;
if(_cronSelectedSkills.length)body.skills=_cronSelectedSkills;
diff --git a/static/style.css b/static/style.css
index 7d6be764..32a7a5b0 100644
--- a/static/style.css
+++ b/static/style.css
@@ -645,6 +645,7 @@
.cron-header{display:flex;align-items:center;gap:8px;padding:10px 12px;cursor:pointer;}
.cron-name{flex:1;font-size:13px;color:var(--text);font-weight:500;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;}
.cron-status{font-size:10px;font-weight:700;padding:2px 8px;border-radius:99px;flex-shrink:0;}
+ .cron-profile-badge{font-size:10px;font-weight:650;padding:2px 7px;border-radius:99px;flex-shrink:0;max-width:92px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;border:1px solid var(--border);color:var(--muted);background:var(--surface-subtle);}
.cron-status.active{background:rgba(34,197,94,.15);color:var(--success);}
.cron-status.paused{background:var(--accent-bg-strong);color:var(--accent-text);}
.cron-status.disabled{background:rgba(255,255,255,.07);color:var(--muted);}
diff --git a/tests/test_issue617_cron_profile_selector.py b/tests/test_issue617_cron_profile_selector.py
new file mode 100644
index 00000000..4d6e9643
--- /dev/null
+++ b/tests/test_issue617_cron_profile_selector.py
@@ -0,0 +1,224 @@
+"""Regression coverage for issue #617 scheduled-job profile selection."""
+
+import io
+import json
+import sys
+import types
+from pathlib import Path
+
+import pytest
+
+REPO = Path(__file__).resolve().parent.parent
+
+
+class _JSONHandler:
+ def __init__(self):
+ self.status = None
+ self.headers = {}
+ self.response_headers = []
+ self.wfile = io.BytesIO()
+
+ def send_response(self, status):
+ self.status = status
+
+ def send_header(self, key, value):
+ self.response_headers.append((key, value))
+
+ def end_headers(self):
+ pass
+
+
+def _payload(handler):
+ return json.loads(handler.wfile.getvalue().decode("utf-8"))
+
+
+def test_cron_api_serializes_legacy_profile_as_explicit_server_default():
+ from api.routes import _cron_job_for_api
+
+ legacy = {"id": "legacy", "name": "Legacy job"}
+ payload = _cron_job_for_api(legacy)
+
+ assert payload["profile"] is None
+ assert "profile" not in legacy, "API serialization must not mutate stored legacy jobs"
+
+
+def test_cron_profile_value_validates_against_existing_profiles(monkeypatch):
+ import api.profiles as profiles
+ from api.routes import _normalize_cron_profile_value
+
+ monkeypatch.setattr(
+ profiles,
+ "list_profiles_api",
+ lambda: [
+ {"name": "default"},
+ {"name": "research"},
+ ],
+ )
+
+ assert _normalize_cron_profile_value(" research ") == "research"
+ assert _normalize_cron_profile_value("") is None
+ assert _normalize_cron_profile_value(None) is None
+ with pytest.raises(ValueError, match="Unknown profile: missing"):
+ _normalize_cron_profile_value("missing")
+
+
+def test_cron_create_api_persists_profile_and_returns_it(monkeypatch):
+ import api.profiles as profiles
+ import api.routes as routes
+
+ created = {
+ "id": "job617",
+ "name": "Profiled job",
+ "prompt": "ping",
+ "schedule": {"kind": "interval", "minutes": 60},
+ }
+ updated = {**created, "profile": "research"}
+ calls = []
+
+ cron_pkg = types.ModuleType("cron")
+ cron_pkg.__path__ = []
+ cron_jobs = types.ModuleType("cron.jobs")
+ cron_jobs.create_job = lambda **kwargs: calls.append(("create", kwargs)) or dict(created)
+ cron_jobs.update_job = lambda job_id, updates: calls.append(("update", job_id, updates)) or dict(updated)
+
+ monkeypatch.setattr(profiles, "list_profiles_api", lambda: [{"name": "research"}])
+ monkeypatch.setitem(sys.modules, "cron", cron_pkg)
+ monkeypatch.setitem(sys.modules, "cron.jobs", cron_jobs)
+
+ handler = _JSONHandler()
+ routes._handle_cron_create(
+ handler,
+ {
+ "name": "Profiled job",
+ "prompt": "ping",
+ "schedule": "every 60m",
+ "deliver": "local",
+ "profile": "research",
+ },
+ )
+
+ body = _payload(handler)
+ assert handler.status == 200
+ assert body["ok"] is True
+ assert body["job"]["profile"] == "research"
+ assert calls[0][0] == "create"
+ assert calls[1] == ("update", "job617", {"profile": "research"})
+
+
+def test_cron_create_api_rejects_unknown_profile_before_persisting(monkeypatch):
+ import api.profiles as profiles
+ import api.routes as routes
+
+ cron_pkg = types.ModuleType("cron")
+ cron_pkg.__path__ = []
+ cron_jobs = types.ModuleType("cron.jobs")
+ cron_jobs.create_job = lambda **kwargs: pytest.fail("invalid profiles must not create jobs")
+ cron_jobs.update_job = lambda *args, **kwargs: pytest.fail("invalid profiles must not update jobs")
+
+ monkeypatch.setattr(profiles, "list_profiles_api", lambda: [{"name": "research"}])
+ monkeypatch.setitem(sys.modules, "cron", cron_pkg)
+ monkeypatch.setitem(sys.modules, "cron.jobs", cron_jobs)
+
+ handler = _JSONHandler()
+ routes._handle_cron_create(
+ handler,
+ {"prompt": "ping", "schedule": "every 60m", "profile": "missing"},
+ )
+
+ assert handler.status == 400
+ assert "Unknown profile: missing" in _payload(handler)["error"]
+
+
+def test_cron_update_api_accepts_profile_clear_and_rejects_unknown(monkeypatch):
+ import api.profiles as profiles
+ import api.routes as routes
+
+ calls = []
+ cron_pkg = types.ModuleType("cron")
+ cron_pkg.__path__ = []
+ cron_jobs = types.ModuleType("cron.jobs")
+
+ def update_job(job_id, updates):
+ calls.append((job_id, updates))
+ return {"id": job_id, "name": "Updated", **updates}
+
+ cron_jobs.update_job = update_job
+ monkeypatch.setattr(profiles, "list_profiles_api", lambda: [{"name": "research"}])
+ monkeypatch.setitem(sys.modules, "cron", cron_pkg)
+ monkeypatch.setitem(sys.modules, "cron.jobs", cron_jobs)
+
+ handler = _JSONHandler()
+ routes._handle_cron_update(handler, {"job_id": "job617", "profile": ""})
+ assert handler.status == 200
+ assert _payload(handler)["job"]["profile"] is None
+ assert calls == [("job617", {"profile": None})]
+
+ bad_handler = _JSONHandler()
+ routes._handle_cron_update(bad_handler, {"job_id": "job617", "profile": "ghost"})
+ assert bad_handler.status == 400
+ assert "Unknown profile: ghost" in _payload(bad_handler)["error"]
+ assert calls == [("job617", {"profile": None})]
+
+
+def test_manual_cron_run_uses_execution_profile_but_persists_to_owning_store(monkeypatch):
+ import api.profiles as profiles
+ import api.routes as routes
+
+ events = []
+
+ class Ctx:
+ def __init__(self, home):
+ self.home = str(home)
+
+ def __enter__(self):
+ events.append(("enter", self.home))
+
+ def __exit__(self, exc_type, exc, tb):
+ events.append(("exit", self.home))
+
+ cron_pkg = types.ModuleType("cron")
+ cron_pkg.__path__ = []
+ cron_jobs = types.ModuleType("cron.jobs")
+ cron_jobs.save_job_output = lambda job_id, output: events.append(("save", job_id, output))
+ cron_jobs.mark_job_run = lambda job_id, success, error=None: events.append(("mark", job_id, success, error))
+ cron_scheduler = types.ModuleType("cron.scheduler")
+ cron_scheduler.run_job = lambda job: events.append(("run", job["id"])) or (True, "output", "final", None)
+
+ monkeypatch.setattr(profiles, "cron_profile_context_for_home", Ctx)
+ monkeypatch.setitem(sys.modules, "cron", cron_pkg)
+ monkeypatch.setitem(sys.modules, "cron.jobs", cron_jobs)
+ monkeypatch.setitem(sys.modules, "cron.scheduler", cron_scheduler)
+
+ routes._mark_cron_running("job617")
+ routes._run_cron_tracked(
+ {"id": "job617"},
+ profile_home="/hermes/default",
+ execution_profile_home="/hermes/profiles/research",
+ )
+
+ assert events == [
+ ("enter", "/hermes/profiles/research"),
+ ("run", "job617"),
+ ("exit", "/hermes/profiles/research"),
+ ("enter", "/hermes/default"),
+ ("save", "job617", "output"),
+ ("mark", "job617", True, None),
+ ("exit", "/hermes/default"),
+ ]
+ assert routes._is_cron_running("job617") == (False, 0.0)
+
+
+def test_cron_profile_selector_source_hooks_present():
+ panels = (REPO / "static" / "panels.js").read_text(encoding="utf-8")
+ css = (REPO / "static" / "style.css").read_text(encoding="utf-8")
+ i18n = (REPO / "static" / "i18n.js").read_text(encoding="utf-8")
+
+ assert "async function loadCronProfiles()" in panels
+ assert "api('/api/profiles')" in panels
+ assert "id=\"cronFormProfile\"" in panels
+ assert "profile: profile" in panels
+ assert "job.profile" in panels
+ assert "cron-profile-badge" in panels
+ assert ".cron-profile-badge" in css
+ assert "cron_profile_server_default" in i18n
+ assert "cron_profile_server_default_hint" in i18n
diff --git a/tests/test_scheduled_jobs_profile_isolation.py b/tests/test_scheduled_jobs_profile_isolation.py
index ec765c81..0d05cc4d 100644
--- a/tests/test_scheduled_jobs_profile_isolation.py
+++ b/tests/test_scheduled_jobs_profile_isolation.py
@@ -215,7 +215,7 @@ def test_cron_worker_does_not_silently_fall_back_on_profile_context_failure():
from pathlib import Path
src = (Path(__file__).resolve().parent.parent / "api" / "routes.py").read_text(encoding="utf-8")
- idx = src.find("def _run_cron_tracked(job, profile_home=None):")
+ idx = src.find("def _run_cron_tracked(job")
assert idx != -1, "_run_cron_tracked not found"
body = src[idx : idx + 2000]