From 6879390b8f6514088bdaabb17e1832fc43234698 Mon Sep 17 00:00:00 2001
From: Frank Song <franksong2702@gmail.com>
Date: Fri, 8 May 2026 15:19:04 +0000
Subject: [PATCH] Fix Kanban lifecycle controls
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Remove Kanban card Start and bulk Running controls (PATCH to running was unsafe)
- Rename "Nudge dispatcher" → "Preview dispatcher" (matches dry-run semantics)
- Add empty-board guidance kanban_work_queue_hint

Rebased onto master post-v0.51.23 by maintainer; preserves Japanese translations
from #1863 (kanban_nudge_dispatcher: ディスパッチャープレビュー).

Closes #1885

Co-authored-by: Frank Song <franksong2702@gmail.com>
---
 static/i18n.js                 | 24 ++++++++++++++++--------
 static/index.html              |  8 ++++----
 static/panels.js               | 16 ++++++++++++----
 tests/test_kanban_ui_static.py | 13 ++++++++++++-
 4 files changed, 44 insertions(+), 17 deletions(-)

diff --git a/static/i18n.js b/static/i18n.js
index 6101c1f6..e799924d 100644
--- a/static/i18n.js
+++ b/static/i18n.js
@@ -489,6 +489,7 @@ const LOCALES = {
     kanban_include_archived: 'Include archived',
     kanban_no_matching_tasks: 'No matching tasks',
     kanban_no_data: 'No Kanban data',
+    kanban_work_queue_hint: 'This is the Hermes Agent work queue. Create or triage a task, assign it, move it to Ready, then let the dispatcher claim it.',
     kanban_unavailable: 'Kanban unavailable',
     kanban_read_only: 'Read-only view',
     kanban_empty: 'Empty',
@@ -514,7 +515,7 @@ const LOCALES = {
     kanban_add_comment: 'Add comment',
       kanban_only_mine: 'Only mine',
       kanban_bulk_action: 'Bulk action',
-      kanban_nudge_dispatcher: 'Nudge dispatcher',
+      kanban_nudge_dispatcher: 'Preview dispatcher',
       kanban_stats: 'Stats',
       kanban_worker_log: 'Worker log',
       kanban_block: 'Block',
@@ -1507,6 +1508,7 @@ const LOCALES = {
     kanban_include_archived: 'アーカイブを含める',
     kanban_no_matching_tasks: '一致するタスクがありません',
     kanban_no_data: 'カンバンデータがありません',
+    kanban_work_queue_hint: 'これは Hermes Agent のワークキューです。タスクを作成またはトリアージし、担当者を割り当て、Ready に移動すると、ディスパッチャーがそれをクレームします。',
     kanban_unavailable: 'カンバンを利用できません',
     kanban_read_only: '読み取り専用',
     kanban_empty: '空',
@@ -1532,7 +1534,7 @@ const LOCALES = {
     kanban_add_comment: 'コメント追加',
       kanban_only_mine: '自分のみ',
       kanban_bulk_action: '一括操作',
-      kanban_nudge_dispatcher: 'ディスパッチャーに催促',
+      kanban_nudge_dispatcher: 'ディスパッチャープレビュー',
       kanban_stats: '統計',
       kanban_worker_log: 'ワーカーログ',
       kanban_block: 'ブロック',
@@ -2364,6 +2366,7 @@ const LOCALES = {
     kanban_include_archived: 'Include archived',
     kanban_no_matching_tasks: 'No matching tasks',
     kanban_no_data: 'No Kanban data',
+    kanban_work_queue_hint: 'This is the Hermes Agent work queue. Create or triage a task, assign it, move it to Ready, then let the dispatcher claim it.',
     kanban_unavailable: 'Kanban unavailable',
     kanban_read_only: 'Read-only view',
     kanban_empty: 'Empty',
@@ -2389,7 +2392,7 @@ const LOCALES = {
     kanban_add_comment: 'Add comment',
       kanban_only_mine: 'Only mine',
       kanban_bulk_action: 'Bulk action',
-      kanban_nudge_dispatcher: 'Nudge dispatcher',
+      kanban_nudge_dispatcher: 'Preview dispatcher',
       kanban_stats: 'Stats',
       kanban_worker_log: 'Worker log',
       kanban_block: 'Block',
@@ -3316,6 +3319,7 @@ const LOCALES = {
     kanban_include_archived: 'Include archived',
     kanban_no_matching_tasks: 'No matching tasks',
     kanban_no_data: 'No Kanban data',
+    kanban_work_queue_hint: 'This is the Hermes Agent work queue. Create or triage a task, assign it, move it to Ready, then let the dispatcher claim it.',
     kanban_unavailable: 'Kanban unavailable',
     kanban_read_only: 'Read-only view',
     kanban_empty: 'Empty',
@@ -3341,7 +3345,7 @@ const LOCALES = {
     kanban_add_comment: 'Add comment',
       kanban_only_mine: 'Only mine',
       kanban_bulk_action: 'Bulk action',
-      kanban_nudge_dispatcher: 'Nudge dispatcher',
+      kanban_nudge_dispatcher: 'Preview dispatcher',
       kanban_stats: 'Stats',
       kanban_worker_log: 'Worker log',
       kanban_block: 'Block',
@@ -4256,6 +4260,7 @@ const LOCALES = {
     kanban_include_archived: 'Include archived',
     kanban_no_matching_tasks: 'No matching tasks',
     kanban_no_data: 'No Kanban data',
+    kanban_work_queue_hint: 'This is the Hermes Agent work queue. Create or triage a task, assign it, move it to Ready, then let the dispatcher claim it.',
     kanban_unavailable: 'Kanban unavailable',
     kanban_read_only: 'Read-only view',
     kanban_empty: 'Empty',
@@ -4281,7 +4286,7 @@ const LOCALES = {
     kanban_add_comment: 'Add comment',
       kanban_only_mine: 'Only mine',
       kanban_bulk_action: 'Bulk action',
-      kanban_nudge_dispatcher: 'Nudge dispatcher',
+      kanban_nudge_dispatcher: 'Preview dispatcher',
       kanban_stats: 'Stats',
       kanban_worker_log: 'Worker log',
       kanban_block: 'Block',
@@ -5217,6 +5222,7 @@ const LOCALES = {
     kanban_include_archived: 'Include archived',
     kanban_no_matching_tasks: 'No matching tasks',
     kanban_no_data: 'No Kanban data',
+    kanban_work_queue_hint: 'This is the Hermes Agent work queue. Create or triage a task, assign it, move it to Ready, then let the dispatcher claim it.',
     kanban_unavailable: 'Kanban unavailable',
     kanban_read_only: 'Read-only view',
     kanban_empty: 'Empty',
@@ -5242,7 +5248,7 @@ const LOCALES = {
     kanban_add_comment: 'Add comment',
       kanban_only_mine: 'Only mine',
       kanban_bulk_action: 'Bulk action',
-      kanban_nudge_dispatcher: 'Nudge dispatcher',
+      kanban_nudge_dispatcher: 'Preview dispatcher',
       kanban_stats: 'Stats',
       kanban_worker_log: 'Worker log',
       kanban_block: 'Block',
@@ -7207,6 +7213,7 @@ const LOCALES = {
     kanban_include_archived: 'Include archived',
     kanban_no_matching_tasks: 'No matching tasks',
     kanban_no_data: 'No Kanban data',
+    kanban_work_queue_hint: 'This is the Hermes Agent work queue. Create or triage a task, assign it, move it to Ready, then let the dispatcher claim it.',
     kanban_unavailable: 'Kanban unavailable',
     kanban_read_only: 'Read-only view',
     kanban_empty: 'Empty',
@@ -7232,7 +7239,7 @@ const LOCALES = {
     kanban_add_comment: 'Add comment',
       kanban_only_mine: 'Only mine',
       kanban_bulk_action: 'Bulk action',
-      kanban_nudge_dispatcher: 'Nudge dispatcher',
+      kanban_nudge_dispatcher: 'Preview dispatcher',
       kanban_stats: 'Stats',
       kanban_worker_log: 'Worker log',
       kanban_block: 'Block',
@@ -8123,6 +8130,7 @@ const LOCALES = {
     kanban_include_archived: 'Include archived',
     kanban_no_matching_tasks: 'No matching tasks',
     kanban_no_data: 'No Kanban data',
+    kanban_work_queue_hint: 'This is the Hermes Agent work queue. Create or triage a task, assign it, move it to Ready, then let the dispatcher claim it.',
     kanban_unavailable: 'Kanban unavailable',
     kanban_read_only: 'Read-only view',
     kanban_empty: 'Empty',
@@ -8148,7 +8156,7 @@ const LOCALES = {
     kanban_add_comment: 'Add comment',
       kanban_only_mine: 'Only mine',
       kanban_bulk_action: 'Bulk action',
-      kanban_nudge_dispatcher: 'Nudge dispatcher',
+      kanban_nudge_dispatcher: 'Preview dispatcher',
       kanban_stats: 'Stats',
       kanban_worker_log: 'Worker log',
       kanban_block: 'Block',
diff --git a/static/index.html b/static/index.html
index c1f8670f..d730af2f 100644
--- a/static/index.html
+++ b/static/index.html
@@ -158,9 +158,9 @@
         <label class="kanban-check"><input id="kanbanOnlyMine" type="checkbox" onchange="loadKanban(true)"> <span data-i18n="kanban_only_mine">Only mine</span></label>
         <div id="kanbanStats" class="kanban-stats" aria-live="polite"></div>
         <div id="kanbanBulkBar" class="kanban-bulk-bar">
-          <select id="kanbanBulkStatus" aria-label="Bulk status"><option value="">Status</option><option value="ready">Ready</option><option value="running">Running</option><option value="blocked">Blocked</option><option value="done">Done</option><option value="archived">Archived</option></select>
+          <select id="kanbanBulkStatus" aria-label="Bulk status"><option value="">Status</option><option value="ready">Ready</option><option value="blocked">Blocked</option><option value="done">Done</option><option value="archived">Archived</option></select>
           <button class="btn secondary" onclick="bulkUpdateKanban()" data-i18n="kanban_bulk_action">Bulk action</button>
-          <button class="btn secondary" onclick="nudgeKanbanDispatcher()" data-i18n="kanban_nudge_dispatcher">Nudge dispatcher</button>
+          <button class="btn secondary" onclick="nudgeKanbanDispatcher()" data-i18n="kanban_nudge_dispatcher">Preview dispatcher</button>
         </div>
         <div class="kanban-new-task-row">
           <input id="kanbanNewTaskTitle" placeholder="New task" data-i18n-placeholder="kanban_new_task" onkeydown="if(event.key==='Enter')createKanbanTask()">
@@ -709,7 +709,7 @@
         </div>
         <div class="main-view-actions">
           <button class="panel-head-btn has-tooltip has-tooltip--bottom" id="btnKanbanCreateBoard" onclick="openKanbanCreateBoard()" data-tooltip="New board" data-i18n-title="kanban_new_board" aria-label="New board"><svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true"><rect x="3" y="3" width="7" height="7"/><rect x="14" y="3" width="7" height="7"/><rect x="3" y="14" width="7" height="7"/><line x1="17.5" y1="14" x2="17.5" y2="21"/><line x1="14" y1="17.5" x2="21" y2="17.5"/></svg></button>
-          <button class="panel-head-btn has-tooltip has-tooltip--bottom" onclick="nudgeKanbanDispatcher()" data-tooltip="Nudge dispatcher" data-i18n-title="kanban_nudge_dispatcher" aria-label="Nudge dispatcher">▶</button>
+          <button class="panel-head-btn has-tooltip has-tooltip--bottom" onclick="nudgeKanbanDispatcher()" data-tooltip="Preview dispatcher" data-i18n-title="kanban_nudge_dispatcher" aria-label="Preview dispatcher">▶</button>
         </div>
       </div>
       <div class="kanban-task-preview" id="kanbanTaskPreview" style="display:none"></div>
@@ -1118,7 +1118,7 @@
   <aside class="rightpanel">
     <div class="resize-handle" id="rightpanelResize"></div>
     <div class="panel-header">
-      <span id="workspacePanelHeading" class="workspace-panel-heading" title="Workspace">Workspace</span><span id="workspaceHiddenIndicator" class="workspace-hidden-indicator" data-i18n-title="workspace_hidden_files_visible_title" title="Hidden files are visible — click for options" hidden onclick="toggleWorkspacePrefsMenu(event)"><svg width="11" height="11" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.4" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true"><path d="M1 12s4-8 11-8 11 8 11 8-4 8-11 8-11-8-11-8z"/><circle cx="12" cy="12" r="3"/></svg><span data-i18n="workspace_hidden_files_visible">hidden visible</span></span>
+      <span id="workspacePanelHeading" class="workspace-panel-heading" role="button" tabindex="0" title="Workspace root">Workspace</span><span id="workspaceHiddenIndicator" class="workspace-hidden-indicator" data-i18n-title="workspace_hidden_files_visible_title" title="Hidden files are visible — click for options" hidden onclick="toggleWorkspacePrefsMenu(event)"><svg width="11" height="11" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.4" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true"><path d="M1 12s4-8 11-8 11 8 11 8-4 8-11 8-11-8-11-8z"/><circle cx="12" cy="12" r="3"/></svg><span data-i18n="workspace_hidden_files_visible">hidden visible</span></span>
       <span class="git-badge" id="gitBadge" style="display:none"></span>
       <div class="panel-actions">
         <button class="panel-icon-btn has-tooltip has-tooltip--bottom" id="btnCollapseWorkspacePanel" data-tooltip="Hide workspace panel" onclick="toggleWorkspacePanel(false)"><svg width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true"><polyline points="15 18 9 12 15 6"/></svg></button>
diff --git a/static/panels.js b/static/panels.js
index a8a53640..151d9a7a 100644
--- a/static/panels.js
+++ b/static/panels.js
@@ -834,7 +834,7 @@ async function saveCronForm(){
   const prompt=promptEl.value.trim();
   const deliver=delivEl?delivEl.value:'local';
   const profile=profileEl?profileEl.value:'';
-  const isNoAgent = !!(_cronPreFormDetail && _cronPreFormDetail.no_agent);
+  const isNoAgent = !!(_currentCronDetail && _currentCronDetail.no_agent);
   errEl.style.display='none';
   if(!schedule){errEl.textContent=t('cron_schedule_required_example');errEl.style.display='';return;}
   if(!isNoAgent && !prompt){errEl.textContent=t('cron_prompt_required');errEl.style.display='';return;}
@@ -1096,10 +1096,9 @@ function _kanbanCardStalenessClass(task){
 function _kanbanCardQuickActions(task){
   const id = esc(task.id || '');
   const status = task.status || '';
-  const start = status !== 'running' && status !== 'done' && status !== 'archived' ? `<button type="button" class="kanban-card-action" onclick="quickKanbanCardAction(event,'${id}','running')">${esc(t('kanban_card_start'))}</button>` : '';
   const complete = status !== 'done' && status !== 'archived' ? `<button type="button" class="kanban-card-action" onclick="quickKanbanCardAction(event,'${id}','done')">${esc(t('kanban_card_complete'))}</button>` : '';
   const archive = status !== 'archived' ? `<button type="button" class="kanban-card-action danger" onclick="quickKanbanCardAction(event,'${id}','archived')">${esc(t('kanban_card_archive'))}</button>` : '';
-  return `<div class="kanban-card-actions" onclick="event.stopPropagation()">${start}${complete}${archive}</div>`;
+  return `<div class="kanban-card-actions" onclick="event.stopPropagation()">${complete}${archive}</div>`;
 }
 
 async function quickKanbanCardAction(event, taskId, status){
@@ -1168,17 +1167,25 @@ function _kanbanRenderProfileLanes(columns){
   }).join('')}</div>`;
 }
 
+function _kanbanEmptyBoardHtml(){
+  return `<div class="main-view-empty"><div class="main-view-empty-title">${esc(t('kanban_no_data'))}</div><div class="main-view-empty-sub">${esc(t('kanban_work_queue_hint'))}</div></div>`;
+}
+
 function _kanbanRenderBoard(){
   const board = $('kanbanBoard');
   if (!board) return;
   if (!_kanbanBoard || !_kanbanBoard.columns) {
-    board.innerHTML = `<div class="main-view-empty"><div class="main-view-empty-title">${esc(t('kanban_no_data'))}</div></div>`;
+    board.innerHTML = _kanbanEmptyBoardHtml();
     return;
   }
   const columns = _kanbanVisibleTasks();
   const total = columns.reduce((n, col) => n + (col.tasks || []).length, 0);
   if ($('kanbanSummary')) $('kanbanSummary').textContent = String(t('kanban_visible_tasks')).replace('{0}', total);
   _kanbanRenderSidebar(columns);
+  if (total === 0) {
+    board.innerHTML = _kanbanEmptyBoardHtml();
+    return;
+  }
   board.innerHTML = _kanbanLanesByProfile ? _kanbanRenderProfileLanes(columns) : columns.map(_kanbanRenderColumn).join('');
 }
 
@@ -1219,6 +1226,7 @@ async function hardRefreshWebUIClient(){
 function _kanbanLooksLikeStaleClientError(err){
   const msg = String((err && err.message) || err || '').toLowerCase();
   return !!(err && err.status === 404 && (
+    msg === 'not found' ||
     msg.includes('unknown kanban endpoint') ||
     msg.includes('stale cached bundle')
   ));
diff --git a/tests/test_kanban_ui_static.py b/tests/test_kanban_ui_static.py
index 3ff1ca15..b9ed8372 100644
--- a/tests/test_kanban_ui_static.py
+++ b/tests/test_kanban_ui_static.py
@@ -164,6 +164,7 @@ def test_kanban_dashboard_parity_i18n_keys_exist():
         "kanban_only_mine",
         "kanban_bulk_action",
         "kanban_nudge_dispatcher",
+        "kanban_work_queue_hint",
         "kanban_stats",
         "kanban_worker_log",
         "kanban_block",
@@ -205,6 +206,16 @@ def test_kanban_ui_parity_polish_adds_card_metadata_quick_actions_and_swimlanes(
     assert "javascript:" not in PANELS.lower()
 
 
+def test_kanban_lifecycle_controls_do_not_offer_manual_running_start():
+    assert "quickKanbanCardAction(event,'${id}','running')" not in PANELS
+    assert "kanban_card_start" not in PANELS
+    assert '<option value="running">Running</option>' not in INDEX
+    assert "Cannot set status to 'running' directly" not in PANELS
+    assert "kanban_work_queue_hint" in PANELS
+    assert "Preview dispatcher" in INDEX
+    assert "Nudge dispatcher" not in INDEX
+
+
 def test_kanban_ui_parity_polish_css_and_i18n_exist():
     for selector in (
         ".kanban-profile-lanes",
@@ -219,7 +230,7 @@ def test_kanban_ui_parity_polish_css_and_i18n_exist():
     ):
         assert selector in STYLE
     locale_blocks = re.findall(r"\n\s*([a-z]{2}(?:-[A-Z]{2})?): \{(.*?)\n\s*\},", I18N, flags=re.S)
-    required_keys = ["kanban_lanes_by_profile", "kanban_card_start", "kanban_card_complete", "kanban_card_archive", "kanban_unassigned"]
+    required_keys = ["kanban_lanes_by_profile", "kanban_card_complete", "kanban_card_archive", "kanban_unassigned", "kanban_work_queue_hint"]
     missing = [
         f"{locale}:{key}"
         for locale, body in locale_blocks