From 552a13fa9ed3ebbc95b4885260716bbf08fb281a Mon Sep 17 00:00:00 2001 From: Rod Boev Date: Sun, 28 Jun 2026 19:24:44 -0400 Subject: [PATCH] Avoid duplicate busy-placeholder refresh --- static/ui.js | 1 - tests/test_1003_preferences_autosave.py | 2 +- tests/test_5144_busy_composer_placeholder_hint.py | 3 ++- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/static/ui.js b/static/ui.js index 37bd4dd2c..27f82a37b 100644 --- a/static/ui.js +++ b/static/ui.js @@ -5990,7 +5990,6 @@ async function handleComposerPrimaryAction(){ function setBusy(v){ S.busy=v; updateSendBtn(); - if(typeof _applyBusyComposerPlaceholder==='function') _applyBusyComposerPlaceholder(); if(!v){ if(typeof _clearActivityElapsedTimer==='function') _clearActivityElapsedTimer(); setStatus(''); diff --git a/tests/test_1003_preferences_autosave.py b/tests/test_1003_preferences_autosave.py index b04a0a195..db92bc593 100644 --- a/tests/test_1003_preferences_autosave.py +++ b/tests/test_1003_preferences_autosave.py @@ -5,7 +5,7 @@ preferences-panel autosave pattern is wired correctly: - All 15 preference fields use _schedulePreferencesAutosave (not _markSettingsDirty) - Password field MUST still call _markSettingsDirty (security: never autosave) -- _preferencesPayloadFromUi covers all 14 fields +- _preferencesPayloadFromUi covers all 15 fields - _setPreferencesAutosaveStatus uses the shared i18n keys - Status div exists in static/index.html - _autosavePreferencesSettings clears the dirty flag and hides the unsaved bar diff --git a/tests/test_5144_busy_composer_placeholder_hint.py b/tests/test_5144_busy_composer_placeholder_hint.py index f38554830..544be8d3b 100644 --- a/tests/test_5144_busy_composer_placeholder_hint.py +++ b/tests/test_5144_busy_composer_placeholder_hint.py @@ -72,7 +72,8 @@ def test_busy_placeholder_helper_preserves_compression_and_drafts(): assert "_applyBusyComposerPlaceholder" in update_block busy_block = _function_block(UI_JS, "setBusy") - assert "_applyBusyComposerPlaceholder" in busy_block + assert "updateSendBtn();" in busy_block + assert "_applyBusyComposerPlaceholder" not in busy_block def test_locale_blocks_cover_new_keys():