Skip to content

Commit e549d84

Browse files
torreypayneTorrey Payne
andauthored
feat: Add Gemfile.lock to google-cloud-spanner (#238)
Add Gemfile.lock to the handwritten library to ensure consistent dependency versions in development and CI. Update CONTRIBUTING.md to remove the incorrect root-level bundle install instruction and add a note about managing Gemfile.lock. Fix NameError in doctest_helper.rb by explicitly requiring 'ostruct'. Update gemspec to reject Gemfile.lock from package files. Addresses b/509981628 Co-authored-by: Torrey Payne <torreypayne@google.com>
1 parent 3a19092 commit e549d84

6 files changed

Lines changed: 447 additions & 15 deletions

File tree

CONTRIBUTING.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,15 @@ there is a small amount of setup:
3535
$ gem install bundler
3636
```
3737

38-
3. Install the top-level project dependencies.
39-
40-
```sh
41-
$ bundle install
42-
```
43-
44-
4. Install the Spanner dependencies.
38+
3. Install the Spanner dependencies.
4539

4640
```sh
4741
$ cd google-cloud-spanner/
4842
$ bundle install
4943
```
5044

45+
Note: We commit `Gemfile.lock` to ensure consistent dependency versions in development and CI. If you update dependencies in `Gemfile` or `google-cloud-spanner.gemspec`, make sure to run `bundle update` and commit the updated `Gemfile.lock`.
46+
5147
## Console
5248

5349
In order to run code interactively, you can automatically load

google-cloud-spanner/.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Gemfile.lock
21
coverage/*
32
doc/*
43
pkg/*

google-cloud-spanner/CONTRIBUTING.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,15 @@ there is a small amount of setup:
3535
$ gem install bundler
3636
```
3737

38-
3. Install the top-level project dependencies.
39-
40-
```sh
41-
$ bundle install
42-
```
43-
44-
4. Install the Spanner dependencies.
38+
3. Install the Spanner dependencies.
4539

4640
```sh
4741
$ cd google-cloud-spanner/
4842
$ bundle install
4943
```
5044

45+
Note: We commit `Gemfile.lock` to ensure consistent dependency versions in development and CI. If you update dependencies in `Gemfile` or `google-cloud-spanner.gemspec`, make sure to run `bundle update` and commit the updated `Gemfile.lock`.
46+
5147
## Console
5248

5349
In order to run code interactively, you can automatically load

0 commit comments

Comments
 (0)