Skip to content

Commit b33a88d

Browse files
committed
restore TestPostProcessAPI_AlternateHeaders and remove duplicate test case
1 parent 874f6f7 commit b33a88d

1 file changed

Lines changed: 37 additions & 13 deletions

File tree

internal/librarian/java/postprocess_test.go

Lines changed: 37 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -470,6 +470,43 @@ func TestPostProcessAPI_SkipHeaders(t *testing.T) {
470470
}
471471
}
472472

473+
func TestPostProcessAPI_AlternateHeaders(t *testing.T) {
474+
t.Parallel()
475+
outdir := t.TempDir()
476+
apiBase := "v1"
477+
gRPCDir := filepath.Join(outdir, apiBase, "grpc")
478+
if err := os.MkdirAll(gRPCDir, 0755); err != nil {
479+
t.Fatal(err)
480+
}
481+
grpcFile := filepath.Join(gRPCDir, "GRPCFile.java")
482+
if err := os.WriteFile(grpcFile, []byte("package com.test;"), 0644); err != nil {
483+
t.Fatal(err)
484+
}
485+
params := postProcessParams{
486+
outDir: outdir,
487+
apiBase: apiBase,
488+
library: &config.Library{Java: &config.JavaModule{}},
489+
javaAPI: &config.JavaAPI{},
490+
}
491+
altHeader := "/* Alternate */\n"
492+
headerFile := filepath.Join(outdir, "header.txt")
493+
if err := os.WriteFile(headerFile, []byte(altHeader), 0644); err != nil {
494+
t.Fatal(err)
495+
}
496+
params.library.Java.AlternateHeaders = "header.txt"
497+
if err := addHeaders(params, []string{gRPCDir}); err != nil {
498+
t.Fatal(err)
499+
}
500+
got, err := os.ReadFile(grpcFile)
501+
if err != nil {
502+
t.Fatal(err)
503+
}
504+
wantHeader := "/* Alternate */"
505+
if !bytes.HasPrefix(got, []byte(wantHeader)) {
506+
t.Errorf("mismatch got = %q, want %q", got, wantHeader)
507+
}
508+
}
509+
473510
func TestCopyProtos_Success(t *testing.T) {
474511
t.Parallel()
475512
destDir := t.TempDir()
@@ -820,19 +857,6 @@ func TestAddMissingHeaders(t *testing.T) {
820857
content: "some text",
821858
wantContent: "some text",
822859
},
823-
{
824-
name: "alternate header",
825-
params: postProcessParams{
826-
library: &config.Library{
827-
Java: &config.JavaModule{
828-
AlternateHeaders: "header.txt",
829-
},
830-
},
831-
},
832-
filename: "AlternateHeader.java",
833-
content: "package com.example;",
834-
wantContent: "/* Alternate Header */\npackage com.example;",
835-
},
836860
} {
837861
t.Run(test.name, func(t *testing.T) {
838862
t.Parallel()

0 commit comments

Comments
 (0)