Versions Check CI Failure

[lqiu96]

CI Issue:

59:      <version>1.51.0</version>
107:      <version>1.51.0</version>
Found version declaration(s) without x-version-update in: ./java-iam/google-iam-policy/pom.xml
---------------------------------------------------------
Skipping version check for java-samples directory
Skipping version check for java-samples directory
FOUND 1 VIOLATIONS!

This is because proto-iam-v3beta and grpc-iam-v3beta have versions hard-coded:

google-cloud-java/java-iam/google-iam-policy/pom.xml

Line 59 in 6baae9d

<version>1.51.0</version>

and

google-cloud-java/java-iam/google-iam-policy/pom.xml

Line 107 in 6baae9d

<version>1.51.0</version>

This is because the versions are managed in gapic-generator-bom and an old version of release-please removed the versions set.

PR to add it back: googleapis/sdk-platform-java#3785

We can remove the hard coded versions once sdk-platform-java is released with the PR and that should resolve this issue.

[diegomarquezp]

cl/753251559 fails due to this check.

Found version declaration(s) without x-version-update

Would we be ok with adding the region tag for the time being?

[lqiu96]

cl/753251559 fails due to this check.

Can the CI only run the GH required checks? Or is that too difficult?

Would we be ok with adding the region tag for the time being?

There isn't a matching entry in versions.txt for google-cloud-java since the versions are defined in sdk-platform-java. If it's blocking, then I think we can create dummy values so satisfy it.

[diegomarquezp]

here isn't a matching entry in versions.txt

Ah, gotcha. I'll wait for the next sdk-platform.

Can the CI only run the GH required checks?

I'll take a look at this.

[blakeli0]

The hardcoded versions are already removed. Closing this issue.