fix(bq_driver): Fix logging issue

Author: NeerajDwivedii

google/cloud/odbc/bq_driver/internal/trace_utils.cc

@@ -263,12 +263,10 @@ TraceOptions::CreateTraceOptionsFile(
   int log_level = 0;
   int log_file_count;
   int log_file_size;
-  int max_threads;
-  bool logging_enabled = false;
+  int max_threads = 0;
   for (auto const& s : trace_sections) {
     if (s.first == kLogLevel && !s.second.empty()) {
       log_level = std::strtol(s.second.c_str(), nullptr, 10);
-      logging_enabled = (log_level > 0);
     } else if (s.first == kLogPath) {
       log_path = s.second;
     } else if (s.first == kLogFileCount) {
@@ -286,9 +284,8 @@ TraceOptions::CreateTraceOptionsFile(
     options_file_ = std::shared_ptr<TraceOptions>(new TraceOptions());
   }
 
-  if (log_level > 0 && logging_enabled) {
+  if (log_level > 0) {
     options_file_->log_level = log_level;
-    options_file_->logging_enabled = logging_enabled;
     options_file_->log_path = log_path;
     options_file_->max_file_count = log_file_count;
     options_file_->max_file_size = log_file_size;

google/cloud/odbc/bq_driver/internal/trace_utils.h

@@ -36,11 +36,11 @@
 
 namespace google::cloud::odbc_bq_driver_internal {
 
-std::string const kLogLevel = "LogLevel";
-std::string const kLogPath = "LogPath";
-std::string const kLogFileCount = "LogFileCount";
-std::string const kLogFileSize = "LogFileSize";
-std::string const kMaxThreadsParam = "MaxThreads";
+inline std::string const kLogLevel = "LogLevel";
+inline std::string const kLogPath = "LogPath";
+inline std::string const kLogFileCount = "LogFileCount";
+inline std::string const kLogFileSize = "LogFileSize";
+inline std::string const kMaxThreadsParam = "MaxThreads";
 
 /////////////////////////////////////////////////////////////////////////////////
 // TraceOptions facilitates ODBC tracing.