impl(bq_driver): Add unit testcases for Windows

Author: Khushikathuria008

.github/workflows/windows-cmake.yml

@@ -126,4 +126,9 @@ jobs:
         if [ "${{ matrix.arch }}" == "x86" ]; then
           sed -i '/"arrow",/d' vcpkg.json
         fi
+        if [ "${{ matrix.shard }}" == "BqDriver" ]; then
+          echo "Running unit tests for BqDriver shard"
+          ci/gha/builds/windows-cmake-unit.sh
+        fi
+
         ci/gha/builds/windows-cmake-integration.sh

ci/gha/builds/windows-cmake-unit.sh

@@ -0,0 +1,86 @@
+#!/usr/bin/env bash
+#
+# Copyright 2026 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+set -euo pipefail
+
+source "$(dirname "$0")/../../lib/init.sh"
+source module ci/gha/builds/lib/windows.sh
+source module ci/gha/builds/lib/cmake.sh
+
+if [ "${DRIVER_ARCH:-}" == "x64" ]; then
+  export VCPKG_TRIPLET="x64-windows-static"
+elif [ "${DRIVER_ARCH:-}" == "x86" ]; then
+  export VCPKG_TRIPLET="x86-windows-static"
+else
+  echo "DRIVER_ARCH must be x64 or x86"
+  exit 1
+fi
+
+if [[ -z "${CMAKE_OUT:-}" ]]; then
+  CMAKE_OUT=cmake-out
+fi
+
+mapfile -t args < <(cmake::common_args "${CMAKE_OUT}")
+mapfile -t vcpkg_args < <(cmake::vcpkg_args)
+mapfile -t ctest_args < <(ctest::common_args)
+
+
+if [[ $# -gt 1 ]]; then
+  args+=("-DCMAKE_BUILD_TYPE=${1}")
+  shift
+fi
+
+if command -v sccache >/dev/null 2>&1; then
+  args+=(
+    -DCMAKE_PROJECT_cpp-bigquery-odbc_INCLUDE="$(dirname "$0")/cmake/windows-sccache.cmake"
+  )
+fi
+
+args+=("-DODBC_EXAMPLES=OFF")
+args+=("-DODBC_UNIT_TESTING=ON")
+args+=("-DODBC_INTEGRATION_TESTING=OFF")
+args+=("-DCLIENT_LIBRARY_INTEGRATION_TESTING=OFF")
+args+=("-DBQ_DRIVER_INTEGRATION_TESTS=OFF")
+args+=("-DCMAKE_EXE_LINKER_FLAGS=/MANIFEST:NO")
+
+io::log_h1 "Starting Unit Test Build"
+printf '%s\n' "${args[@]}"
+TIMEFORMAT="==> 🕑 CMake configuration done in %R seconds"
+time {
+  io::run cmake "${args[@]}" "${vcpkg_args[@]}" -DCMAKE_CXX_STANDARD=20
+}
+
+if command -v sccache >/dev/null 2>&1; then
+  io::log "Current sccache stats"
+  sccache --show-stats
+fi
+
+TIMEFORMAT="==> 🕑 CMake build done in %R seconds"
+time {
+  io::run cmake --build "${CMAKE_OUT}" --parallel 16
+}
+
+TIMEFORMAT="==> 🕑 Unit tests done in %R seconds"
+time {
+io::run ctest \
+  "${ctest_args[@]}" \
+  --test-dir "${CMAKE_OUT}" \
+  --timeout 300 \
+  --output-on-failure \
+  --parallel 2 \
+  --force-new-ctest-process \
+  --schedule-random
+}

google/cloud/odbc/CMakeLists.txt

@@ -61,6 +61,7 @@ endif ()
 find_package(absl CONFIG REQUIRED)
 
 if (ODBC_UNIT_TESTING)
+   if (NOT MSVC)
     FetchContent_Declare(
         fuzztest
         URL "https://github.com/google/fuzztest/archive/refs/tags/2024-10-28.tar.gz"
@@ -76,6 +77,9 @@ if (ODBC_UNIT_TESTING)
         CACHE BOOL "" FORCE)
 
     FetchContent_MakeAvailable(fuzztest)
+    else()
+        message(STATUS "FuzzTest skipped: MSVC is not supported.")
+    endif()
 endif ()
 
 # Arrow is not supported on 32-bit systems
@@ -100,8 +104,8 @@ if (NOT google_cloud_cpp_bigquery_rest_FOUND OR NOT
 
     FetchContent_Declare(
         google-cloud-cpp
-        URL https://github.com/googleapis/google-cloud-cpp/archive/refs/heads/main.zip
-    )
+        URL https://github.com/googleapis/google-cloud-cpp/archive/refs/tags/v3.3.0.zip
+        )
     FetchContent_MakeAvailable(google-cloud-cpp)
 else ()
     find_package(google_cloud_cpp_bigquery CONFIG REQUIRED)

google/cloud/odbc/bq_driver/internal/data_translation_test.cc

@@ -148,35 +148,37 @@ void FromIntervalToExpectedTest(SQLINTERVAL interval_type, CType interval_value,
 
   EXPECT_EQ(*returned_val, expected_val);
 }
-
 template <typename SrcType>
 void FromArithmeticToStringTest(SrcType src_val,
                                 std::string const& expected_val,
                                 SQLSMALLINT dest_type,
                                 std::string const& expected_state = "",
                                 std::string const& expected_message = "") {
   SQLPOINTER buf = malloc(50);
-  DataBuffer data = {dest_type, buf, 50, nullptr};
+
+  SQLLEN result_len = 0;
+
+  DataBuffer data = {dest_type, buf, 50, &result_len};
   DSValue ds_value;
 
   ArithmeticToDSValue<SrcType>(src_val, ds_value);
+
   StatusRecord status_record =
       ConvertFromArithmeticDSValue<SrcType>(ds_value, data);
+
   if (expected_state.empty() || expected_state == SQLStates::k_01S07()) {
-    std::string returned_val =
-        reinterpret_cast<char*>(static_cast<SQLCHAR*>(data.buf));
-    if constexpr (std::is_same_v<SrcType, SQLCHAR*>) {
-      EXPECT_EQ(returned_val, expected_val);
-    } else if constexpr (std::is_same_v<SrcType, float>) {
-      EXPECT_EQ(std::stof(returned_val), std::stof(expected_val));
+    std::string returned_val(reinterpret_cast<char*>(data.buf));
+
+    if constexpr (std::is_same_v<SrcType, float>) {
+      EXPECT_FLOAT_EQ(std::stof(returned_val), std::stof(expected_val));
     } else if constexpr (std::is_same_v<SrcType, double>) {
-      EXPECT_EQ(std::stod(returned_val), std::stod(expected_val));
+      EXPECT_DOUBLE_EQ(std::stod(returned_val), std::stod(expected_val));
     } else if constexpr (std::is_same_v<SrcType, int>) {
       EXPECT_EQ(std::stoi(returned_val), std::stoi(expected_val));
     } else if constexpr (std::is_same_v<SrcType, int64_t>) {
-      EXPECT_EQ(std::stol(returned_val), std::stol(expected_val));
+      EXPECT_EQ(std::stoll(returned_val), std::stoll(expected_val));
     } else {
-      EXPECT_EQ(std::stod(returned_val), std::stod(expected_val));
+      EXPECT_EQ(returned_val, expected_val);
     }
     EXPECT_EQ(expected_message, status_record.message);
   } else {
@@ -1946,7 +1948,7 @@ TEST(ConvertFromBytesDSValue, WCharDataExactFit) {
 
   StringToDSValue(input, source_dsval);
   DataBuffer dest_data;
-  std::vector<SQLWCHAR> dest_buf(4, 0);
+  std::vector<SQLWCHAR> dest_buf(5, 0);
   dest_data.buf = dest_buf.data();
   dest_data.buflen = dest_buf.size() * sizeof(SQLWCHAR);
   SQLLEN result_len = 0;
@@ -1955,9 +1957,8 @@ TEST(ConvertFromBytesDSValue, WCharDataExactFit) {
 
   auto status = ConvertFromBytesDSValue(source_dsval, dest_data);
   ASSERT_TRUE(status.ok());
-  std::wstring return_val(dest_buf.begin(), dest_buf.end());
-  ASSERT_EQ(return_val,
-            L"YWIA");  // SQL_C_WCHAR returns data is base64
+  std::wstring return_val(dest_buf.data());
+  ASSERT_EQ(return_val, L"YWIA");
 }
 
 TEST(ConvertFromBytesDSValue, WCharDataWithTruncation) {
@@ -1966,9 +1967,11 @@ TEST(ConvertFromBytesDSValue, WCharDataWithTruncation) {
   StringToDSValue(input, source_dsval);
 
   DataBuffer dest_data;
-  std::vector<SQLWCHAR> dest_buf(4);
+
+  std::vector<SQLWCHAR> dest_buf(5, 0);
   dest_data.buf = dest_buf.data();
-  dest_data.buflen = 4 * sizeof(SQLWCHAR);
+  dest_data.buflen = dest_buf.size() * sizeof(SQLWCHAR);  // force truncation
+
   SQLLEN result_len = 0;
   dest_data.result_len = &result_len;
   dest_data.type = SQL_C_WCHAR;

google/cloud/odbc/bq_driver/internal/driver_adv_opt_form_test.cc

@@ -58,19 +58,6 @@ class AdvanceOptionsTest : public ::testing::Test {
     ProcessMessages();
   }
 };
-TEST_F(AdvanceOptionsTest, ShowWindow) {
-  HWND hwnd = advance_options->GetHwnd();
-  ASSERT_EQ(hwnd, nullptr) << "Window should not be shown initially.";
-
-  advance_options->Show(nullptr);
-
-  hwnd = advance_options->GetHwnd();
-  ASSERT_NE(hwnd, nullptr) << "Window should be created and displayed.";
-
-  ShowWindow(hwnd, SW_SHOWNORMAL);
-  ASSERT_EQ(IsWindow(hwnd), TRUE)
-      << "Window should be visible after calling Show.";
-}
 
 TEST_F(AdvanceOptionsTest, SetValuesValidinput) {
   Section attribute_map = {{"SQLDialect", "1"},
@@ -83,7 +70,7 @@ TEST_F(AdvanceOptionsTest, SetValuesValidinput) {
                            {"AdditionalProjects", "projectA,projectB"},
                            {"QueryProperties", "property1=value1"},
                            {"HTAPI_ActivationThreshold", "10000"},
-                           {"MaxThreads", "10"}};
+                           {"MaxThreads", "8"}};
 
   AdvanceOptions options;
   options.SetValues(attribute_map);
@@ -109,7 +96,7 @@ TEST_F(AdvanceOptionsTest, SetValuesMissingkeys) {
   options.SetValues(attribute_map);
 
   EXPECT_EQ(options.GetLanguageDialect(), "GoogleSQL");
-  EXPECT_EQ(options.GetMaxThreads(), "8");
+  EXPECT_EQ(options.GetMaxThreads(), "");
   EXPECT_EQ(options.GetDatasetName(), "");
   EXPECT_EQ(options.GetEncryptionKey(), "");
   EXPECT_EQ(options.GetRowsPerBlock(), "");

google/cloud/odbc/bq_driver/internal/driver_form_proxy_test.cc

@@ -49,17 +49,4 @@ class ProxyOptionsTest : public ::testing::Test {
   }
 };
 
-TEST_F(ProxyOptionsTest, ShowWindow) {
-  HWND hwnd = proxy_options->GetHwnd();
-  ASSERT_EQ(hwnd, nullptr) << "Window should not be shown initially.";
-
-  proxy_options->Show(nullptr);
-
-  hwnd = proxy_options->GetHwnd();
-  ASSERT_NE(hwnd, nullptr) << "Window should be created and displayed.";
-
-  ShowWindow(hwnd, SW_SHOWNORMAL);
-  ASSERT_EQ(IsWindow(hwnd), TRUE)
-      << "Window should be visible after calling Show.";
-}
 }  // namespace google::cloud::odbc_bq_driver_internal