Merge pull request #12 from googleads/update-util-library-gmail

chore(format): Update formatter to handle plus signs in emails with Google domains

Author: lindsey-volta

package-lock.json

@@ -18,7 +18,7 @@
   },
   "dependencies": {
     "@google-ads/datamanager": "^0.1.0",
-    "@google-ads/data-manager-util": "^0.2.0",
+    "@google-ads/data-manager-util": "^0.3.0",
     "csv-parser": "^3.0.0",
     "yargs": "^17.7.2"
   },

samples/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@google-ads/data-manager-util",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "description": "A utility library for the Data Manager API for Node.js.",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",

util/package.json

@@ -47,6 +47,7 @@ export class UserDataFormatter {
     }
 
     if (domain === 'gmail.com' || domain === 'googlemail.com') {
+      username = username.split('+')[0];
       username = username.replace(/\./g, '');
     }
 

util/src/formatter.ts

@@ -28,6 +28,9 @@ describe('UserDataFormatter', () => {
       expect(formatter.formatEmailAddress('QuinnY@EXAMPLE.com')).to.equal(
         'quinny@example.com',
       );
+      expect(
+        formatter.formatEmailAddress('user.name+NYC@Example.com'),
+      ).to.equal('user.name+nyc@example.com');
     });
 
     it('should throw an error for invalid email addresses', () => {
@@ -47,6 +50,14 @@ describe('UserDataFormatter', () => {
       expect(
         formatter.formatEmailAddress('jefferson.Loves.hiking@googlemail.com'),
       ).to.equal('jeffersonloveshiking@googlemail.com');
+      expect(
+        formatter.formatEmailAddress('Cloudy.SanFrancisco+shopping@gmail.com'),
+      ).to.equal('cloudysanfrancisco@gmail.com');
+      expect(
+        formatter.formatEmailAddress(
+          'Cloudy.SanFrancisco+shopping@googlemail.com',
+        ),
+      ).to.equal('cloudysanfrancisco@googlemail.com');
     });
   });