Add MIT dual licensing (Apache-2.0 OR MIT)#386
Conversation
Add MIT as a dual license option alongside Apache 2.0 to enable GPLv2 compatibility, following the pattern used by other Google dual-licensed projects (e.g. google/aarch64-paging). Changes: - Add LICENSE-MIT with standalone MIT license text - Add LICENSE-APACHE with standalone Apache 2.0 license text - Update LICENSE to combined format with both license texts - Update source file headers to reference dual licensing - Add License section to README.md Resolves google#380
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
temcguir
left a comment
temcguir
left a comment
There was a problem hiding this comment.
Thank you for this PR! And sorry for taking so long to get the required permissions to review. I just have a few nit-picks. The first applies to all of the files with modified headers:
Google's official open-source releasing guidelines for dual licenses (specifically Apache 2.0 and MIT) require a specific, detailed file header rather than the short notice you proposed.
You have correctly retained the original copyright notices. Please update the license statement below them in all modified source files to use the required detailed boilerplate. The resulting header should look like this:
Copyright {{YYYY}} The Android Open Source Project
Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
https://www.apache.org/licenses/LICENSE-2.0> or the MIT license
<LICENSE-MIT or https://opensource.org/licenses/MIT>, at your
option. This file may not be copied, modified, or distributed
except according to those terms.
(Ensuring {{YYYY}} still matches the original year in each file.)
Replace the short dual-license notice with the detailed boilerplate required by Google's open-source releasing guidelines for Apache 2.0 and MIT. Original copyright lines (and years) are preserved. Addresses review feedback on PR google#386.
Use the wording requested in PR google#386 review: "This software is distributed under the terms of both the MIT license and the Apache License (Version 2.0)."
Per PR google#386 review feedback, point to the unified LICENSE file rather than the individual LICENSE-APACHE and LICENSE-MIT files.
|
@temcguir Thanks for the review. I have addressed your feedback and this is ready for another review! |
temcguir
left a comment
temcguir
left a comment
There was a problem hiding this comment.
Thank you for the quick updates! LGTM.
Replace the short dual-license notice with the detailed boilerplate required by Google's open-source releasing guidelines for Apache 2.0 and MIT. Original copyright lines (and years) are preserved. Addresses review feedback on PR #386.
Use the wording requested in PR #386 review: "This software is distributed under the terms of both the MIT license and the Apache License (Version 2.0)."
* Docs: standardize "Licence" to "License" (American English) Matching the LICENSE file. * Docs: update licensing info for libultrahdr See: google/libultrahdr#386 * Docs: update licensing info for Highway Highway is used under the terms of the BSD 3-Clause license.
3 participants
Summary
Add MIT as a dual license option alongside Apache 2.0, enabling GPLv2 compatibility. This follows the exact pattern used by other Google dual-licensed projects (e.g.
google/aarch64-paging).LICENSE-MITandLICENSE-APACHEstandalone license filesLICENSEfile with dual-license preamble and both full license textsREADME.mdThird-party code (
third_party/), test data licenses (tests/data/LICENSE), and machine-generated JNI headers are intentionally left unchanged.Resolves #380