Skip to content

Commit 21e4ffd

Browse files
Reif TauatiReif Tauati
authored andcommitted
[reader] Return openVerseDiscovery promise; E2E tests click .verse-num to avoid word channel
Made-with: Cursor
1 parent e013522 commit 21e4ffd

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

library/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3233,7 +3233,7 @@
32333233
entries: entries, entsInline: entsInline, scriptureEdgesEarly: scriptureEdgesEarly
32343234
};
32353235

3236-
loadChapterWordIndex(chapterId).then(function(wordIdx) {
3236+
return loadChapterWordIndex(chapterId).then(function(wordIdx) {
32373237
var verseData = wordIdx && wordIdx[vnum] ? wordIdx[vnum] : {};
32383238
var mergedKw = mergeKeyWordsForVerse(donaWords, verseData, verseText, chapterId);
32393239
registerChapterKeywordHeadwords(mergedKw, verseText);

test-library-mobile-channel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ async function run() {
5252
await page.click('.toc-tile[data-action="chapter"][data-id="genesis_1"]');
5353

5454
await page.waitForSelector('#ch-genesis_1', { timeout: 20000 });
55-
await page.click('#ch-genesis_1 .verse[id="v1"]');
55+
await page.click('#ch-genesis_1 .verse[id="v1"] .verse-num');
5656
await page.waitForSelector('#channel.open', { timeout: 15000 });
5757
await page.waitForSelector('#panel-body[data-panel-mode="verse"]', { timeout: 15000 });
5858

test-verse-discovery-panel.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@ async function run() {
4242
await page.$eval('#ch-genesis_1', (el) => el.scrollIntoView({ block: 'start' }));
4343
await page.waitForSelector('#ch-genesis_1 .verse[id="v1"]', { timeout: 15000 });
4444

45-
await page.evaluate(() => {
46-
if (typeof openVerseDiscovery === 'function') openVerseDiscovery('Genesis 1:1');
47-
});
45+
// Use verse number as click target so we do not hit span.w (word channel) inside .verse-text.
46+
await page.click('#ch-genesis_1 .verse[id="v1"] .verse-num');
4847
await page.waitForSelector('#panel-body[data-panel-mode="verse"]', { timeout: 20000 });
4948

5049
const state = await page.evaluate(() => {

0 commit comments

Comments
 (0)