|
| 1 | +"""v2.4.16 — CLI UX hygiene bundle. |
| 2 | +
|
| 3 | +Three small, unrelated fixes ride in one patch: |
| 4 | +
|
| 5 | +* ``memee validate --project <unregistered>`` used to crash with |
| 6 | + ``AttributeError: 'NoneType' object has no attribute 'id'`` because |
| 7 | + ``_get_or_create_project`` lied — it never created anything. Renamed |
| 8 | + to ``_get_project_by_path`` and the caller now raises a clean |
| 9 | + ``click.ClickException``. |
| 10 | +
|
| 11 | +* ``memee feedback`` says EVENT_ID is "printed by ``memee search``", but |
| 12 | + search never passed ``return_event_id=True`` to the underlying |
| 13 | + ``search_memories`` call and never printed the id. ``search`` now |
| 14 | + surfaces ``query_event_id`` after the results so the documented |
| 15 | + feedback loop is actually one keystroke away. |
| 16 | +
|
| 17 | +The third member of the bundle — ``test_doctor_returns_ok_on_macos_with_deps`` |
| 18 | +gaining ``pytest.importorskip("rumps")`` — lives in ``tests/test_bar.py`` |
| 19 | +where the offending assertion is. |
| 20 | +""" |
| 21 | + |
| 22 | +from __future__ import annotations |
| 23 | + |
| 24 | +import re |
| 25 | + |
| 26 | +from click.testing import CliRunner |
| 27 | + |
| 28 | +from memee.cli import cli |
| 29 | +from memee.storage.models import MaturityLevel, Memory, MemoryType |
| 30 | + |
| 31 | + |
| 32 | +def test_validate_unregistered_project_returns_clean_error(tmp_path, monkeypatch): |
| 33 | + """No more AttributeError — a click error explains the next step.""" |
| 34 | + monkeypatch.setenv("MEMEE_HOME", str(tmp_path / ".memee")) |
| 35 | + runner = CliRunner() |
| 36 | + runner.invoke(cli, ["init"]) |
| 37 | + |
| 38 | + # Seed one memory so the lookup half of `validate` succeeds. |
| 39 | + from memee.storage.database import get_session, init_db |
| 40 | + engine = init_db() |
| 41 | + session = get_session(engine) |
| 42 | + m = Memory( |
| 43 | + type=MemoryType.PATTERN.value, |
| 44 | + title="Some pattern", |
| 45 | + content="content", |
| 46 | + maturity=MaturityLevel.HYPOTHESIS.value, |
| 47 | + ) |
| 48 | + session.add(m) |
| 49 | + session.commit() |
| 50 | + short = m.id[:8] |
| 51 | + session.close() |
| 52 | + |
| 53 | + bogus = str(tmp_path / "never-registered") |
| 54 | + result = runner.invoke(cli, ["validate", short, "-p", bogus]) |
| 55 | + assert result.exit_code != 0 |
| 56 | + combined = result.output + (result.stderr_bytes or b"").decode(errors="ignore") |
| 57 | + assert "not registered" in combined.lower(), combined |
| 58 | + # Concrete next step is mentioned so the user isn't stuck. |
| 59 | + assert "memee project add" in combined |
| 60 | + |
| 61 | + |
| 62 | +def test_search_prints_query_event_id(tmp_path, monkeypatch): |
| 63 | + """`memee search` surfaces the event_id so `memee feedback` works.""" |
| 64 | + monkeypatch.setenv("MEMEE_HOME", str(tmp_path / ".memee")) |
| 65 | + monkeypatch.setenv("MEMEE_TELEMETRY", "1") |
| 66 | + runner = CliRunner() |
| 67 | + runner.invoke(cli, ["init"]) |
| 68 | + |
| 69 | + from memee.storage.database import get_session, init_db |
| 70 | + engine = init_db() |
| 71 | + session = get_session(engine) |
| 72 | + session.add( |
| 73 | + Memory( |
| 74 | + type=MemoryType.PATTERN.value, |
| 75 | + title="Use timeout on HTTP requests", |
| 76 | + content="Always pass timeout=10 to requests.get.", |
| 77 | + tags=["python", "http"], |
| 78 | + maturity=MaturityLevel.VALIDATED.value, |
| 79 | + confidence_score=0.9, |
| 80 | + ) |
| 81 | + ) |
| 82 | + session.commit() |
| 83 | + session.close() |
| 84 | + |
| 85 | + result = runner.invoke(cli, ["search", "timeout HTTP"]) |
| 86 | + assert result.exit_code == 0, result.output |
| 87 | + assert "query_event_id:" in result.output |
| 88 | + # The id is a UUID-shaped string — check the format so a future |
| 89 | + # change of the print template doesn't silently break the feedback |
| 90 | + # loop the user is following. |
| 91 | + match = re.search(r"query_event_id:\s+([0-9a-f-]{8,})", result.output) |
| 92 | + assert match, result.output |
| 93 | + |
| 94 | + |
| 95 | +def test_search_no_results_still_prints_event_id(tmp_path, monkeypatch): |
| 96 | + """Empty result sets still log a SearchEvent — surface its id too so |
| 97 | + `memee feedback` works after an exploratory zero-hit query.""" |
| 98 | + monkeypatch.setenv("MEMEE_HOME", str(tmp_path / ".memee")) |
| 99 | + monkeypatch.setenv("MEMEE_TELEMETRY", "1") |
| 100 | + runner = CliRunner() |
| 101 | + runner.invoke(cli, ["init"]) |
| 102 | + result = runner.invoke(cli, ["search", "zzz-no-match-zzz"]) |
| 103 | + assert result.exit_code == 0 |
| 104 | + assert "No memories found" in result.output |
| 105 | + assert "query_event_id:" in result.output |
| 106 | + |
| 107 | + |
| 108 | +def test_search_silent_when_telemetry_disabled(tmp_path, monkeypatch): |
| 109 | + """With telemetry off, no event id to print → don't print a misleading |
| 110 | + empty 'query_event_id:' line.""" |
| 111 | + monkeypatch.setenv("MEMEE_HOME", str(tmp_path / ".memee")) |
| 112 | + monkeypatch.setenv("MEMEE_TELEMETRY", "0") |
| 113 | + runner = CliRunner() |
| 114 | + runner.invoke(cli, ["init"]) |
| 115 | + |
| 116 | + from memee.storage.database import get_session, init_db |
| 117 | + engine = init_db() |
| 118 | + session = get_session(engine) |
| 119 | + session.add( |
| 120 | + Memory( |
| 121 | + type=MemoryType.PATTERN.value, |
| 122 | + title="Some pattern", |
| 123 | + content="content", |
| 124 | + tags=["any"], |
| 125 | + maturity=MaturityLevel.HYPOTHESIS.value, |
| 126 | + ) |
| 127 | + ) |
| 128 | + session.commit() |
| 129 | + session.close() |
| 130 | + |
| 131 | + result = runner.invoke(cli, ["search", "pattern"]) |
| 132 | + assert result.exit_code == 0 |
| 133 | + assert "query_event_id:" not in result.output |
0 commit comments