diff --git a/src/renderer/__mocks__/notifications-mocks.ts b/src/renderer/__mocks__/notifications-mocks.ts index 48a7fbe2d..6f8d351a1 100644 --- a/src/renderer/__mocks__/notifications-mocks.ts +++ b/src/renderer/__mocks__/notifications-mocks.ts @@ -4,7 +4,7 @@ import { GitCommitIcon, GitPullRequestIcon, IssueOpenedIcon, - TagIcon, + ReleaseIcon, } from '@primer/octicons-react'; import { @@ -184,7 +184,7 @@ export const mockGithubEnterpriseGitifyNotifications: GitifyNotification[] = [ title: 'Release 0.0.1', type: 'Release', icon: { - type: TagIcon, + type: ReleaseIcon, color: IconColor.GREEN, }, defaultUserType: 'User', diff --git a/src/renderer/components/settings/NotificationSettings.tsx b/src/renderer/components/settings/NotificationSettings.tsx index cd9618334..4447cd5bb 100644 --- a/src/renderer/components/settings/NotificationSettings.tsx +++ b/src/renderer/components/settings/NotificationSettings.tsx @@ -12,6 +12,7 @@ import { IssueOpenedIcon, MilestoneIcon, PlusIcon, + ReleaseIcon, SmileyIcon, SyncIcon, TagIcon, @@ -309,7 +310,7 @@ export function NotificationSettings() { - + Release v1.2.3 diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark-classic-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark-classic-chromium-linux.png index 60fb0052d..c606966dc 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark-classic-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark-classic-chromium-linux.png differ diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark-glass-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark-glass-chromium-linux.png index 7ab7bc1cd..38ff437f2 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark-glass-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark-glass-chromium-linux.png differ diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_colorblind-classic-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_colorblind-classic-chromium-linux.png index eddf6d982..2a3da3a29 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_colorblind-classic-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_colorblind-classic-chromium-linux.png differ diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_dimmed-classic-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_dimmed-classic-chromium-linux.png index 9b0549187..1ca7d32ff 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_dimmed-classic-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_dimmed-classic-chromium-linux.png differ diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_tritanopia-classic-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_tritanopia-classic-chromium-linux.png index b77d8e4c9..66471588d 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_tritanopia-classic-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-dark_tritanopia-classic-chromium-linux.png differ diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light-classic-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light-classic-chromium-linux.png index 2e5f38164..225ab77e8 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light-classic-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light-classic-chromium-linux.png differ diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light-glass-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light-glass-chromium-linux.png index 8a291e19b..9682e04c0 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light-glass-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light-glass-chromium-linux.png differ diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light_colorblind-classic-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light_colorblind-classic-chromium-linux.png index 0ae44b930..4a74433e2 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light_colorblind-classic-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light_colorblind-classic-chromium-linux.png differ diff --git a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light_tritanopia-classic-chromium-linux.png b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light_tritanopia-classic-chromium-linux.png index 9f00d7a99..427e9b992 100644 Binary files a/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light_tritanopia-classic-chromium-linux.png and b/src/renderer/routes/__screenshots__/routes.visual.test.tsx/notifications-light_tritanopia-classic-chromium-linux.png differ diff --git a/src/renderer/utils/forges/github/handlers/release.test.ts b/src/renderer/utils/forges/github/handlers/release.test.ts index 3fc1b4e29..115bf27f8 100644 --- a/src/renderer/utils/forges/github/handlers/release.test.ts +++ b/src/renderer/utils/forges/github/handlers/release.test.ts @@ -70,7 +70,7 @@ describe('renderer/utils/notifications/handlers/release.ts', () => { }); it('iconType', () => { - expect(releaseHandler.iconType(mockNotification).displayName).toBe('TagIcon'); + expect(releaseHandler.iconType(mockNotification).displayName).toBe('ReleaseIcon'); }); it('defaultUrl', () => { diff --git a/src/renderer/utils/forges/github/handlers/release.ts b/src/renderer/utils/forges/github/handlers/release.ts index cbb3ffc2d..1c68dde82 100644 --- a/src/renderer/utils/forges/github/handlers/release.ts +++ b/src/renderer/utils/forges/github/handlers/release.ts @@ -1,7 +1,7 @@ import type { FC } from 'react'; import type { OcticonProps } from '@primer/octicons-react'; -import { TagIcon } from '@primer/octicons-react'; +import { ReleaseIcon } from '@primer/octicons-react'; import type { GitifyNotification, @@ -45,7 +45,7 @@ class ReleaseHandler extends DefaultHandler { } override iconType(_notification: GitifyNotification): FC { - return TagIcon; + return ReleaseIcon; } override defaultUrl(notification: GitifyNotification): Link {