Fix lint + clean up v2-direct-RPC tests

- `nodejs/src/session.ts` had an unused `PermissionRequestResult`
  import after the v2 drop. eslint flagged it (`no-unused-vars`).
- `nodejs/test/client.test.ts` had a leftover test for the deleted
  `handlePermissionRequestV2` v2 adapter. Delete the test.
- `rust/tests/session_test.rs` had two tests that drove the deleted
  `permission.request` direct-RPC arm (`permission_request_dispatches_to_handler`,
  `approve_all_handler_approves_permission`). Delete the first one and
  rewrite the second to exercise the broadcast-event path
  (`permission.requested` event + `handlePendingPermissionRequest`
  RPC response), which is the only remaining permission flow.
- Drop unused `PermissionHandler` / `PermissionResult` imports that
  the deleted tests left behind.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SteveSandersonMS

nodejs/src/session.ts

@@ -28,7 +28,6 @@ import type {
     MessageOptions,
     PermissionHandler,
     PermissionRequest,
-    PermissionRequestResult,
     ReasoningEffort,
     ModelCapabilitiesOverride,
     SectionTransformFn,

nodejs/test/client.test.ts

@@ -17,20 +17,6 @@ describe("CopilotClient", () => {
         expect(spy).not.toHaveBeenCalled();
     });
 
-    it("throws when a v2 permission handler returns no-result", async () => {
-        const session = new CopilotSession("session-1", {} as any);
-        session.registerPermissionHandler(() => ({ kind: "no-result" }));
-        const client = new CopilotClient();
-        (client as any).sessions.set(session.sessionId, session);
-
-        await expect(
-            (client as any).handlePermissionRequestV2({
-                sessionId: session.sessionId,
-                permissionRequest: { kind: "write" },
-            })
-        ).rejects.toThrow(/protocol v2 server/);
-    });
-
     it("forwards clientName in session.create request", async () => {
         const client = new CopilotClient();
         await client.start();

rust/tests/session_test.rs

@@ -8,8 +8,7 @@ use std::time::Duration;
 use async_trait::async_trait;
 use github_copilot_sdk::handler::{
     ApproveAllHandler, AutoModeSwitchHandler, AutoModeSwitchResponse, ElicitationHandler,
-    ExitPlanModeHandler, ExitPlanModeResult, PermissionHandler, PermissionResult, UserInputHandler,
-    UserInputResponse,
+    ExitPlanModeHandler, ExitPlanModeResult, UserInputHandler, UserInputResponse,
 };
 use github_copilot_sdk::types::{
     CommandContext, CommandDefinition, CommandHandler, DeliveryMode, ElicitationRequest,
@@ -1178,41 +1177,6 @@ async fn elicitation_returns_typed_result() {
     assert_eq!(result.content.unwrap()["name"], "Octocat");
 }
 
-#[tokio::test]
-async fn permission_request_dispatches_to_handler() {
-    struct DenyHandler;
-    #[async_trait]
-    impl PermissionHandler for DenyHandler {
-        async fn handle(
-            &self,
-            _session_id: SessionId,
-            _request_id: RequestId,
-            _data: PermissionRequestData,
-        ) -> PermissionResult {
-            PermissionResult::reject(None)
-        }
-    }
-
-    let (_session, mut server) =
-        create_session_pair_with_config(|cfg| cfg.with_permission_handler(Arc::new(DenyHandler)))
-            .await;
-    server
-        .send_request(
-            200,
-            "permission.request",
-            serde_json::json!({
-                "sessionId": server.session_id,
-                "requestId": "perm-1",
-                "kind": "shell",
-            }),
-        )
-        .await;
-
-    let response = timeout(TIMEOUT, server.read_response()).await.unwrap();
-    assert_eq!(response["id"], 200);
-    assert_eq!(response["result"]["kind"], "reject");
-}
-
 #[tokio::test]
 async fn user_input_request_dispatches_to_handler() {
     struct InputHandler;
@@ -1455,18 +1419,23 @@ async fn approve_all_handler_approves_permission() {
     .await;
 
     server
-        .send_request(
-            500,
-            "permission.request",
+        .send_event(
+            "permission.requested",
             serde_json::json!({
-                "sessionId": server.session_id,
                 "requestId": "perm-auto",
-                "kind": "shell",
+                "sessionId": server.session_id,
+                "permissionRequest": { "kind": "shell" },
             }),
         )
         .await;
-    let response = timeout(TIMEOUT, server.read_response()).await.unwrap();
-    assert_eq!(response["result"]["kind"], "approve-once");
+
+    let request = timeout(TIMEOUT, server.read_request()).await.unwrap();
+    assert_eq!(
+        request["method"],
+        "session.permissions.handlePendingPermissionRequest"
+    );
+    assert_eq!(request["params"]["requestId"], "perm-auto");
+    assert_eq!(request["params"]["result"]["kind"], "approve-once");
 }
 
 #[tokio::test]