Skip to content

Commit 26df24c

Browse files
DanWahlinCopilot
andcommitted
Exclude entire samples/ folder from translation
samples/ is the code samples folder and should not be translated. Expand the exclusion from samples/skills/** to all of samples/**: skip it in the push trigger, delete translations/<lang>/samples and translated_images/<lang>/samples before opening the PR, and ignore samples/** in the co-op-review filter. Update translation-polisher.md docs to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent cad41d4 commit 26df24c

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/scripts/filter-co-op-review.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const { spawnSync } = require("child_process");
1717
// Source paths that are intentionally excluded from translation. Keep this in
1818
// sync with the excludes in .github/workflows/co-op-translator.yml and the
1919
// guidance in .github/workflows/translation-polisher.md.
20-
const EXCLUDED_PREFIXES = [".github/", "samples/skills/"];
20+
const EXCLUDED_PREFIXES = [".github/", "samples/"];
2121

2222
const languages = process.argv
2323
.slice(2)

.github/workflows/co-op-translator.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414
- "!translations/**"
1515
- "!translated_images/**"
1616
- "!.github/**"
17-
- "!samples/skills/**"
17+
- "!samples/**"
1818

1919
permissions:
2020
contents: write
@@ -94,9 +94,9 @@ jobs:
9494
for language in $TRANSLATION_LANGUAGES; do
9595
rm -rf \
9696
"translations/$language/.github" \
97-
"translations/$language/samples/skills" \
97+
"translations/$language/samples" \
9898
"translated_images/$language/.github" \
99-
"translated_images/$language/samples/skills"
99+
"translated_images/$language/samples"
100100
done
101101
102102
- name: Upload Co-op Translator logs

.github/workflows/translation-polisher.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ You may edit only translated Markdown files:
9393
Exclude these generated translation paths from review, grading, and edits:
9494

9595
- `translations/*/.github/**`
96-
- `translations/*/samples/skills/**`
96+
- `translations/*/samples/**`
9797

9898
Leave skill definition Markdown in English.
9999

@@ -111,7 +111,7 @@ Do not edit:
111111
2. Compare each changed translated Markdown file with its corresponding English source file.
112112
- Example: compare `translations/es/README.md` with `README.md`.
113113
- Example: compare `translations/es/03-development-workflows/README.md` with `03-development-workflows/README.md`.
114-
3. Focus on files changed by the pull request, not every translated file in the repository. Ignore excluded translation paths under `translations/*/.github/**` and `translations/*/samples/skills/**`.
114+
3. Focus on files changed by the pull request, not every translated file in the repository. Ignore excluded translation paths under `translations/*/.github/**` and `translations/*/samples/**`.
115115
4. If the pull request body already has a managed `## Translation Quality Review` section, identify files with grades below A- and repair those files first.
116116
5. Preserve Markdown structure exactly unless a link or heading fix is required.
117117
6. Apply the shared quality rules and the language quality profile for each target language present in the pull request.

0 commit comments

Comments
 (0)