Test changes to investigate

Author: owen-mc

go/ql/test/library-tests/semmle/go/dataflow/GlobalValueNumbering/GlobalValueNumber.expected

@@ -26,10 +26,8 @@
 | main.go:28:15:28:17 | zero value for res | main.go:10:7:10:7 | 0 |
 | main.go:29:8:29:8 | 5 | main.go:29:8:29:8 | 5 |
 | main.go:30:9:30:9 | 6 | main.go:30:9:30:9 | 6 |
-| main.go:30:9:30:9 | definition of res | main.go:30:9:30:9 | 6 |
-| main.go:33:15:33:17 | definition of res | main.go:10:7:10:7 | 0 |
+| main.go:30:9:30:9 | SSA def(res) | main.go:30:9:30:9 | 6 |
 | main.go:33:15:33:17 | zero value for res | main.go:10:7:10:7 | 0 |
-| main.go:34:2:34:4 | definition of res | main.go:34:8:34:8 | 7 |
 | main.go:34:8:34:8 | 7 | main.go:34:8:34:8 | 7 |
 | main.go:35:8:37:4 | function call | main.go:35:8:37:4 | function call |
 | main.go:36:3:36:5 | SSA def(res) | main.go:36:9:36:9 | 8 |

go/ql/test/library-tests/semmle/go/frameworks/GoKit/RemoteFlowSources.expected

@@ -1,2 +1,6 @@
 invalidModelRow
 testFailures
+| main.go:15:33:15:39 | SSA def(request) | Unexpected result: source="SSA def(request)" |
+| main.go:15:77:15:111 | comment | Missing result: source="definition of request" |
+| main.go:20:36:20:42 | SSA def(request) | Unexpected result: source="SSA def(request)" |
+| main.go:20:80:20:114 | comment | Missing result: source="definition of request" |

go/ql/test/library-tests/semmle/go/frameworks/GoMicro/gomicro.expected

@@ -1,2 +1,4 @@
 invalidModelRow
 testFailures
+| main.go:18:46:18:48 | SSA def(req) | Unexpected result: serverRequest="SSA def(req)" |
+| main.go:18:89:18:126 | comment | Missing result: serverRequest="definition of req" |

go/ql/test/library-tests/semmle/go/frameworks/Yaml/tests.expected

@@ -1,2 +1,6 @@
 invalidModelRow
 testFailures
+| yaml.go:27:7:27:25 | call to NewEncoder | Unexpected result: ttfnmodelstep="SSA def(e) -> w [postupdate]" |
+| yaml.go:27:27:27:80 | comment | Missing result: ttfnmodelstep="definition of e -> w [postupdate]" |
+| yaml.go:36:8:36:26 | call to NewEncoder | Unexpected result: ttfnmodelstep="SSA def(e1) -> w [postupdate]" |
+| yaml.go:36:28:36:82 | comment | Missing result: ttfnmodelstep="definition of e1 -> w [postupdate]" |

go/ql/test/library-tests/semmle/go/frameworks/gqlgen/gqlgen.expected

@@ -1,2 +1,4 @@
 invalidModelRow
 testFailures
+| graph/schema.resolvers.go:14:60:14:64 | SSA def(input) | Unexpected result: resolverParameter="SSA def(input)" |
+| graph/schema.resolvers.go:14:104:14:147 | comment | Missing result: resolverParameter="definition of input" |