Onestep output is missing LUE, ...

[stineb]

The function https://geco-bern.github.io/rsofun/reference/run_pmodel_onestep_f_bysite.html should return light use efficiency and perhaps (TBD) also gross assimilation and light-saturated CO2 assimilation as an output.

Related issue:

In this vignette, we do gs = gs/1/(300/10^6), # divide by fapar (-) and by ppfd (mol/m2/s). Where is the 300 coming from? Is this correct?

@fabern

[fabern]

A) Thanks. Is noted on my Notion TODO list for the updates of rsofun.

B) Regarding the related issue. This is correct, yes. The 300/10^6 mol phot / m2 / s comes from the used ppfd forcing:

• gs returned by the rsofun function is in mol C / mol phot / Pa:
  

  rsofun/R/run_pmodel_onestep_f_bysite.R

  Lines 27 to 30 in 8156556

  	#' \item{\code{gs_accl}}{Acclimated stomatal conductance (in
  	#' mol C (mol photons)\eqn{^{-1}} Pa\eqn{^{-1}}. (Multiply by
  	#' ppfd (mol photons m\eqn{^{-2}} d\eqn{^{-1}}) and fapar
  	#' to express per unit ground area and time.)}

• Whereas gs returned by the rpmodel function is in mol C / m2 / Pa
  (or more accurately in mol C / m2 / Pa / unit time):

   #'         \item \code{gs}: Stomatal conductance (gs, in mol C m-2 Pa-1), calculated as 
   #'                        \deqn{ 
   #'                             gs = A / (ca (1-\chi)) 
   #'                        } 
   #'                        where \eqn{A} is \code{gpp}\eqn{/Mc}. 
  

  source: this
  Note that the unit time in the rpmodel output is determined by the time reference of A, i.e. gpp which depends on the reference of the input ppfd.

• Thus to bring them to same reference area/time used in the vignette and the test (i.e. mol C / m2 / Pa / s). We need to divide the rsofun output by fAPAR and by the ppfd, which was set in the vignette to 300/10^6 mol phot / m2 / s.