Skip to content

Commit fffa9de

Browse files
moved feedback prompt to txt
1 parent e6f7e1b commit fffa9de

5 files changed

Lines changed: 25 additions & 10 deletions

File tree

skills/fw-publish/SKILL.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,9 @@ Run `cd <app-directory> && fdk validate` and treat the result as the **validity
8282

8383
**You MUST ask this question before proceeding to fdk pack. Do not skip this step.**
8484

85-
Ask the developer once:
85+
Ask the developer once — show [`references/templates/developer-feedback-rating-prompt.txt`](references/templates/developer-feedback-rating-prompt.txt) **verbatim**.
8686

87-
> "Before we publish — how was your experience building this app with the Freshworks AI toolkit?
88-
> 👍 Liked it / 👎 Didn't like it / Skip"
89-
90-
If they respond with 👍 or 👎, follow up with:
91-
92-
> "Any specific feedback, improvements, or new features you'd like? (press Enter to skip)"
87+
If they respond with 👍 or 👎, follow up once — show [`references/templates/developer-feedback-comment-prompt.txt`](references/templates/developer-feedback-comment-prompt.txt) **verbatim**.
9388

9489
Then write feedback **before proceeding to step 5** using `meta-feedback.sh` (never write JSON by hand). If the developer skips or does not respond, **do not call** `meta-feedback.sh` — omit the `"feedback"` key entirely. Never mention `.meta.json` to the developer.
9590

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Any specific feedback, improvements, or new features you'd like? (press Enter to skip)
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Before we publish — how was your experience building this app with the Freshworks AI toolkit?
2+
👍 Liked it / 👎 Didn't like it / Skip

tests/run-inline-eval.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ const results = [];
235235
{
236236
const c = await skill('fw-publish');
237237
results.push(
238-
/feedback/i.test(c) && /meta-feedback\.sh/i.test(c) && /skip/i.test(c)
238+
/feedback/i.test(c) && /meta-feedback\.sh/i.test(c) && /developer-feedback-rating-prompt/i.test(c) && /skip/i.test(c)
239239
? pass('fw-publish-08', 'fw-publish', 'feedback step: must ask before step 5, skip gracefully if no answer — never write null or empty')
240240
: fail('fw-publish-08', 'fw-publish', 'feedback step: must ask before step 5, skip gracefully if no answer — never write null or empty', 'missing feedback step or meta-feedback.sh'),
241241
);

tests/skill-static.test.js

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -352,8 +352,10 @@ describe('fw-publish SKILL.md', () => {
352352
test('contains feedback prompt step before fdk pack', async () => {
353353
const content = await readSkill('fw-publish');
354354
assert.ok(
355-
content.includes('feedback') && (content.includes('4.5') || content.includes('Liked')),
356-
'fw-publish must prompt for developer feedback before pack step'
355+
content.includes('4.5')
356+
&& /developer-feedback-rating-prompt/i.test(content)
357+
&& /developer-feedback-comment-prompt/i.test(content),
358+
'fw-publish must reference developer feedback templates before pack step'
357359
);
358360
});
359361

@@ -570,6 +572,8 @@ describe('PR#21 — fw-publish reference files', () => {
570572
`${FW_PUB_REF}/templates/claude-mcp-setup.json`,
571573
`${FW_PUB_REF}/templates/cursor-mcp-setup.json`,
572574
`${FW_PUB_REF}/templates/custom-app-limit-warning.txt`,
575+
`${FW_PUB_REF}/templates/developer-feedback-comment-prompt.txt`,
576+
`${FW_PUB_REF}/templates/developer-feedback-rating-prompt.txt`,
573577
`${FW_PUB_REF}/templates/downgrade-warning.txt`,
574578
`${FW_PUB_REF}/templates/engines-mismatch-prompt.txt`,
575579
`${FW_PUB_REF}/templates/stuck-version-warning.txt`,
@@ -589,6 +593,17 @@ describe('PR#21 — fw-publish reference files', () => {
589593
}
590594
});
591595

596+
test('3.x: developer-feedback-rating-prompt.txt has Liked/Skip options', async () => {
597+
const txt = await readRepo(`${FW_PUB_REF}/templates/developer-feedback-rating-prompt.txt`);
598+
assert.ok(txt.includes('Liked it'), 'rating prompt must include Liked option');
599+
assert.ok(txt.includes('Skip'), 'rating prompt must include Skip option');
600+
});
601+
602+
test('3.x: developer-feedback-comment-prompt.txt invites optional comment', async () => {
603+
const txt = await readRepo(`${FW_PUB_REF}/templates/developer-feedback-comment-prompt.txt`);
604+
assert.ok(txt.includes('press Enter to skip'), 'comment prompt must allow skip');
605+
});
606+
592607
test('3.x: custom-app-limit-warning.txt mentions 25 app limit', async () => {
593608
const txt = await readRepo(`${FW_PUB_REF}/templates/custom-app-limit-warning.txt`);
594609
assert.ok(txt.includes('25'), 'must mention 25 app limit');
@@ -775,6 +790,8 @@ describe('PR#21 — internal link integrity', () => {
775790
'skills/fw-publish/references/templates/claude-mcp-setup.json',
776791
'skills/fw-publish/references/templates/engines-mismatch-prompt.txt',
777792
'skills/fw-publish/references/templates/custom-app-limit-warning.txt',
793+
'skills/fw-publish/references/templates/developer-feedback-comment-prompt.txt',
794+
'skills/fw-publish/references/templates/developer-feedback-rating-prompt.txt',
778795
'skills/fw-publish/references/templates/stuck-version-warning.txt',
779796
'skills/fw-publish/references/templates/downgrade-warning.txt',
780797
];

0 commit comments

Comments
 (0)