freestarcapital
diff --git a/‎AGENTS.md‎
Lines changed: 1 addition & 0 deletions b/‎AGENTS.md‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎PR_REVIEW.md‎
Lines changed: 5 additions & 3 deletions b/‎PR_REVIEW.md‎
Lines changed: 5 additions & 3 deletions
diff --git a/‎README.md‎
Lines changed: 1 addition & 1 deletion b/‎README.md‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎eslint.config.js‎
Lines changed: 4 additions & 1 deletion b/‎eslint.config.js‎
Lines changed: 4 additions & 1 deletion
diff --git a/‎gulp.precompilation.js‎
Lines changed: 4 additions & 2 deletions b/‎gulp.precompilation.js‎
Lines changed: 4 additions & 2 deletions
diff --git a/‎gulpHelpers.js‎
Lines changed: 10 additions & 8 deletions b/‎gulpHelpers.js‎
Lines changed: 10 additions & 8 deletions
diff --git a/‎gulpfile.js‎
Lines changed: 16 additions & 12 deletions b/‎gulpfile.js‎
Lines changed: 16 additions & 12 deletions
diff --git a/‎integrationExamples/gpt/x-domain/creative.html‎
Lines changed: 1 addition & 1 deletion b/‎integrationExamples/gpt/x-domain/creative.html‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎libraries/intentIqConstants/intentIqConstants.js‎
Lines changed: 1 addition & 2 deletions b/‎libraries/intentIqConstants/intentIqConstants.js‎
Lines changed: 1 addition & 2 deletions
diff --git a/‎libraries/medianetUtils/constants.js‎
Lines changed: 1 addition & 0 deletions b/‎libraries/medianetUtils/constants.js‎
Lines changed: 1 addition & 0 deletions
@@ -71,3 +71,4 @@ This file contains instructions for the Codex agent and its friends when working
 - Low priority calls should be import ajax method and use fetch keepalive; they shouldnt use trigger pixel when it can be avoided or fail to specify keepalive.
 - Analytics modules must provide a disableAnalytics method.
 - Metadata files that say do not edit in the comments should not be edited; the build process is responsible for updating the metadata files.
+- PRs should not need to modify https://github.com/prebid/Prebid.js/blob/master/metadata/overrides.mjs as module codes and module names should generally match.
@@ -8,7 +8,7 @@ For modules and core platform updates, the initial reviewer should request an ad
 
 ### Running Tests and Verifying Integrations
 
-General gulp commands include separate commands for serving the codebase on a built in webserver, creating code coverage reports and allowing serving integration examples. The `review-start` gulp command combinese those into one command.
+General gulp commands include separate commands for serving the codebase on a built in webserver, creating code coverage reports and allowing serving integration examples. The `review-start` gulp command combines those into one command.
 
 - Run `gulp review-start`, adding the host parameter `gulp review-start --host=0.0.0.0` will bind to all IPs on the machine
     - A page will open which provides a hub for common reviewer tools.
@@ -29,6 +29,7 @@ General gulp commands include separate commands for serving the codebase on a bu
 - Make sure the code is not setting cookies or localstorage directly -- it must use the `StorageManager`.
 - Review for obvious errors or bad coding practice / use best judgement here.
 - Don't allow needless code duplication with other js files; require both files import common code. Do not allow commits designed to fool the code duplication checker.
+- Module filenames should match module codes. Exceptions in https://github.com/prebid/Prebid.js/blob/master/metadata/overrides.mjs should almost never be needed.
 - If the change is a new feature / change to core prebid.js - review the change with a Tech Lead on the project and make sure they agree with the nature of change.
 - If the change results in needing updates to docs (such as public API change, module interface etc), add a label for "needs docs" and inform the submitter they must submit a docs PR to update the appropriate area of Prebid.org **before the PR can merge**. Help them with finding where the docs are located on prebid.org if needed. 
 - If all above is good, add a `LGTM` comment and, if the change is in PBS-core or is an important module like the prebidServerBidAdapter, request 1 additional core member to review.
@@ -48,6 +49,7 @@ Follow steps above for general review process. In addition, please verify the fo
     - The bidder code should be unique for the first 6 characters
     - Reserved words that cannot be used as bidder names: all, context, data, general, prebid, and skadn
 - Verify that bidder has submitted valid bid params and that bids are being received.
+- Verify filenames are correct, eg bidderCode must match {{biddermodule}}BidAdapter
 - Verify that bidder is not manipulating the prebid.js auction in any way or doing things that go against the principles of the project. If unsure check with the Tech Lead.
 - Verify that code re-use is being done properly and that changes introduced by a bidder don't impact other bidders.
 - If the adapter being submitted is an alias type, check with the bidder contact that is being aliased to make sure it's allowed.
@@ -75,7 +77,7 @@ Follow steps above for general review process. In addition, please verify the fo
     - If their bidder doesn't work well with safeframed creatives, add `safeframes_ok: false`. This will alert publishers to not use safeframed creatives when creating the ad server entries for their bidder.
     - If they're setting a deal ID in some scenarios, add `bidder_supports_deals: true`
     - If they have an IAB Global Vendor List ID, add `gvl_id: ID`. There's no default.
-- After a new adapter is approved, let the submitter know they may open a PR in the [headerbid-expert repository](https://github.com/prebid/headerbid-expert) to have their adapter recognized by the [Headerbid Expert extension](https://chrome.google.com/webstore/detail/headerbid-expert/cgfkddgbnfplidghapbbnngaogeldmop). The PR should be to the [bidder patterns file](https://github.com/prebid/headerbid-expert/blob/master/bidderPatterns.js), adding an entry with their adapter's name and the url the adapter uses to send and receive bid responses.
+
 
 ### Reviewing a New or Updated Analytics Adapter
 
@@ -143,7 +145,7 @@ The debugging module cannot import from core in the same way that other modules
 Each week, Prebid Org assigns one person to keep an eye on incoming issues and PRs. Every Monday morning a reminder is sent to the prebid-js slack channel with a link to the spreadsheet. If you're on rotation, please check that list each Monday to see if you're on-duty.
 
 When on-duty:
-- Review issues and PRs at least once per weekday for new items. Encourage a 48 "SLA" on PRs/issues assigned. Aim for touchpoint once every 48/hours. 
+- Review issues and PRs at least once per weekday for new items. Encourage a 48 "SLA" on PRs/issues assigned. Aim for touchpoint once every 48 hours. 
 - For PRs: assign PRs to individuals on the **PR review list**. Try to be equitable -- not all PRs are created equally. Use the "Assigned" field and add the "Needs Review" label.
 - For Issues: try to address questions and troubleshooting requests on your own, assigning them to others as needed. Please add labels as appropriate (I.E. bug, question, backlog etc).
 - Issues that are questions or troubleshooting requests may be closed if the originator doesn't respond within a week to requests for confirmation or details.
 
@@ -380,7 +380,7 @@ For instructions on writing tests for Prebid.js, see [Testing Prebid.js](https:/
 
 ### Supported Browsers
 
-Prebid.js is supported on IE11 and modern browsers until 5.x. 6.x+ transpiles to target >0.25%; not dead; not Opera Mini; not IE11.
+Prebid.js is supported on IE11 and modern browsers until 5.x. 6.x+ transpiles to target >0.25%; not dead. 11.21+ removes not dead and adds not ios_saf 11.
 
 ### Governance
 Review our governance model [here](https://github.com/prebid/Prebid.js/tree/master/governance.md).
 
@@ -114,7 +114,10 @@ module.exports = [
       '@stylistic/comma-dangle': 'off',
       '@stylistic/semi': ['error', 'always'],
       'no-undef': 2,
+      'no-constant-binary-expression': 'error',
+      'prebid/no-redundant-validated-condition': 'error',
       'no-console': 'error',
+      'prebid/no-extra-function-args': 'error',
       'space-before-function-paren': 'off',
       '@stylistic/space-before-function-paren': 'off',
       'import/no-unresolved': 'error',
@@ -124,6 +127,7 @@ module.exports = [
       'import/no-named-as-default': 'warn',
       'import/no-named-as-default-member': 'warn',
       'import/no-duplicates': 'warn',
+      'prebid/no-implicit-operand-conversion': 'error',
       'no-restricted-syntax': [
         'error',
         {
@@ -283,7 +287,6 @@ module.exports = [
       'chai-friendly/no-unused-expressions': 'error',
       // tests were not subject to many rules and they are now a nightmare. rules below this line should be removed over time
       'no-undef': 'off',
-      'no-unused-vars': 'off',
       'no-useless-escape': 'off',
       'no-return-assign': 'off',
       'camelcase': 'off'
 
@@ -10,6 +10,8 @@ const _ = require('lodash');
 const fs = require('fs');
 const filter = import('gulp-filter');
 const {buildOptions} = require('./plugins/buildOptions.js');
+const { toModulePath }  = require('./plugins/utils.js');
+
 
 function getDefaults({distUrlBase = null, disableFeatures = null, dev = false}) {
   if (dev && distUrlBase == null) {
@@ -128,7 +130,7 @@ const generatePublicModules = _.memoize(
           .pipe(filter(publicVersionDoesNotExist))
           .pipe(tap((file) => {
             const {modulePath, publicPath} = getNames(file);
-            file.contents = Buffer.from(template({modulePath}));
+            file.contents = Buffer.from(template({modulePath: toModulePath(modulePath)}));
             file.path = publicPath;
           }))
           .pipe(gulp.dest(publicDir))
@@ -148,7 +150,7 @@ function generateTypeSummary(folder, dest, ignore = dest) {
       if (!fs.existsSync(destDir)) {
         fs.mkdirSync(destDir, {recursive: true});
       }
-      fs.writeFile(dest, template({files}), done);
+      fs.writeFile(dest, template({files: files.map(toModulePath)}), done);
     })
   }
 }
 
@@ -1,9 +1,8 @@
-// this will have all of a copy of the normal fs methods as well
-const fs = require('fs-extra');
+const fs = require('fs');
 const path = require('path');
 const argv = require('yargs').argv;
 const MANIFEST = 'package.json';
-const through = require('through2');
+const { Transform } = require('node:stream');
 const _ = require('lodash');
 const PluginError = require('plugin-error');
 const execaCmd = require('execa');
@@ -129,7 +128,7 @@ module.exports = {
     }, internalModules));
   }),
   getMetadataEntry(moduleName) {
-    if (fs.pathExistsSync(`./metadata/modules/${moduleName}.json`)) {
+    if (fs.existsSync(`./metadata/modules/${moduleName}.json`)) {
       return `${moduleName}.metadata`;
     } else {
       return null;
@@ -174,10 +173,13 @@ module.exports = {
 
   nameModules: function(externalModules) {
     var modules = this.getModules(externalModules);
-    return through.obj(function(file, enc, done) {
-      file.named = modules[file.path] ? modules[file.path] : 'prebid';
-      this.push(file);
-      done();
+    return new Transform({
+      objectMode: true,
+      transform(file, enc, done) {
+        file.named = modules[file.path] ? modules[file.path] : 'prebid';
+        this.push(file);
+        done();
+      }
     })
   },
 
 
@@ -5,7 +5,8 @@ var _ = require('lodash');
 var argv = require('yargs').argv;
 var gulp = require('gulp');
 var PluginError = require('plugin-error');
-var fancyLog = require('fancy-log');
+// gulplog available transitively via gulp-cli
+var log = require('gulplog');
 var connect = require('gulp-connect');
 var webpack = require('webpack');
 var webpackStream = require('webpack-stream');
@@ -17,7 +18,7 @@ const execaTask = helpers.execaTask;
 var concat = require('gulp-concat');
 var replace = require('gulp-replace');
 const execaCmd = require('execa');
-var through = require('through2');
+const { Transform, PassThrough } = require('node:stream');
 var fs = require('fs');
 var jsEscape = require('gulp-js-escape');
 const path = require('path');
@@ -179,11 +180,14 @@ function nodeBundle(modules, dev = false) {
       .on('error', (err) => {
         reject(err);
       })
-      .pipe(through.obj(function (file, enc, done) {
-        if (file.path.endsWith('.js')) {
-          resolve(file.contents.toString(enc));
+      .pipe(new Transform({
+        objectMode: true,
+        transform(file, enc, done) {
+          if (file.path.endsWith('.js')) {
+            resolve(file.contents.toString(enc));
+          }
+          done();
         }
-        done();
       }));
   });
 }
@@ -211,7 +215,7 @@ function wrapWithHeaderAndFooter(dev, modules, sourcemaps = false) {
   // NOTE: gulp-header, gulp-footer & gulp-wrap do not play nice with source maps.
   // gulp-concat does; for that reason we are prepending and appending the source stream with "fake" header & footer files.
   return function wrap(stream) {
-    const wrapped = through.obj();
+    const wrapped = new PassThrough({ objectMode: true });
     const placeholder = '$$PREBID_SOURCE$$';
     const tpl = _.template(fs.readFileSync('./bundle-template.txt'))({
       prebid,
@@ -241,7 +245,7 @@ function wrapWithHeaderAndFooter(dev, modules, sourcemaps = false) {
 }
 
 function disclosureSummary(modules, summaryFileName) {
-  const stream = through.obj();
+  const stream = new PassThrough({ objectMode: true });
   import('./libraries/storageDisclosure/summary.mjs').then(({getStorageDisclosureSummary}) => {
     const summary = getStorageDisclosureSummary(modules, (moduleName) => {
       const metadataPath = `./metadata/modules/${moduleName}.json`;
@@ -295,10 +299,10 @@ function bundle(dev, moduleArr) {
   }
   const disclosureFile = path.parse(outputFileName).name + '_disclosures.json';
 
-  fancyLog('Concatenating files:\n', entries);
-  fancyLog('Appending ' + prebid.globalVarName + '.processQueue();');
-  fancyLog('Generating bundle:', outputFileName);
-  fancyLog('Generating storage use disclosure summary:', disclosureFile);
+  log.info('Concatenating files:\n', entries);
+  log.info('Appending ' + prebid.globalVarName + '.processQueue();');
+  log.info('Generating bundle:', outputFileName);
+  log.info('Generating storage use disclosure summary:', disclosureFile);
 
   const wrap = wrapWithHeaderAndFooter(dev, modules, sm);
   const source = wrap(gulp.src(entries, {sourcemaps: sm}))
 
@@ -2,7 +2,7 @@
 // creative will be rendered, e.g. GAM delivering a SafeFrame
 
 // this code is autogenerated, also available in 'build/creative/creative.js'
-<script>(()=>{"use strict";const e="Prebid Event",n=(()=>{const e={frameBorder:0,scrolling:"no",marginHeight:0,marginWidth:0,topMargin:0,leftMargin:0,allowTransparency:"true"};return(n,t)=>{const r=n.createElement("iframe");return Object.entries(Object.assign({},t,e)).forEach(e=>{let[n,t]=e;return r.setAttribute(n,t)}),r}})();function t(e){return!!e.frames.__pb_locator__}window.pbRender=function(r){let o=r.parent;try{for(;o!==r.top&&!t(o);)o=o.parent;t(o)||(o=r.parent)}catch(e){}return function(t){let{adId:s,pubUrl:i,clickUrl:c}=t;const a=new URL(i,window.location).origin;function d(e,n,t){const r=new MessageChannel;r.port1.onmessage=u(t),o.postMessage(JSON.stringify(Object.assign({message:e,adId:s},n)),a,[r.port2])}function l(n){d(e,{event:"adRenderFailed",info:{reason:(null==n?void 0:n.reason)||"exception",message:null==n?void 0:n.message}}),(null==n?void 0:n.stack)&&console.error(n)}function u(e){return function(){try{return e.apply(this,arguments)}catch(e){l(e)}}}d("Prebid Request",{options:{clickUrl:c}},function(t){let o;try{o=JSON.parse(t.data)}catch(e){return}if("Prebid Response"===o.message&&o.adId===s){const t=n(r.document,{width:0,height:0,style:"display: none"});t.onload=u(function(){const s=t.contentWindow;s.Promise.resolve(s.render(o,{sendMessage:d,mkFrame:n},r)).then(()=>d(e,{event:"adRenderSucceeded"}),l)}),t.srcdoc="<script>".concat(o.renderer,"<\/script>"),r.document.body.appendChild(t)}})}}(window)})();</script>
+<script>(()=>{"use strict";const e="Prebid Event",n=(()=>{const e={frameBorder:0,scrolling:"no",marginHeight:0,marginWidth:0,topMargin:0,leftMargin:0,allowTransparency:"true"};return(n,t)=>{const r=n.createElement("iframe");return Object.entries(Object.assign({},t,e)).forEach(([e,n])=>r.setAttribute(e,n)),r}})();function t(e){return!!e.frames.__pb_locator__}window.pbRender=function(r){let o=r.parent;try{for(;o!==r.top&&!t(o);)o=o.parent;t(o)||(o=r.parent)}catch(e){}return function({adId:t,pubUrl:s,clickUrl:i}){const a=new URL(s,window.location).origin;function c(e,n,r){const s=new MessageChannel;s.port1.onmessage=l(r),o.postMessage(JSON.stringify(Object.assign({message:e,adId:t},n)),a,[s.port2])}function d(n){c(e,{event:"adRenderFailed",info:{reason:n?.reason||"exception",message:n?.message}}),n?.stack&&console.error(n)}function l(e){return function(){try{return e.apply(this,arguments)}catch(e){d(e)}}}c("Prebid Request",{options:{clickUrl:i}},function(o){let s;try{s=JSON.parse(o.data)}catch(e){return}if("Prebid Response"===s.message&&s.adId===t){const t=n(r.document,{width:0,height:0,style:"display: none"});t.onload=l(function(){const o=t.contentWindow;o.Promise.resolve(o.render(s,{sendMessage:c,mkFrame:n},r)).then(()=>c(e,{event:"adRenderSucceeded"}),d)}),t.srcdoc=`<script>${s.renderer}<\/script>`,r.document.body.appendChild(t)}})}}(window)})();</script>
 
 <script>
     pbRender({
 
@@ -5,11 +5,10 @@ export const SUPPORTED_TYPES = ["html5", "cookie"];
 export const WITH_IIQ = "A";
 export const WITHOUT_IIQ = "B";
 export const DEFAULT_PERCENTAGE = 95;
-export const BLACK_LIST = "L";
 export const CLIENT_HINTS_KEY = "_iiq_ch";
 export const EMPTY = "EMPTY";
 export const GVLID = "1323";
-export const VERSION = 0.36;
+export const VERSION = 0.37;
 export const PREBID = "pbjs";
 export const HOURS_24 = 86400000;
 export const HOURS_72 = HOURS_24 * 3;
 
@@ -7,6 +7,7 @@ export const mnetGlobals = {
   errorQueue: [], // Queue for storing errors,
   eventQueue: null,
   refererInfo: null,
+  initialized: false,
 };
 
 export const LOGGING_DELAY = 500;