Auth.py missing; wrong import for SpotifyOAuth

[Wattseheck]

Describe the bug
Auth.py does not install when installing mycroft-spotify. When running Auth.py SpotifyOAuth is loaded from the wrong package and thus fails.

To Reproduce
Steps to reproduce the behavior:

1. Try to run Auth.py
2. It will fail because it cannot "from spotipy import SpotifyOAuth"

Expected behavior
Importing SpotifyOAuth

Solution

1. SCP Auth.py manually into /opt/mycroft/skills/mycroft-spotify.forslund/
2. Change "from spotipy import SpotifyOAuth" to "from spotipy.oauth2 import SpotifyOAuth"

Environment (please complete the following information):

• Device type: Ras Pi 3
• OS: Picroft
• Mycroft-core version: Don't know

Additional context
I am sorry. This is literally my first time on GitHub and I am no developer or have any experience. Bear with me if anything is unconventional.

[forslund]

Hi, thanks for reporting :)

A couple of questions

1. How did you install this update?

Just to verify did you run

source venv-activate.sh

from the mycroft-core folder?

Can you please run mycroft-pip show spotipy to verify that the msm install upgraded to the 2.17.1 version.

Also welcome to github, glad to have you here providing feedback and helping to improve the skill!

[Wattseheck]

Hi,
I installed the spotify skill using voice. Then I installed the raspotify as in the instruction of your readme. Then I used source venv-activate.sh from the mycroft-core folder.
mycroft-pip show spotipy actually shows that I am running the version 2.4.4. Here it says https://pypi.org/project/spotipy/ latest version is 2.18. I am confused. Thanks for you help

[forslund]

Ok, the spotify skill version hasn't been updated in mycroft-skills store so the latest changes for the manual authentication hasn't been added to that version.

Try asking mycroft to

install the beta version of the spotify skill

which should update the skill to the latest version and update the requirements along with it. (can be some issues though since you've manually added files...).

Currently I think both the __init__.py and spotify.py in the skill folder have old code making it hard to run using the generated auth.

[Wattseheck]

Asking mycroft to install the beta version did not work as mycroft asked me which version I am referring to. I did not know the answer to this.
Then I tried the following:
Deinstall the skill, reinstall the skill. Copying init.py and auth.py into the folder, made sure they replaced the old ones and match the files on GitHub, changed the requirements.txt to specify spotipy 2.17.1. Run again.

First error: from spotipy import SpotifyOAuth - "cannot import name "SpotifyOAuth" from spotipy. So I went into auth.py and changed it to from spotipy.oauth2 import SpotifyOAuth. This removed the error but threw the next one:
auth.py line 45: token_info = am.validate_token(am.cache_handler.get_cached_token()). AttributeError: "SpotifyOAuth" object has no attribute "validate_token"

Since then I am clueless.

[Jean28518]

I had the same problem.

With .venv activated I typed: pip install spotipy --upgrade Then it worked for me.

[Wattseheck]

Hi, thanks this already helps a lot and brings me one step further. However, the auth then asks to "Enter the URL you were redirected to" I don't understand. I was redirected to nowhere. I entered localhost:8888 but why should this work. Also trying to connect to localhost:8888 does not work. Any idea what I am supposed to enter here?

[forslund]

spotipy should have opened up the browser or showed you a link to paste in the browser. The link would take you to spotify where you allow the application to connect to your account. Afterwards it would redirect you to a https://localhost:8888/[lots of letters and numbers] adress. That address should be pasted back into the auth script (the url contains the information needed by spotipy to create your token)

However if the beta update didn't succeed the rest of the skill won't be able to use the auth token the auth script generates.

@Jean28518 how did you update to the latest version? git pull or msm / voice?

[wieluk]

I have the same problem as Wattseheck ... I don't really understand the last part. I am doing this in a console via ssh so no browser will open up and also no link is shown in terminal.

[forslund]

Thanks for the feedback @wieluk, The lib should have show an url, and if this is missing for you there's a bug. I'll try to reproduce. is this picroft or other system?

[wieluk]

Thanks for your fast answer it is raspbian os 32bit with mycroft installed for linux

[jhthompson12]

Nothing new to report, im getting the same issue as others when running auth.py. Where things seem to go well until I am prompted to "Enter the URL you were redirected to".

From other comments it seems like the expectation is that, at this point, auth.py is supposed to open a browser window. Has anyone figured out a way to make this work / get the necessary data via an SSH connection to the picroft?

Thanks you! Im very excited to get this working :)

[forslund]

I just pushed a change to enforce showing the link in all cases. let me know if this helps.

[wieluk]

Thanks for the fast change. But now I get this after entering client id and secret.

Traceback (most recent call last): File "/opt/mycroft/skills/mycroft-spotify.forslund/auth.py", line 44, in <modu le> open_browser=False) TypeError: __init__() got an unexpected keyword argument 'open_browser'

I am using this "from spotipy.oauth2 import SpotifyOAuth" suggested by wattseheck instead of the one in your auth.py file because with yours i get this Error ImportError: cannot import name 'SpotifyOAuth' from 'spotipy'

[forslund]

Hmm, could you check the version of spotipy you're using? mycroft-pip show spotipy if it's not 2.17.1 try running mycroft-pip install -r /opt/mycroft/skills/mycroft-spotify.forslund/requirements.txt

(If you've updated with a git pull the version may still be the older one)