From 415807c66347a4d55bc19b1f46014269fbd2d345 Mon Sep 17 00:00:00 2001 From: Ademola Fadumo <48495111+demolaf@users.noreply.github.com> Date: Wed, 23 Sep 2026 09:59:29 +0100 Subject: [PATCH] test(e2e): await settle instead of a single pump in list view tests The Firestore "custom error handler" and Database "ignore errors" tests awaited the stream's first event, then pumped a single frame before asserting. A platform-channel callback can land a frame late when the emulator is slow on the Android emulator runner, so the finder saw nothing and the android e2e job failed intermittently. pumpAndSettle matches what the neighbouring database error-handler test already does, and both end states are static (a Text, an empty ListView) so it settles rather than spinning on the progress indicator. --- .../firebase_ui_database/database_list_view_test.dart | 2 +- .../firebase_ui_firestore/firestore_list_view_test.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/integration_test/firebase_ui_database/database_list_view_test.dart b/tests/integration_test/firebase_ui_database/database_list_view_test.dart index 1ed5a37f..7256db26 100644 --- a/tests/integration_test/firebase_ui_database/database_list_view_test.dart +++ b/tests/integration_test/firebase_ui_database/database_list_view_test.dart @@ -137,7 +137,7 @@ void main() { await ref.onValue.first.then((value) {}, onError: (_) {}); - await tester.pump(); + await tester.pumpAndSettle(); expect(find.byType(ListView), findsOneWidget); }, diff --git a/tests/integration_test/firebase_ui_firestore/firestore_list_view_test.dart b/tests/integration_test/firebase_ui_firestore/firestore_list_view_test.dart index e55f18ce..4c424144 100644 --- a/tests/integration_test/firebase_ui_firestore/firestore_list_view_test.dart +++ b/tests/integration_test/firebase_ui_firestore/firestore_list_view_test.dart @@ -40,7 +40,7 @@ void main() { expect(find.byType(ListView), findsNothing); await collection.snapshots().first.then((_) {}, onError: (_) {}); - await tester.pump(); + await tester.pumpAndSettle(); verifyZeroInteractions(builderSpy);