Skip to content

Commit 9f4e249

Browse files
committed
Removes unnecessary mkdir from tests
1 parent 88a7c07 commit 9f4e249

2 files changed

Lines changed: 4 additions & 10 deletions

File tree

src/handler/handlerargstest.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,9 @@ void handlerargstest()
3232
// Get file for example config
3333
std::string configFile = "examples/config/pushpin.conf";
3434

35-
// Make directory for the log file
36-
QDir().mkdir("log");
37-
3835
ffi::HandlerCliArgs argsFfi = {
3936
const_cast<char*>(configFile.c_str()), // config_file
40-
const_cast<char*>("log/handler-log.txt"), // log_file
37+
const_cast<char*>("handler-log.txt"), // log_file
4138
3, // log_level
4239
const_cast<char*>("ipc:prefix"), // ipc_prefix
4340
81 // port_offset
@@ -46,7 +43,7 @@ void handlerargstest()
4643
// Verify HandlerArgsData parsing
4744
HandlerArgsData args(&argsFfi);
4845
TEST_ASSERT_EQ(args.configFile, QString("examples/config/pushpin.conf"));
49-
TEST_ASSERT_EQ(args.logFile, QString("log/handler-log.txt"));
46+
TEST_ASSERT_EQ(args.logFile, QString("handler-log.txt"));
5047
TEST_ASSERT_EQ(args.logLevel, 3);
5148
TEST_ASSERT_EQ(args.ipcPrefix, QString("ipc:prefix"));
5249
TEST_ASSERT_EQ(args.portOffset, 81);

src/proxy/proxyargstest.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,14 @@
3333
// Get file for example config
3434
std::string configFile = "examples/config/pushpin.conf";
3535

36-
// Make directory for the log file
37-
QDir().mkdir("log");
38-
3936
// Create test routes array
4037
const char* route1 = "route1";
4138
const char* route2 = "route2";
4239
const char* routes[] = { route1, route2 };
4340

4441
ffi::ProxyCliArgs argsFfi = {
4542
const_cast<char*>(configFile.c_str()), // config_file
46-
const_cast<char*>("log/proxy-log.txt"), // log_file
43+
const_cast<char*>("proxy-log.txt"), // log_file
4744
3, // log_level
4845
const_cast<char*>("ipc:prefix"), // ipc_prefix
4946
const_cast<char**>(routes), // routes
@@ -54,7 +51,7 @@
5451
// Verify ProxyArgsData parsing
5552
ProxyArgsData args(&argsFfi);
5653
TEST_ASSERT_EQ(args.configFile, QString("examples/config/pushpin.conf"));
57-
TEST_ASSERT_EQ(args.logFile, QString("log/proxy-log.txt"));
54+
TEST_ASSERT_EQ(args.logFile, QString("proxy-log.txt"));
5855
TEST_ASSERT_EQ(args.logLevel, 3);
5956
TEST_ASSERT_EQ(args.ipcPrefix, QString("ipc:prefix"));
6057
TEST_ASSERT_EQ(args.routeLines, QStringList({"route1", "route2"}));

0 commit comments

Comments
 (0)