From fc844ab1db4e9d2dcb1d1562b467808bf5ec965f Mon Sep 17 00:00:00 2001 From: ahmedsadid Date: Mon, 22 Jun 2026 03:01:06 -0400 Subject: [PATCH] Fix #1701: allow numeric values for grid line properties --- .../__tests__/stylex-valid-styles-test.js | 14 ++++++++++++++ .../eslint-plugin/src/reference/cssProperties.js | 6 +++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js b/packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js index 27f4cefbb..bc5a293a4 100644 --- a/packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js +++ b/packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js @@ -22,6 +22,20 @@ const eslintTester = new ESLintTester({ eslintTester.run('stylex-valid-styles', rule.default, { valid: [ + // issue #1701 — numeric values are valid for grid line properties + ` + import * as stylex from '@stylexjs/stylex'; + const styles = stylex.create({ + foo: { + gridColumn: 1, + gridColumnStart: 1, + gridColumnEnd: 3, + gridRow: 2, + gridRowStart: -1, + gridRowEnd: 4, + } + }); + `, // test for local static variables ` import * as stylex from '@stylexjs/stylex'; diff --git a/packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js b/packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js index 29aaff2ed..1a60332d7 100644 --- a/packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js +++ b/packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js @@ -329,7 +329,11 @@ const absoluteSize: RuleCheck = makeUnionRule( makeLiteralRule('xx-large'), ); const fontFamily: RuleCheck = isString; -const gridLine: RuleCheck = makeUnionRule(makeLiteralRule('auto'), isString); +const gridLine: RuleCheck = makeUnionRule( + makeLiteralRule('auto'), + isString, + isNumber, +); const gridTemplate: RuleCheck = makeUnionRule( makeLiteralRule('none'), makeLiteralRule('subgrid'),