-
Notifications
You must be signed in to change notification settings - Fork 77
DVD file overlay support #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9e9a0f0
DVD file overlay support
PJB3005 675bb40
Comments and a guard
PJB3005 3efa924
Merge branch 'main' into 26-05-15-dvd-overlay
PJB3005 f411b6e
EntryNum handling rewrite
PJB3005 1c30c1a
Merge remote-tracking branch 'upstream/main' into 26-05-15-dvd-overlay
PJB3005 6e76b81
Split FST logic into another file in dvd lib
PJB3005 8c5c16e
Fix overlay userdata 0
PJB3005 e2254ae
Make entryNum only validated if not replacing file
PJB3005 cf9cdaf
Make FST rebuilds thread safe with concurrent readers
PJB3005 dfd3f60
Doc updates
PJB3005 f05da27
Remove debug logs
PJB3005 3885c01
Merge branch 'main' into 26-05-15-dvd-overlay
encounter eaffd46
Aurora-allocated entry nums & dir support
encounter 4f28b81
Add warning for resetting cwd
encounter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/AuroraNodProvider.cmake) | ||
|
|
||
| add_library(aurora_dvd STATIC lib/dolphin/dvd/dvd.cpp) | ||
| add_library(aurora_dvd STATIC lib/dolphin/dvd/dvd.cpp lib/dolphin/dvd/dvd.hpp lib/dolphin/dvd/fst.cpp) | ||
| add_library(aurora::dvd ALIAS aurora_dvd) | ||
| set_target_properties(aurora_dvd PROPERTIES FOLDER "aurora") | ||
|
|
||
| target_compile_definitions(aurora_dvd PUBLIC AURORA TARGET_PC) | ||
| target_include_directories(aurora_dvd PUBLIC include) | ||
| target_link_libraries(aurora_dvd PUBLIC nod::nod ${AURORA_SDL3_TARGET}) | ||
| target_link_libraries(aurora_dvd PRIVATE fmt::fmt) | ||
| target_link_libraries(aurora_dvd PUBLIC nod::nod fmt::fmt ${AURORA_SDL3_TARGET}) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make this dependency public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fixes an import issue with system fmt headers