Improve dev experience for new contributors

[xushidev]

@eljojo
Pinging and creating a new issue here because i don't want to clog the looking for translation channel.

Hey, I have finished the translation on my fork, but it seems that when i run the following:

# install dependencies (works)
npm install 

# build the project (it fails here)
make build

it gives me this error:

Compiling TypeScript...
esbuild internal/html/assets/src/shared.ts --bundle --format=iife --global-name=_shared --outfile=internal/html/assets/shared.js --target=es2020
make: esbuild: No such file or directory
make: *** [Makefile:28: ts] Error 127

I think it is either me being stupid, but no idea.
It also doesn't work with running make test, but else the translation is finished. (Should i directly make a pull request?)

[eljojo]

Hi @xushidev, thanks for opening this issue.

It seems that make can't find esbuild, the fix for this should be to change the makefile to use the esbuild installed by package.json. On my computer this works because I am using nix, so I get the esbuild that comes with it:

❯ nix develop -c zsh
❯ esbuild --version
0.25.5
❯ which esbuild
/nix/store/k3agrn69vmp4721q3rzw4vb1im155hph-esbuild-0.25.5/bin/esbuild

how to unblock you

just make the PR anyways, if issues come up CI will show.

let's leave this issue open, we should fix the Makefile so it uses esbuild installed by package.json. as a workaround, I imagine you can change the parts that say esbuild for npx esbuild?

[xushidev]

Hey, works now, I will make the pull request then 👍
Might be a good idea to add this part for future people xD
Either way thank you very much!

[eljojo]

yeah I think make test should just work so people don't have to patch things, I'll try fixing it!

[xushidev]

I will close this issue then!
Also made the pull request, thank you for the help!

[eljojo]

let's leave this open to keep track of fixing the makefile, the issue with CI is bugging me too

https://github.com/eljojo/rememory/actions/runs/23154372937/job/67264896778?pr=123#step:4:274

they're both kind of connected

[xushidev]

@eljojo
Hey, after review for the pull request #123 i have found a few typos i have made as feedbacks from friends, could you please change the following:

internal/translations/home/it.json

- "home_intro": "Files protetti da persone che ti fidi, conservati qui per quando servono.",
+ "home_intro": "File protetti da persone che ti fidi, conservati qui per quando servono.",

internal/translations/index/it.json
Line 5
Line 45

- "summary_2": "Ogni persona ottiene un pacchetto con tutto quello che serve. Per recuperare apri un file nel browser — <strong><span title=\"Internet non è richiesto. Archivi con blocco a tempo richiedono la connessione internet per verificare la data.\">offline*</span></strong>, nessun accounts, nessun servers. Se questo sito scompare, <strong>il recupero funziona lo stesso</strong>.",
+ "summary_2": "Ogni persona ottiene un pacchetto con tutto quello che serve. Per recuperare apri un file nel browser — <strong><span title=\"Internet non è richiesto. Archivi con blocco a tempo richiedono la connessione internet per verificare la data.\">offline*</span></strong>, nessun account, nessun server. Se questo sito scompare, <strong>il recupero funziona lo stesso</strong>.",
- "whatis_isnt_1": "Un servizion o un'azienda",
+ "whatis_isnt_1": "Un servizio o un'azienda",

internal/translations/maker/it.json
Line 22
Line 52
Line 54

- "files_drop": "Trascina & rilascia una cartella qui, oppure clicca per selezionare i file",
+ "files_drop": "Trascina e rilascia una cartella qui, oppure clicca per selezionare i file",
- "language_label": "Linguaggio nel pacchetto",
+ "language_label": "Lingua del pacchetto",
- "custom_language_label": "Cambia linguaggio",
+ "custom_language_label": "Cambia lingua",

Sorry if i'm asking it here, but i don't want to open a new pull request, as such are very small changes rather than big ones.

[eljojo]

@xushidev please open a new PR and I'll merge it 👍