Skip to content

ColumnView: fix some critical messages#2789

Open
jeremypw wants to merge 6 commits into
mainfrom
jeremypw/pluginmanager/fix-critical
Open

ColumnView: fix some critical messages#2789
jeremypw wants to merge 6 commits into
mainfrom
jeremypw/pluginmanager/fix-critical

Conversation

@jeremypw

@jeremypw jeremypw commented May 3, 2026

Copy link
Copy Markdown
Contributor
  • Wait to ensure slot container window is not null when activating a slot
  • Do not unnecessarily truncate miller view on closing (which triggers active signal and causes an error messages)

Not sure if this is related to #2788 or not but the log supplied there indicated one of the critical messages this PR fixes.

@jeremypw jeremypw added this to the 7.3.2 milestone May 4, 2026
@jeremypw jeremypw marked this pull request as ready for review May 8, 2026 16:27
@jeremypw jeremypw mentioned this pull request May 29, 2026
8 tasks
@ryonakano

Copy link
Copy Markdown
Member

Is there any reason why it's not content_type != null but _content_type != null?

I'm not familiar with the code here, but this looks a bit strange for me:

        if (content_type != UNKNOWN_CONTENT && _content_type != null) {

@jeremypw

jeremypw commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

@ryonakano I think it was because after referencing the property content_type once it is quicker to reference the backing variable _content_type as we know it is up to date. If the first reference returned null we don't need to try to evaluate the content_type again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants