The packaging pipeline for fleet-server is pretty fragile as changes do not run on PRs.
We need a to be able to trigger packaging workflows from a PR in order to test any changes.
For example, our pipeline only triggers the packaging pipeline when it's not a PR:
|
- trigger: "fleet-server-package-mbp" |
|
label: ":esbuild: Downstream - Package" |
|
key: "downstream-package" |
|
if: "build.env('BUILDKITE_PULL_REQUEST') == 'false' && build.env('BUILDKITE_TAG') == '' && build.env('BUILDKITE_BRANCH') != ''" |
|
build: |
|
branch: "${BUILDKITE_BRANCH}" |
|
commit: "${BUILDKITE_COMMIT}" |
|
depends_on: |
Additionally, some parts of our pipelines only trigger on the main branch or do extra work if the branch is main (for example package.sh explicitly checks if the branch is set to main) - we should provide a way to ensure these paths are able to be tested manually before they reach main.
We would likely need to add a manual trigger - similar to how performance tests are invoked - in order to mimic the "main" packaging workflow
The packaging pipeline for fleet-server is pretty fragile as changes do not run on PRs.
We need a to be able to trigger packaging workflows from a PR in order to test any changes.
For example, our pipeline only triggers the packaging pipeline when it's not a PR:
fleet-server/.buildkite/pipeline.yml
Lines 359 to 366 in 37dd546
Additionally, some parts of our pipelines only trigger on the main branch or do extra work if the branch is main (for example
package.shexplicitly checks if the branch is set to main) - we should provide a way to ensure these paths are able to be tested manually before they reach main.We would likely need to add a manual trigger - similar to how performance tests are invoked - in order to mimic the "main" packaging workflow