Merge pull request #75 from bobur-khay/chore/add-linting-rules_#46

Linting Rules

Author: egekorkan

.eslintrc.json

@@ -5,9 +5,42 @@
         "node": true,
         "jest": true
     },
+    "parser": "@typescript-eslint/parser",
     "parserOptions": {
         "ecmaVersion": 8
     },
-    "extends": ["eslint:recommended", "prettier"],
-    "ignorePatterns": ["dist", "node_modules", "bin"]
+    "plugins": ["@typescript-eslint", "unused-imports"],
+    "extends": ["eslint:recommended", "prettier", "plugin:@typescript-eslint/recommended"],
+    "ignorePatterns": ["dist", "node_modules", "bin"],
+    "rules": {
+        // default rules are overriden by the plugins
+        "no-unused-vars": "off",
+        "no-use-before-define": "off",
+        "@typescript-eslint/no-unused-vars": "off",
+
+        "guard-for-in": "error",
+        "@typescript-eslint/no-use-before-define": [
+            "error",
+            {
+                "functions": false,
+                "classes": true,
+                "variables": true,
+                "enums": true,
+                "typedefs": true
+            }
+        ],
+        "@typescript-eslint/no-require-imports": "off",
+        "unused-imports/no-unused-imports": "error",
+        "unused-imports/no-unused-vars": [
+            "warn",
+            {
+                "vars": "all",
+                "varsIgnorePattern": "^_",
+                "args": "after-used",
+                "argsIgnorePattern": "^_",
+                "caughtErrors": "all",
+                "caughtErrorsIgnorePattern": "^_"
+            }
+        ]
+    }
 }

.github/workflows/eslint.yml

@@ -28,11 +28,8 @@ jobs:
             - name: Checkout code
               uses: actions/checkout@v4
 
-            - name: Install ESLint
-              run: |
-                  npm install eslint@8.10.0
-                  npm install @microsoft/eslint-formatter-sarif@2.1.7
-                  npm install eslint-config-prettier@8.8.0
+            - name: Install dependencies
+              run: npm ci
 
             - name: Run ESLint
               run: "npm run lint:sarif"

node/aas-aid/package-lock.json

@@ -34,15 +34,15 @@
         "@types/debug": "^4.1.12",
         "@types/mocha": "^9.0.0",
         "chai": "^4.3.4",
-        "mocha": "^9.2.2",
+        "mocha": "^10.8.2",
         "nyc": "^17.0.0",
         "ts-node": "^10.9.1",
         "typescript": "4.7.4"
     },
     "scripts": {
         "build": "tsc -b",
-        "test": "mocha --require ts-node/register --extension ts",
-        "test:coverage": "nyc --reporter=lcov mocha --require ts-node/register --extension ts"
+        "test": "mocha --node-option loader=ts-node/esm --require ts-node/register --extension ts",
+        "test:coverage": "nyc --reporter=lcov mocha --node-option loader=ts-node/esm --require ts-node/register --extension ts"
     },
     "bugs": {
         "url": "https://github.com/eclipse-thingweb/td-tools/issues"