refactor(lobster): deduplicate upstream_req_list via depset; tighten test assertion

- dependable_element.bzl: replace list.extend() accumulation with depset
  transitive merge so repeated ASR deps across multiple feature_requirements
  targets cannot produce duplicate {UPSTREAM_REQ_SOURCES} entries or duplicate
  lobster report inputs
- seooc_test.bzl: replace generic count assertion with explicit check that
  'asr_trlc.lobster' is present in the lobster report action inputs

Author: simon-d-bmw

bazel/rules/rules_score/private/dependable_element.bzl

@@ -1080,10 +1080,11 @@ def _dependable_element_index_impl(ctx):
 
     # Build the DE-level lobster report if feature and component traces exist
     feat_req_list = feat_req_lobster_depset.to_list()
-    upstream_req_list = []
+    upstream_req_depsets = []
     for req_target in ctx.attr.requirements:
         if FeatureRequirementsInfo in req_target:
-            upstream_req_list.extend(req_target[FeatureRequirementsInfo].upstream_srcs.to_list())
+            upstream_req_depsets.append(req_target[FeatureRequirementsInfo].upstream_srcs)
+    upstream_req_list = depset(transitive = upstream_req_depsets).to_list()
     comp_req_list = comp_req_lobster_depset.to_list()
     comp_test_list = comp_test_lobster_depset.to_list()
     comp_arch_list = comp_arch_lobster_depset.to_list()

bazel/rules/rules_score/test/seooc_test.bzl

@@ -388,12 +388,11 @@ def _de_lobster_config_includes_upstream_srcs_test_impl(ctx):
     input_basenames = [f.basename for f in lobster_report_action.inputs.to_list()]
     lobster_inputs = [n for n in input_basenames if n.endswith(".lobster")]
 
-    # Both the feature req and upstream ASR lobster files should appear as inputs
+    # The upstream ASR lobster file (from the asr_trlc fixture target) must be present
     asserts.true(
         env,
-        len(lobster_inputs) >= 2,
-        "Expected at least 2 .lobster file inputs to the lobster report action " +
-        "(feature req + upstream ASR); got: " + str(lobster_inputs),
+        "asr_trlc.lobster" in lobster_inputs,
+        "Expected 'asr_trlc.lobster' in lobster report action inputs; got: " + str(lobster_inputs),
     )
 
     return analysistest.end(env)