Skip to content

FilterEagerLoadingsExtension changes query even when eager loading is disabled #9853

Description

@usu

When eager loading is disabled for a specific operation, our own implementation of FilterEagerLoadingsExtension is still changing the query, which is unexpected and could potentially leads to less optimal queries.

Our implementation:
https://github.com/ecamp/ecamp3/blob/devel/api/src/Doctrine/Orm/Extension/FilterEagerLoadingsExtension.php#L36

Upstream implementation:
https://github.com/api-platform/core/blob/main/src/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php#L51

Verify if this was done on purpose and check if we can copy the few lines from upstream implementation without breaking anything else.

The new subresource operation introduced in #9849 would be a good test case.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions