feat: add RedisStore.Close and release the pool on PostgresStore.Close

eben-vranken · eben-vranken · commit 6ea679f02872 · 2026-06-02T16:37:22.000+02:00
diff --git a/pg/store.go b/pg/store.go
@@ -24,6 +24,7 @@ type PostgresStore struct {
 func (ims *PostgresStore) Close() {
 	ims.closeOnce.Do(func() {
 		close(ims.done)
+		ims.pool.Close()
 	})
 }
 
diff --git a/redis/store.go b/redis/store.go
@@ -62,6 +62,10 @@ type RedisStore struct {
 	retentionTTL time.Duration
 }
 
+func (rs *RedisStore) Close() error {
+	return rs.client.Close()
+}
+
 func (rs *RedisStore) Claim(ctx context.Context, key string, requestHash string, token string) (idempo.ClaimResult, error) {
 	result, err := rs.client.Eval(ctx, claimScript, []string{key}, requestHash, rs.lockTTL.Milliseconds(), token).Result()
 

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ type PostgresStore struct {`
`24`	`24`	`func (ims *PostgresStore) Close() {`
`25`	`25`	`ims.closeOnce.Do(func() {`
`26`	`26`	`close(ims.done)`
	`27`	`+ ims.pool.Close()`
`27`	`28`	`})`
`28`	`29`	`}`
`29`	`30`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,10 @@ type RedisStore struct {`
`62`	`62`	`retentionTTL time.Duration`
`63`	`63`	`}`
`64`	`64`
	`65`	`+func (rs *RedisStore) Close() error {`
	`66`	`+ return rs.client.Close()`
	`67`	`+}`
	`68`	`+`
`65`	`69`	`func (rs *RedisStore) Claim(ctx context.Context, key string, requestHash string, token string) (idempo.ClaimResult, error) {`
`66`	`70`	`result, err := rs.client.Eval(ctx, claimScript, []string{key}, requestHash, rs.lockTTL.Milliseconds(), token).Result()`
`67`	`71`