Skip to content

FitterWorker.stop() docstring describes removed thread-termination behavior #324

@rozyczko

Description

@rozyczko

Source: EasyReflectometryApp/Backends/Py/workers/fitter_worker.py:137-160 — DEEP_ANALYSIS.md §5 item 13

stop()'s docstring describes QThread.terminate() behaviour and refers to THREAD_TERMINATION_WARNING.md, but:

  • the method only sets a flag (no termination), and
  • that file does not exist in the repository.

The docstring documents code that was removed. Relatedly, analysis.py:448 still calls setTerminationEnabled(True) although nothing terminates.

Fix: Update the docstring to describe the flag-based stop; remove the stale setTerminationEnabled(True) call and the nonexistent-file reference.

Metadata

Metadata

Assignees

No one assigned

    Labels

    [priority] lowLow importance[scope] maintenanceCode/tooling cleanup, no feature or bugfix (major.minor.PATCH)
    No fields configured for issues without a type.

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions