Merge pull request #19 from dxfrontier/refactor/messages

Refactor/messages

Author: dragolea

.github/workflows/deployment.yml

@@ -21,21 +21,11 @@ jobs:
       - run: |
           echo The PR was merged.
 
-  # This will validate to see if the labels contains 'none' which means that if 'none' was found the release will not happen
-  check_valid_deploy:
-    name: Validate deploy conditions
-    needs: check_valid_merge
-    if: ${{ contains(github.event.pull_request.labels.*.name, 'deploy') }}
-    runs-on: ubuntu-latest
-    steps:
-      - run: |
-          echo The PR can continue to deploy the version.
-
     # This will start build of the project
   check_valid_build:
     name: Check build validity
     runs-on: ubuntu-latest
-    needs: [check_valid_deploy]
+    needs: check_valid_merge
     steps:
       - uses: actions/checkout@v4
       - run: npm install
@@ -60,25 +50,3 @@ jobs:
       - run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{secrets.NPM_ORG_TOKEN}}
-
-  publish-npm-github:
-    name: Publish to github npm - internal
-    needs: check_valid_build
-    env:
-      NPM_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      packages: write
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version: '20.x'
-          registry-url: 'https://npm.pkg.github.com'
-      - run: npm ci
-      - run: npm run build
-      - run: |
-          echo @dxfrontier:registry=https://npm.pkg.github.com/ > ~/.npmrc
-          echo "//npm.pkg.github.com/:_authToken=${NPM_TOKEN}" >> ~/.npmrc
-      - run: npm publish

.github/workflows/release.yml

@@ -131,6 +131,6 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
           title: CHANGELOG.md updated
           body: CHANGELOG.md updated with latest conventional commits.
-          labels: norelease, deploy
+          labels: norelease
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

lib/util/util.ts

@@ -11,15 +11,12 @@ export const util = {
   },
 
   createMessage(success: boolean, fileName: string) {
-    const status = success ? colors.green : colors.red;
+    const prefix = success ? colors.green('[SUCCESS]') : colors.red('[FAIL]');
+    const syncStatus = success ? 'successfully' : 'not successfully';
 
     return {
-      message: status(
-        `The version in ${fileName} has ${success ? '' : 'not '}been successfully synchronized with the main ${'package.json'} version.`,
-      ),
-      messageAll: status(
-        `All ${`*.${fileName}`} files have ${success ? '' : 'not '}been successfully synchronized with the main ${'package.json'} version.`,
-      ),
+      message: `${prefix} - The version in ${fileName} has been ${syncStatus} synchronized with the main package.json version.`,
+      messageAll: `${prefix} - All *.${fileName} files have been ${syncStatus} synchronized with the main package.json version.`,
     };
   },
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@dxfrontier/sync-mta-version",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "license": "MIT",
   "description": "The goal of sync-mta-version is to update the mta.yaml with the version from the package.json",
   "repository": {