feat(diagnostics): add installer log to diagnostics ZIP and pretty-print all JSON files

The NSIS post-install hook now writes rigstats-install.log to the app\ndata directory (%APPDATA%\\se.codeby.rigstats\\), capturing the selected\nLHM executable path and exit codes for the config copy and scheduled\ntask registration steps. The diagnostics ZIP includes this file as\ninstall.log so installer failures are visible in bug reports.\n\nAll JSON files in the ZIP are now pretty-printed: manifest.json was\nrewritten using serde_json::json!, hardware.json had -Compress removed\nfrom the PowerShell script, and lhm-data.json is re-parsed via a new\npretty_json() helper before writing. Files that were already using\nto_string_pretty are unchanged.\n\ndocs/architecture.md updated with install.log and displays.json entries\nin the diagnostics table, and setup.md updated to remove the outdated\nmanual Task Scheduler instructions for autostart.

Author: dvalfrid

build/installer.nsh

@@ -1,6 +1,11 @@
 !include "FileFunc.nsh"
 
 !macro NSIS_HOOK_POSTINSTALL
+  ; Open install log in the app data directory so it can be included in diagnostics.
+  CreateDirectory "$APPDATA\se.codeby.rigstats"
+  FileOpen $9 "$APPDATA\se.codeby.rigstats\rigstats-install.log" w
+  FileWrite $9 "[RIGStats post-install]$\r$\n"
+
   ; Prefer an existing LibreHardwareMonitor installation if present.
   ; Fallback to bundled LHM inside RigStats installation directory.
   StrCpy $0 "$INSTDIR\\lhm\\LibreHardwareMonitor.exe"
@@ -14,14 +19,21 @@
   IfFileExists "$LOCALAPPDATA\\Programs\\LibreHardwareMonitor\\LibreHardwareMonitor.exe" 0 +2
   StrCpy $0 "$LOCALAPPDATA\\Programs\\LibreHardwareMonitor\\LibreHardwareMonitor.exe"
 
+  FileWrite $9 "lhm_exe=$0$\r$\n"
+
   ; Apply default config to the selected LHM installation (existing or bundled).
   ; This enables the web server on port 8085 without manual setup.
-  IfFileExists "$INSTDIR\\lhm\\defaults\\LibreHardwareMonitor.config" 0 +9
+  IfFileExists "$INSTDIR\\lhm\\defaults\\LibreHardwareMonitor.config" 0 no_bundled_config
   ${GetParent} "$0" $1
   IfFileExists "$1\\LibreHardwareMonitor.config" 0 +3
   Delete "$1\\LibreHardwareMonitor.config.backup"
   Rename "$1\\LibreHardwareMonitor.config" "$1\\LibreHardwareMonitor.config.backup"
-  nsExec::ExecToLog 'cmd /C copy /Y "$INSTDIR\lhm\defaults\LibreHardwareMonitor.config" "$1\LibreHardwareMonitor.config"'
+  nsExec::ExecToStack 'cmd /C copy /Y "$INSTDIR\lhm\defaults\LibreHardwareMonitor.config" "$1\LibreHardwareMonitor.config"'
+  Pop $4
+  Pop $5
+  DetailPrint "LHM config copy: exit $4"
+  FileWrite $9 "config_copy_exit=$4$\r$\n"
+  no_bundled_config:
 
   ; Create or update scheduled task for LibreHardwareMonitor at any user logon.
   ; Uses PowerShell Register-ScheduledTask without -UserId so the trigger fires for
@@ -38,14 +50,21 @@
   FileWrite $3 "$$p = New-ScheduledTaskPrincipal -GroupId 'S-1-5-32-545' -RunLevel Highest$\r$\n"
   FileWrite $3 "Register-ScheduledTask -TaskName 'LibreHardwareMonitor' -Action $$a -Trigger $$t -Settings $$s -Principal $$p -Force$\r$\n"
   FileClose $3
-  nsExec::ExecToLog 'powershell -NoProfile -NonInteractive -ExecutionPolicy Bypass -File "$TEMP\create-lhm-task.ps1"'
+  nsExec::ExecToStack 'powershell -NoProfile -NonInteractive -ExecutionPolicy Bypass -File "$TEMP\create-lhm-task.ps1"'
+  Pop $4
+  Pop $5
+  DetailPrint "LHM task register: exit $4"
+  FileWrite $9 "lhm_task_register_exit=$4$\r$\n"
   Delete "$TEMP\create-lhm-task.ps1"
 
   ; Run LHM directly in the installer's admin context so PawnIO (kernel driver) is
   ; installed on first use. The user will see a PawnIO prompt and should click Yes.
   ; Using Exec (non-blocking) so the installer can finish while LHM initialises.
   DetailPrint "Starting LibreHardwareMonitor — click Yes if asked about PawnIO installation."
+  FileWrite $9 "lhm_started=1$\r$\n"
   Exec "$\"$0$\""
+
+  FileClose $9
 !macroend
 
 !macro NSIS_HOOK_POSTUNINSTALL

docs/architecture.md

@@ -75,7 +75,9 @@ It produces a self-contained ZIP for bug reports and sensor-support work.
 | `hardware.json` | `diag_collect_hardware()` — PowerShell `Get-CimInstance` | OS, CPU, GPU, board, RAM |
 | `sched-task.txt` | `diag_collect_tasks()` — `schtasks /Query /V` | Both LHM task names |
 | `environment.txt` | `diag_collect_environment()` — env vars + Windows registry | Arch, build, hostname |
+| `install.log` | `diag_collect_installer_log()` — reads `rigstats-install.log` from app data dir | Written by the NSIS installer; contains LHM exe path and task registration exit codes |
 | `sysinfo.json` | `diag_collect_sysinfo()` — reads shared `AppState` mutexes | CPU brand, RAM totals, mount points, interfaces |
+| `displays.json` | `diag_collect_displays()` — reads available monitors via Tauri | Each monitor's resolution, position, scale factor, fit score, and which one was selected for the current profile |
 
 ---
 

src-tauri/src/diagnostics.rs

@@ -11,6 +11,16 @@ use serde::Serialize;
 use std::io::Write;
 use std::time::{Duration, SystemTime, UNIX_EPOCH};
 
+// --- Helpers ---------------------------------------------------------------
+
+/// Re-parses a JSON string and returns it pretty-printed.
+/// Falls back to the original string if it isn't valid JSON.
+fn pretty_json(s: &str) -> String {
+  serde_json::from_str::<serde_json::Value>(s)
+    .and_then(|v| serde_json::to_string_pretty(&v))
+    .unwrap_or_else(|_| s.to_string())
+}
+
 // --- Data collection helpers -----------------------------------------------
 
 fn diag_collect_hardware() -> String {
@@ -31,7 +41,7 @@ fn diag_collect_hardware() -> String {
       "gpu=@($gpu|%{@{name=$_.Name;ramBytes=$_.AdapterRAM;driver=$_.DriverVersion}});",
       "board=@{csMfr=$cs.Manufacturer;csModel=$cs.Model;bbMfr=$bb.Manufacturer;bbProd=$bb.Product;cspName=$csp.Name;cspVer=$csp.Version};",
       "ram=@($mem|%{@{capBytes=$_.Capacity;speed=$_.Speed;configured=$_.ConfiguredClockSpeed;typeCode=$_.SMBIOSMemoryType;mfr=$_.Manufacturer;part=$_.PartNumber}})",
-      "}|ConvertTo-Json -Depth 4 -Compress",
+      "}|ConvertTo-Json -Depth 4",
       "}catch{'{ \"error\": \"collection failed\" }'}"
     );
     match run_hidden_command("powershell", &["-NoProfile", "-Command", script]) {
@@ -134,6 +144,11 @@ struct SysinfoSnapshot {
   ping_target: String,
 }
 
+fn diag_collect_installer_log(app: &tauri::AppHandle) -> Vec<u8> {
+  let path = debug_log_path(app).with_file_name("rigstats-install.log");
+  std::fs::read(path).unwrap_or_else(|_| b"(install log not found)".to_vec())
+}
+
 fn diag_collect_sysinfo(state: &AppState) -> String {
   let (cpu_brand, cpu_count, total_memory_mb, used_memory_mb) = {
     let system = state.system.lock().unwrap_or_else(|e| e.into_inner());
@@ -286,11 +301,11 @@ pub async fn collect_diagnostics(
     return Ok(None); // user cancelled
   };
 
-  let manifest = format!(
-    "{{\"collected_at_unix\":{},\"rigstats_version\":\"{}\"}}",
-    ts,
-    env!("CARGO_PKG_VERSION")
-  );
+  let manifest = serde_json::to_string_pretty(&serde_json::json!({
+    "collected_at_unix": ts,
+    "rigstats_version": env!("CARGO_PKG_VERSION"),
+  }))
+  .unwrap_or_default();
 
   let log_bytes = std::fs::read(debug_log_path(&app)).unwrap_or_else(|_| b"(log not found)".to_vec());
 
@@ -307,14 +322,15 @@ pub async fn collect_diagnostics(
     .send()
     .await
   {
-    Ok(resp) => resp.text().await.unwrap_or_else(|e| format!("{{\"error\":\"body: {}\"}}", e)),
+    Ok(resp) => pretty_json(&resp.text().await.unwrap_or_else(|e| format!("{{\"error\":\"body: {}\"}}", e))),
     Err(e) => format!("{{\"error\":\"request: {}\"}}", e),
   };
 
-  let hardware_json = diag_collect_hardware();
+  let hardware_json = pretty_json(&diag_collect_hardware());
   let tasks_txt = diag_collect_tasks();
   let env_txt = diag_collect_environment();
   let sysinfo_json = diag_collect_sysinfo(&state);
+  let install_log_bytes = diag_collect_installer_log(&app);
   let displays_json = {
     let profile = state.settings.lock().unwrap_or_else(|e| e.into_inner()).dashboard_profile.clone();
     diag_collect_displays(&app, &profile)
@@ -328,6 +344,7 @@ pub async fn collect_diagnostics(
   let entries: &[(&str, &[u8])] = &[
     ("manifest.json", manifest.as_bytes()),
     ("debug.log", &log_bytes),
+    ("install.log", &install_log_bytes),
     ("settings.json", settings_json.as_bytes()),
     ("lhm-data.json", lhm_json.as_bytes()),
     ("hardware.json", hardware_json.as_bytes()),