Thread safe dictionary

Fixed a rare crash that could occur when two combinations could generate two identical solutions (classic dictionaries don't handle that very well)

Author: dragitz

TFT Comp Creator 2/Form1.Designer.cs

@@ -1,6 +1,7 @@
 using Newtonsoft.Json.Linq;
 using System;
 using System.CodeDom.Compiler;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
@@ -301,9 +302,9 @@ public void Creation()
 
                 int size = Convert.ToInt32(min_comp_size.Value);
 
-                
 
-                Dictionary<List<string>, int> parallel_results = FindCombinations2(size, nodes, excluded_comp_champions, tempIncludeTrait, tempIncludeSpatula);
+
+                ConcurrentDictionary<List<string>, int> parallel_results = FindCombinations2(size, nodes, excluded_comp_champions, tempIncludeTrait, tempIncludeSpatula);
 
                 // Filter, sort, and take the top 10
                 var top10 = parallel_results
@@ -322,6 +323,7 @@ public void Creation()
                 }
             }
 
+            //Creation();
 
             Print("done");
 

TFT Comp Creator 2/Form1.cs

@@ -1,5 +1,6 @@
 using Newtonsoft.Json.Linq;
 using System;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
@@ -400,13 +401,14 @@ public static List<string> GetTopTraits(List<string> championList, int depthLeve
          */
 
 
-        public static Dictionary<List<string>, int> FindCombinations2(int CompSize, List<string> items, List<string> excluded_comp_champions, List<string> tempIncludeTrait, List<string> tempIncludeSpatula)
+        public static ConcurrentDictionary<List<string>, int> FindCombinations2(int CompSize, List<string> items, List<string> excluded_comp_champions, List<string> tempIncludeTrait, List<string> tempIncludeSpatula)
         {
             var combinations = GetCombs(items.Count(), CompSize);
 
             int Synergy = 0;
 
-            Dictionary<List<string>, int> parallel_results = new Dictionary<List<string>, int>();
+            // this new dictionary is thread safe, keep it or crash the whole program
+            ConcurrentDictionary<List<string>, int> parallel_results = new ConcurrentDictionary<List<string>, int>();
 
             CancellationTokenSource cts = new CancellationTokenSource();
             Parallel.ForEach(combinations, new ParallelOptions { CancellationToken = cts.Token }, combination =>
@@ -419,7 +421,12 @@ public static Dictionary<List<string>, int> FindCombinations2(int CompSize, List
 
                 if (CheckCompValidity(comp, excluded_comp_champions))
                 {
-                    parallel_results.Add(comp, Synergy);
+                    // ensure we don't insert comp that has already been added by another thread
+                    if (!parallel_results.ContainsKey(comp))
+                    {
+                        parallel_results.TryAdd(comp, Synergy);
+                    }
+
                 }
 
             });